[PATCH v2 0/2] phy: qcom: Add QCS9100 dwmac sgmii phy compatible

[PATCH v2 0/2] phy: qcom: Add QCS9100 dwmac sgmii phy compatible

[Tengfei Fan]

Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
all the compatible strings will be updated from "SA8775p" to "QCS9100".
The QCS9100 device tree patches will be pushed after all the device tree
bindings and device driver patches are reviewed.

The final dtsi will like:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/

The detailed cover letter reference:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Changes in v2:
  - Split huge patch series into different patch series according to
    subsytems
  - Update patch commit message

prevous disscussion here:
[1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

---
Tengfei Fan (2):
      dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100
      phy: qcom: add the SGMII SerDes PHY driver support

 .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        | 5 ++++-
 drivers/phy/qualcomm/phy-qcom-sgmii-eth.c                            | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)
---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240709-add_qcs9100_dwmac_sgmii_hpy_compatible-46dcc1347aa0

Best regards,
-- 
Tengfei Fan <quic_tengfan@quicinc.com>

[PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

[Tengfei Fan]

Document the Qualcomm SGMII PHY for the QCS9100 platforms.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
non-SCMI based the Qualcomm SGMII PHY.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
index b9107759b2a5..74ec4579c0d6 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
@@ -15,7 +15,10 @@ description:
 
 properties:
   compatible:
-    const: qcom,sa8775p-dwmac-sgmii-phy
+    items:
+      - enum:
+          - qcom,qcs9100-dwmac-sgmii-phy
+          - qcom,sa8775p-dwmac-sgmii-phy
 
   reg:
     items:

-- 
2.25.1

[PATCH v2 2/2] phy: qcom: add the SGMII SerDes PHY driver support

[Tengfei Fan]

Add the SGMII SerDes PHY driver support for QCS9100 platform.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to the
SGMII SerDes PHY device match table.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
index 5b1c82459c12..0ea7140564a9 100644
--- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
+++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
@@ -353,6 +353,7 @@ static int qcom_dwmac_sgmii_phy_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id qcom_dwmac_sgmii_phy_of_match[] = {
+	{ .compatible = "qcom,qcs9100-dwmac-sgmii-phy" },
 	{ .compatible = "qcom,sa8775p-dwmac-sgmii-phy" },
 	{ },
 };

-- 
2.25.1

Re: [PATCH v2 2/2] phy: qcom: add the SGMII SerDes PHY driver support

[Bartosz Golaszewski]

On Tue, 9 Jul 2024 at 17:16, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
> Add the SGMII SerDes PHY driver support for QCS9100 platform.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to the
> SGMII SerDes PHY device match table.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> index 5b1c82459c12..0ea7140564a9 100644
> --- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> +++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> @@ -353,6 +353,7 @@ static int qcom_dwmac_sgmii_phy_probe(struct platform_device *pdev)
>  }
>
>  static const struct of_device_id qcom_dwmac_sgmii_phy_of_match[] = {
> +       { .compatible = "qcom,qcs9100-dwmac-sgmii-phy" },
>         { .compatible = "qcom,sa8775p-dwmac-sgmii-phy" },
>         { },
>  };
>
> --
> 2.25.1
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org

Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

[Krzysztof Kozlowski]

On 09/07/2024 17:15, Tengfei Fan wrote:
> Document the Qualcomm SGMII PHY for the QCS9100 platforms.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
> non-SCMI based the Qualcomm SGMII PHY.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> index b9107759b2a5..74ec4579c0d6 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> @@ -15,7 +15,10 @@ description:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8775p-dwmac-sgmii-phy
> +    items:

items is not needed here, this could be an enum directly.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>



Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

[Tengfei Fan]

On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 17:15, Tengfei Fan wrote:
>> Document the Qualcomm SGMII PHY for the QCS9100 platforms.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
>> non-SCMI based the Qualcomm SGMII PHY.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>> index b9107759b2a5..74ec4579c0d6 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>> @@ -15,7 +15,10 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,sa8775p-dwmac-sgmii-phy
>> +    items:
> 
> items is not needed here, this could be an enum directly.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks Krzysztof!

In the next version patch series, I will check all the patch series, 
using an enum instead od items.

> 
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

[Tengfei Fan]

On 7/11/2024 11:52 AM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 17:15, Tengfei Fan wrote:
>>> Document the Qualcomm SGMII PHY for the QCS9100 platforms.
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
>>> non-SCMI based the Qualcomm SGMII PHY.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>   
>>> .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        
>>> | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> index b9107759b2a5..74ec4579c0d6 100644
>>> --- 
>>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> +++ 
>>> b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> @@ -15,7 +15,10 @@ description:
>>>   properties:
>>>     compatible:
>>> -    const: qcom,sa8775p-dwmac-sgmii-phy
>>> +    items:
>>
>> items is not needed here, this could be an enum directly.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Thanks Krzysztof!
> 
> In the next version patch series, I will check all the patch series, 
> using an enum instead od items.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 
>>
>>
>>
>> Best regards,
>> Krzysztof
>>
> 

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 2/2] phy: qcom: add the SGMII SerDes PHY driver support

[Tengfei Fan]

On 7/9/2024 11:42 PM, Bartosz Golaszewski wrote:
> On Tue, 9 Jul 2024 at 17:16, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Add the SGMII SerDes PHY driver support for QCS9100 platform.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to the
>> SGMII SerDes PHY device match table.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
>> index 5b1c82459c12..0ea7140564a9 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
>> @@ -353,6 +353,7 @@ static int qcom_dwmac_sgmii_phy_probe(struct platform_device *pdev)
>>   }
>>
>>   static const struct of_device_id qcom_dwmac_sgmii_phy_of_match[] = {
>> +       { .compatible = "qcom,qcs9100-dwmac-sgmii-phy" },
>>          { .compatible = "qcom,sa8775p-dwmac-sgmii-phy" },
>>          { },
>>   };
>>
>> --
>> 2.25.1
>>
> 
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan