mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Drobyshev <immortalguardian1@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gq@cs.msu.su, giometti@enneenne.com
Subject: [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.
Date: Wed, 15 Feb 2017 17:31:07 +0300	[thread overview]
Message-ID: <1487169069-15721-7-git-send-email-immortalguardian1@gmail.com> (raw)
In-Reply-To: <1487169069-15721-1-git-send-email-immortalguardian1@gmail.com>

From: Alexander GQ Gerasiov <gq@cs.msu.su>

On some devices interrupt may be invoked by parasitic assert event produced
while switching from high to low. Such interrupt should be ignored.

Signed-off-by: Alexander GQ Gerasiov <gq@cs.msu.su>
---
 drivers/pps/clients/pps_parport.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c
index 37094b0..39c1fea 100644
--- a/drivers/pps/clients/pps_parport.c
+++ b/drivers/pps/clients/pps_parport.c
@@ -69,6 +69,8 @@ static void parport_irq(void *handle)
 	struct pps_event_time ts_assert, ts_clear;
 	struct pps_client_pp *dev = handle;
 	struct parport *port = dev->pardev->port;
+	static struct pps_event_time prev;
+	static struct timespec64 ts_delta;
 	unsigned int i;
 	unsigned long flags;
 
@@ -95,9 +97,14 @@ static void parport_irq(void *handle)
 	/* check the signal (no signal means the pulse is lost this time) */
 	if (!signal_is_set(port)) {
 		local_irq_restore(flags);
-		dev_err(dev->pps->dev, "lost the signal\n");
+		ts_delta = timespec64_sub(ts_assert.ts_real, prev.ts_real);
+		/* do not print error message in case interrupt handler is
+		 * invoked by parasitic assert event */
+		if (timespec64_to_ns(&ts_delta) > (NSEC_PER_SEC / 2))
+			dev_err(dev->pps->dev, "lost the signal\n");
 		goto out_none;
 	}
+	prev = ts_assert;
 
 	/* poll the port until the signal is unset */
 	for (i = dev->cw; i; i--)
-- 
2.1.4

  parent reply	other threads:[~2017-02-15 14:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 14:31 [PATCH 0/8] LinuxPPS: some minor fixes and improvements Andrey Drobyshev
2017-02-15 14:31 ` [PATCH 1/8] hardpps: simple fixes replacing clumsy code with abs() macro Andrey Drobyshev
2017-03-04  7:36   ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal Andrey Drobyshev
2017-03-04  7:36   ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 3/8] hardpps: fix some pps_jitter issues Andrey Drobyshev
2017-03-04  7:37   ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event() Andrey Drobyshev
2017-03-04  7:38   ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal Andrey Drobyshev
2017-03-04  7:39   ` Rodolfo Giometti
2017-02-15 14:31 ` Andrey Drobyshev [this message]
2017-03-04  7:40   ` [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal Andrey Drobyshev
2017-03-04  7:42   ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource Andrey Drobyshev
2017-03-04  7:44   ` Rodolfo Giometti
2017-03-04  9:19     ` Alexander Gerasiov
2017-03-04 13:25       ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487169069-15721-7-git-send-email-immortalguardian1@gmail.com \
    --to=immortalguardian1@gmail.com \
    --cc=giometti@enneenne.com \
    --cc=gq@cs.msu.su \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®