From: Andrey Drobyshev <immortalguardian1@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gq@cs.msu.su, giometti@enneenne.com
Subject: [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event().
Date: Wed, 15 Feb 2017 17:31:05 +0300 [thread overview]
Message-ID: <1487169069-15721-5-git-send-email-immortalguardian1@gmail.com> (raw)
In-Reply-To: <1487169069-15721-1-git-send-email-immortalguardian1@gmail.com>
From: Alexander GQ Gerasiov <gq@redlab-i.ru>
Otherwise we get "scheduling while atomic" problem.
Signed-off-by: Alexander GQ Gerasiov <gq@redlab-i.ru>
---
drivers/pps/kapi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
index 805c749..a9a111d 100644
--- a/drivers/pps/kapi.c
+++ b/drivers/pps/kapi.c
@@ -226,11 +226,11 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
/* Wake up if captured something */
if (captured) {
pps->last_ev++;
+ spin_unlock_irqrestore(&pps->lock, flags);
wake_up_interruptible_all(&pps->queue);
-
kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
- }
- spin_unlock_irqrestore(&pps->lock, flags);
+ } else
+ spin_unlock_irqrestore(&pps->lock, flags);
}
EXPORT_SYMBOL(pps_event);
--
2.1.4
next prev parent reply other threads:[~2017-02-15 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 14:31 [PATCH 0/8] LinuxPPS: some minor fixes and improvements Andrey Drobyshev
2017-02-15 14:31 ` [PATCH 1/8] hardpps: simple fixes replacing clumsy code with abs() macro Andrey Drobyshev
2017-03-04 7:36 ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal Andrey Drobyshev
2017-03-04 7:36 ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 3/8] hardpps: fix some pps_jitter issues Andrey Drobyshev
2017-03-04 7:37 ` Rodolfo Giometti
2017-02-15 14:31 ` Andrey Drobyshev [this message]
2017-03-04 7:38 ` [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event() Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal Andrey Drobyshev
2017-03-04 7:39 ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous Andrey Drobyshev
2017-03-04 7:40 ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal Andrey Drobyshev
2017-03-04 7:42 ` Rodolfo Giometti
2017-02-15 14:31 ` [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource Andrey Drobyshev
2017-03-04 7:44 ` Rodolfo Giometti
2017-03-04 9:19 ` Alexander Gerasiov
2017-03-04 13:25 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487169069-15721-5-git-send-email-immortalguardian1@gmail.com \
--to=immortalguardian1@gmail.com \
--cc=giometti@enneenne.com \
--cc=gq@cs.msu.su \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®