From: Loic Pallardy <loic.pallardy@st.com>
To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <lee.jones@linaro.org>
Cc: <loic.pallardy@st.com>, <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@stlinux.com>,
<patrice.chotard@st.com>, <hugues.fruchet@st.com>,
<peter.griffin@linaro.org>
Subject: [PATCH v4 2/2] remoteproc: core: don't allocate carveout if pa is defined
Date: Wed, 15 Feb 2017 21:18:49 +0100 [thread overview]
Message-ID: <1487189929-24196-3-git-send-email-loic.pallardy@st.com> (raw)
In-Reply-To: <1487189929-24196-1-git-send-email-loic.pallardy@st.com>
Remoteproc doesn't check if firmware requests fixed
addresses for carveout regions.
Current assumption is that platform specific driver is in
charge of coprocessor specific memory region allocation and
remoteproc core doesn't have to handle them.
If a pa is specified in firmware resource table, remoteproc
core doesn't have to perform any allocation.
Access to carveout will be done thanks to rproc_da_to_pa function,
which will provide virtual address on carveout region allocated
by platform specific driver.
Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
Acked-by: Hugues Fruchet <hugues.fruchet@st.com>
Tested-by: Hugues Fruchet <hugues.fruchet@st.com>
---
Changes from V3:
- Fix Bjorn's remark: Don't check if da is already specified in resource table.
Because this doesn't mean buffer has been allocated, but that a specific da
is requested for IOMMU configuration.
- Rebase on rproc-next branch
---
drivers/remoteproc/remoteproc_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 3dabb20..74ad2d0 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -622,6 +622,11 @@ static int rproc_handle_carveout(struct rproc *rproc,
dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n",
rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags);
+ if (rsc->pa != FW_RSC_ADDR_ANY) {
+ dev_dbg(dev, "carveout already allocated by low level driver\n");
+ return 0;
+ }
+
carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
if (!carveout)
return -ENOMEM;
--
1.9.1
next prev parent reply other threads:[~2017-02-15 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 20:18 [PATCH v4 0/2] remoteproc: st: add virtio_rpmsg support Loic Pallardy
2017-02-15 20:18 ` [PATCH v4 1/2] remoteproc: st: add da to va support Loic Pallardy
2017-02-15 20:18 ` Loic Pallardy [this message]
2017-05-03 15:29 ` [PATCH v4 0/2] remoteproc: st: add virtio_rpmsg support Loic Pallardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487189929-24196-3-git-send-email-loic.pallardy@st.com \
--to=loic.pallardy@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®