mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: <peterz@infradead.org>, <mingo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <juri.lelli@gmail.com>,
	<rostedt@goodmis.org>, <kernel-team@lge.com>
Subject: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date: Thu, 16 Feb 2017 11:34:17 +0900	[thread overview]
Message-ID: <1487212457-28839-2-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <1487212457-28839-1-git-send-email-byungchul.park@lge.com>

pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
it returns a task other than NULL, which means that task_cpu(task) must
be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
rq->cpu as well. Remove the redundant condition and make code simpler.

By this patch, unnecessary one branch and two LOAD operations in 'if'
statement can be avoided.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Juri Lelli <juri.lelli@arm.com>
---
 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 4101f9d..5abd9a52 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1820,7 +1820,7 @@ static int push_rt_task(struct rq *rq)
 		 * pushing.
 		 */
 		task = pick_next_pushable_task(rq);
-		if (task_cpu(next_task) == rq->cpu && task == next_task) {
+		if (task == next_task) {
 			/*
 			 * The task hasn't migrated, and is still the next
 			 * eligible task, but we failed to find a run-queue
-- 
1.9.1

  reply	other threads:[~2017-02-16  2:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  2:34 [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Byungchul Park
2017-02-16  2:34 ` Byungchul Park [this message]
2017-02-16  2:45   ` [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Steven Rostedt
2017-02-16  3:03     ` Byungchul Park
2017-02-16  7:15     ` byungchul.park
2017-02-16  8:43       ` Juri Lelli
2017-02-16 17:36   ` Daniel Bristot de Oliveira
2017-02-16 17:35 ` [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Daniel Bristot de Oliveira
2017-03-21  2:56   ` Byungchul Park
2017-02-22  5:00 ` Byungchul Park
2017-05-02  7:43 ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487212457-28839-2-git-send-email-byungchul.park@lge.com \
    --to=byungchul.park@lge.com \
    --cc=juri.lelli@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®