From: Byungchul Park <byungchul.park@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
kernel-team@lge.com
Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date: Thu, 16 Feb 2017 12:03:02 +0900 [thread overview]
Message-ID: <20170216030302.GU16086@X58A-UD3R> (raw)
In-Reply-To: <20170215214537.7936f336@grimm.local.home>
On Wed, Feb 15, 2017 at 09:45:37PM -0500, Steven Rostedt wrote:
> On Thu, 16 Feb 2017 11:34:17 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
>
> > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > it returns a task other than NULL, which means that task_cpu(task) must
> > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > rq->cpu as well. Remove the redundant condition and make code simpler.
> >
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> >
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
> > ---
>
> This is a different patch, I don't believe Juri reviewed it yet.
I will take care not to make this kind of mistake next time.
Thank you very much.
>
> -- Steve
next prev parent reply other threads:[~2017-02-16 3:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 2:34 [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Byungchul Park
2017-02-16 2:34 ` [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Byungchul Park
2017-02-16 2:45 ` Steven Rostedt
2017-02-16 3:03 ` Byungchul Park [this message]
2017-02-16 7:15 ` byungchul.park
2017-02-16 8:43 ` Juri Lelli
2017-02-16 17:36 ` Daniel Bristot de Oliveira
2017-02-16 17:35 ` [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Daniel Bristot de Oliveira
2017-03-21 2:56 ` Byungchul Park
2017-02-22 5:00 ` Byungchul Park
2017-05-02 7:43 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216030302.GU16086@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®