mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] RDMA/bnxt_re: add DCB dependency
@ 2017-02-17 14:40 Arnd Bergmann
  2017-02-19 13:58 ` Doug Ledford
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-02-17 14:40 UTC (permalink / raw)
  To: Selvin Xavier, Doug Ledford, Sean Hefty
  Cc: Arnd Bergmann, Devesh Sharma, Somnath Kotur,
	Sriharsha Basavapatna, Hal Rosenstock, Leon Romanovsky,
	linux-rdma, linux-kernel

When CONFIG_DCB is disabled, we get a link error:

drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos':
trace.c:(.text+0x155774): undefined reference to `dcb_ieee_getapp_mask'
trace.c:(.text+0x155774): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'
trace.c:(.text+0x155794): undefined reference to `dcb_ieee_getapp_mask'
trace.c:(.text+0x155794): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'

Like the other drivers that use this function, a Kconfig dependency is
the correct fix.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/infiniband/hw/bnxt_re/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig
index cd0175e32584..19982a4a9bba 100644
--- a/drivers/infiniband/hw/bnxt_re/Kconfig
+++ b/drivers/infiniband/hw/bnxt_re/Kconfig
@@ -1,6 +1,6 @@
 config INFINIBAND_BNXT_RE
     tristate "Broadcom Netxtreme HCA support"
-    depends on ETHERNET && NETDEVICES && PCI && INET
+    depends on ETHERNET && NETDEVICES && PCI && INET && DCB
     select NET_VENDOR_BROADCOM
     select BNXT
     ---help---
-- 
2.9.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] RDMA/bnxt_re: add DCB dependency
  2017-02-17 14:40 [PATCH] RDMA/bnxt_re: add DCB dependency Arnd Bergmann
@ 2017-02-19 13:58 ` Doug Ledford
  0 siblings, 0 replies; 2+ messages in thread
From: Doug Ledford @ 2017-02-19 13:58 UTC (permalink / raw)
  To: Arnd Bergmann, Selvin Xavier, Sean Hefty
  Cc: Devesh Sharma, Somnath Kotur, Sriharsha Basavapatna,
	Hal Rosenstock, Leon Romanovsky, linux-rdma, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On Fri, 2017-02-17 at 15:40 +0100, Arnd Bergmann wrote:
> When CONFIG_DCB is disabled, we get a link error:
> 
> drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos':
> trace.c:(.text+0x155774): undefined reference to
> `dcb_ieee_getapp_mask'
> trace.c:(.text+0x155774): relocation truncated to fit:
> R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'
> trace.c:(.text+0x155794): undefined reference to
> `dcb_ieee_getapp_mask'
> trace.c:(.text+0x155794): relocation truncated to fit:
> R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'
> 
> Like the other drivers that use this function, a Kconfig dependency
> is
> the correct fix.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-19 13:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17 14:40 [PATCH] RDMA/bnxt_re: add DCB dependency Arnd Bergmann
2017-02-19 13:58 ` Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome