From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wang Nan <wangnan0@huawei.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH 0/4] perf annotate: Fixes for line numbers and Introduce source_code
Date: Wed, 22 Feb 2017 19:08:19 +0900 [thread overview]
Message-ID: <1487758103-7953-1-git-send-email-treeze.taeung@gmail.com> (raw)
Hi, :)
Currently perf-annotate have several problems.
- Wrong line numbers on perf-annotate (both stdio and TUI)
- Wrong sum of overhead(percent) matching source lines
- It's so confusing that the output is mixed with
both source code and assembly code. (related to depending on 'objdump -S')
So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.
In near future, I have a plan for new reable annotate view
base on source code (per function(sym)) using the 'struct source_code'. :)
I'd appreciate some feedback.
(Current v1 don't consider improvement of performance of annotate
and don't make code of annotate more compact so I'll consider them in v2)
Thanks,
Taeung
Taeung Song (4):
perf annotate: Remove needless regular expression for filename:linenr
perf annotate: Align filename:linenr and more correct summary
perf annotate: Change the method counting line numbers
perf annotate: Introduce source_code to collect actual code
tools/perf/util/annotate.c | 174 +++++++++++++++++++++++++++++++++++----------
tools/perf/util/annotate.h | 7 ++
2 files changed, 144 insertions(+), 37 deletions(-)
--
2.7.4
next reply other threads:[~2017-02-22 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 10:08 Taeung Song [this message]
2017-02-22 10:08 ` [PATCH 1/4] perf annotate: Remove needless regular expression for filename:linenr Taeung Song
2017-02-22 10:47 ` Namhyung Kim
2017-02-22 16:00 ` Taeung Song
2017-02-22 10:08 ` [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary Taeung Song
2017-02-22 11:12 ` Namhyung Kim
2017-02-22 11:22 ` Namhyung Kim
2017-02-22 16:31 ` Taeung Song
2017-02-22 10:08 ` [PATCH 3/4] perf annotate: Change the method counting line numbers Taeung Song
2017-02-22 10:08 ` [PATCH 4/4] perf annotate: Introduce source_code to collect actual code Taeung Song
2017-02-22 11:27 ` Namhyung Kim
2017-02-22 16:41 ` Taeung Song
2017-02-24 5:57 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487758103-7953-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome