mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>,
	arnaud.patard@rtp-net.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] staging: xgifb: correct the multiple line dereference
Date: Sun, 26 Feb 2017 08:12:11 -0800	[thread overview]
Message-ID: <1488125531.9188.1.camel@perches.com> (raw)
In-Reply-To: <20170226155329.GA19949@arushi-HP-Pavilion-Notebook>

On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as "Avoid multiple line
> dereference".And If there is boolean operator then it is 
> fixed by Splitting line at boolean operator to satisfy coding 
> style.
[]
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
[]
> @@ -878,30 +878,18 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
> 
[]
>  				xgifb_reg_set(
> -					XGIPART2,
> -					0x37,
> -					(XGI_TV_filter[filter_tb].
> -						filter[filter][2]));
> +					XGIPART2, 0x35, f[0]);
> +			        xgifb_reg_set(
> +					XGIPART2, 0x36, f[1]);
> +			        xgifb_reg_set(
> +					XGIPART2, 0x37, f[2]);

0        1         2         3         4         5         6         7         8
12345678901234567890123456789012345678901234567890123456789012345678901234567890

				xgifb_reg_set(XGIPART2, 0x37, f[2]);

All of these fit nicely on a single line and you should
submit patches that make the most sense and do not need
revision when reformatting.

Please reformat all instances as above and resubmit.

      reply	other threads:[~2017-02-26 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26 15:53 Arushi Singhal
2017-02-26 16:12 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488125531.9188.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=arnaud.patard@rtp-net.org \
    --cc=arushisinghal19971997@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®