From: Joe Perches <joe@perches.com>
To: "Michel Hermier" <michel.hermier@gmail.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Stefan Achatz" <erazor_de@users.sourceforge.net>,
"Jonathan Cameron" <jic23@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: Remove unnecessary OOM messages
Date: Wed, 01 Mar 2017 22:54:56 -0800 [thread overview]
Message-ID: <1488437696.2179.3.camel@perches.com> (raw)
In-Reply-To: <a52260a5-921c-53f9-8709-ae7189395cee@gmail.com>
On Thu, 2017-03-02 at 07:51 +0100, Michel Hermier wrote:
> Le 01/03/2017 à 20:19, Joe Perches a écrit :
> > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
[]
> > @@ -224,7 +224,6 @@ static int asus_start_multitouch(struct hid_device *hdev)
> >
> > if (!dmabuf) {
> > ret = -ENOMEM;
> > - hid_err(hdev, "Asus failed to alloc dma buf: %d\n", ret);
> > return ret;
> > }
>
> Trivial set and return value missed.
You're welcome to submit a follow-on patch.
The compiler should produce the same code
in any case.
prev parent reply other threads:[~2017-03-02 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 19:19 [PATCH 0/2] HID: allocation neatening and code size reduction Joe Perches
2017-03-01 19:19 ` [PATCH 1/2] HID: Use krealloc Joe Perches
2017-03-01 19:19 ` [PATCH 2/2] HID: Remove unnecessary OOM messages Joe Perches
2017-03-02 6:51 ` Michel Hermier
2017-03-02 6:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488437696.2179.3.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bonbons@linux-vserver.org \
--cc=erazor_de@users.sourceforge.net \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.hermier@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome