[PATCH 00/10] staging: iio: Remove exceptional & on functions name

[PATCH 00/10] staging: iio: Remove exceptional & on functions name

[simran singhal]

This patch-series removes exceptional & on functions name.

simran singhal (10):
  staging: iio: ad7192: Remove exceptional & on function name
  staging: iio: ad7780: Remove exceptional & on function name
  staging: iio: cdc: ad7746: Remove exceptional & on function name
  staging: iio: cdc: ad7152: Remove exceptional & on function name
  staging: iio: adis16240: Remove exceptional & on function name
  staging: iio: adis16201: Remove exceptional & on function name
  staging: iio: adis16209: Remove exceptional & on function name
  staging: iio: adis16203: Remove exceptional & on function name
  staging: iio: resolver: Remove exceptional & on function name
  staging: iio: gyro: Remove exceptional & on function name

 drivers/staging/iio/accel/adis16201.c     |  4 ++--
 drivers/staging/iio/accel/adis16203.c     |  4 ++--
 drivers/staging/iio/accel/adis16209.c     |  4 ++--
 drivers/staging/iio/accel/adis16240.c     |  4 ++--
 drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
 drivers/staging/iio/adc/ad7780.c          |  2 +-
 drivers/staging/iio/cdc/ad7152.c          |  6 +++---
 drivers/staging/iio/cdc/ad7746.c          |  4 ++--
 drivers/staging/iio/gyro/adis16060_core.c |  2 +-
 drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
 drivers/staging/iio/resolver/ad2s90.c     |  2 +-
 11 files changed, 23 insertions(+), 23 deletions(-)

-- 
2.7.4

[PATCH 01/10] staging: iio: ad7192: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 4fc8588..d11c6de 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev,
 }
 
 static const struct iio_info ad7192_info = {
-	.read_raw = &ad7192_read_raw,
-	.write_raw = &ad7192_write_raw,
-	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
+	.read_raw = ad7192_read_raw,
+	.write_raw = ad7192_write_raw,
+	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
 	.attrs = &ad7192_attribute_group,
 	.validate_trigger = ad_sd_validate_trigger,
 	.driver_module = THIS_MODULE,
 };
 
 static const struct iio_info ad7195_info = {
-	.read_raw = &ad7192_read_raw,
-	.write_raw = &ad7192_write_raw,
-	.write_raw_get_fmt = &ad7192_write_raw_get_fmt,
+	.read_raw = ad7192_read_raw,
+	.write_raw = ad7192_write_raw,
+	.write_raw_get_fmt = ad7192_write_raw_get_fmt,
 	.attrs = &ad7195_attribute_group,
 	.validate_trigger = ad_sd_validate_trigger,
 	.driver_module = THIS_MODULE,
-- 
2.7.4

[PATCH 02/10] staging: iio: ad7780: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/adc/ad7780.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index e149600..dec3ba6 100644
--- a/drivers/staging/iio/adc/ad7780.c
+++ b/drivers/staging/iio/adc/ad7780.c
@@ -154,7 +154,7 @@ static const struct ad7780_chip_info ad7780_chip_info_tbl[] = {
 };
 
 static const struct iio_info ad7780_info = {
-	.read_raw = &ad7780_read_raw,
+	.read_raw = ad7780_read_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[PATCH 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/cdc/ad7746.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 81f8b9e..6294de7 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -664,8 +664,8 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
 
 static const struct iio_info ad7746_info = {
 	.attrs = &ad7746_attribute_group,
-	.read_raw = &ad7746_read_raw,
-	.write_raw = &ad7746_write_raw,
+	.read_raw = ad7746_read_raw,
+	.write_raw = ad7746_write_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[PATCH 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/cdc/ad7152.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index e8609b8..59ef93c 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -441,9 +441,9 @@ static int ad7152_write_raw_get_fmt(struct iio_dev *indio_dev,
 
 static const struct iio_info ad7152_info = {
 	.attrs = &ad7152_attribute_group,
-	.read_raw = &ad7152_read_raw,
-	.write_raw = &ad7152_write_raw,
-	.write_raw_get_fmt = &ad7152_write_raw_get_fmt,
+	.read_raw = ad7152_read_raw,
+	.write_raw = ad7152_write_raw,
+	.write_raw_get_fmt = ad7152_write_raw_get_fmt,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[PATCH 05/10] staging: iio: adis16240: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/accel/adis16240.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 27d7f6a..37a29dc 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -373,8 +373,8 @@ static const struct attribute_group adis16240_attribute_group = {
 
 static const struct iio_info adis16240_info = {
 	.attrs = &adis16240_attribute_group,
-	.read_raw = &adis16240_read_raw,
-	.write_raw = &adis16240_write_raw,
+	.read_raw = adis16240_read_raw,
+	.write_raw = adis16240_write_raw,
 	.update_scan_mode = adis_update_scan_mode,
 	.driver_module = THIS_MODULE,
 };
-- 
2.7.4

[PATCH 06/10] staging: iio: adis16201: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/accel/adis16201.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
index d6c8658..7565268 100644
--- a/drivers/staging/iio/accel/adis16201.c
+++ b/drivers/staging/iio/accel/adis16201.c
@@ -285,8 +285,8 @@ static const struct iio_chan_spec adis16201_channels[] = {
 };
 
 static const struct iio_info adis16201_info = {
-	.read_raw = &adis16201_read_raw,
-	.write_raw = &adis16201_write_raw,
+	.read_raw = adis16201_read_raw,
+	.write_raw = adis16201_write_raw,
 	.update_scan_mode = adis_update_scan_mode,
 	.driver_module = THIS_MODULE,
 };
-- 
2.7.4

[PATCH 07/10] staging: iio: adis16209: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/accel/adis16209.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
index 8ff537f..56bc2ac 100644
--- a/drivers/staging/iio/accel/adis16209.c
+++ b/drivers/staging/iio/accel/adis16209.c
@@ -285,8 +285,8 @@ static const struct iio_chan_spec adis16209_channels[] = {
 };
 
 static const struct iio_info adis16209_info = {
-	.read_raw = &adis16209_read_raw,
-	.write_raw = &adis16209_write_raw,
+	.read_raw = adis16209_read_raw,
+	.write_raw = adis16209_write_raw,
 	.update_scan_mode = adis_update_scan_mode,
 	.driver_module = THIS_MODULE,
 };
-- 
2.7.4

[PATCH 08/10] staging: iio: adis16203: Remove exceptional & on function name

[simran singhal]

In this file, function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/accel/adis16203.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 68189ad..b59755a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -233,8 +233,8 @@ static const struct iio_chan_spec adis16203_channels[] = {
 };
 
 static const struct iio_info adis16203_info = {
-	.read_raw = &adis16203_read_raw,
-	.write_raw = &adis16203_write_raw,
+	.read_raw = adis16203_read_raw,
+	.write_raw = adis16203_write_raw,
 	.update_scan_mode = adis_update_scan_mode,
 	.driver_module = THIS_MODULE,
 };
-- 
2.7.4

[PATCH 09/10] staging: iio: resolver: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/resolver/ad2s1200.c | 2 +-
 drivers/staging/iio/resolver/ad2s90.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
index 82b2d88..a37e199 100644
--- a/drivers/staging/iio/resolver/ad2s1200.c
+++ b/drivers/staging/iio/resolver/ad2s1200.c
@@ -97,7 +97,7 @@ static const struct iio_chan_spec ad2s1200_channels[] = {
 };
 
 static const struct iio_info ad2s1200_info = {
-	.read_raw = &ad2s1200_read_raw,
+	.read_raw = ad2s1200_read_raw,
 	.driver_module = THIS_MODULE,
 };
 
diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c
index 5b1c0db..b227090 100644
--- a/drivers/staging/iio/resolver/ad2s90.c
+++ b/drivers/staging/iio/resolver/ad2s90.c
@@ -47,7 +47,7 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev,
 }
 
 static const struct iio_info ad2s90_info = {
-	.read_raw = &ad2s90_read_raw,
+	.read_raw = ad2s90_read_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

[PATCH 10/10] staging: iio: gyro: Remove exceptional & on function name

[simran singhal]

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/iio/gyro/adis16060_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
index ab816a2..c9d46e7 100644
--- a/drivers/staging/iio/gyro/adis16060_core.c
+++ b/drivers/staging/iio/gyro/adis16060_core.c
@@ -117,7 +117,7 @@ static int adis16060_read_raw(struct iio_dev *indio_dev,
 }
 
 static const struct iio_info adis16060_info = {
-	.read_raw = &adis16060_read_raw,
+	.read_raw = adis16060_read_raw,
 	.driver_module = THIS_MODULE,
 };
 
-- 
2.7.4

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

[Julia Lawall]

On Sat, 11 Mar 2017, simran singhal wrote:

> This patch-series removes exceptional & on functions name.

The semantic patch shown does nothing to check that the use of & is
exception in the given file.  It just removes all the & on function names.

julia

>
> simran singhal (10):
>   staging: iio: ad7192: Remove exceptional & on function name
>   staging: iio: ad7780: Remove exceptional & on function name
>   staging: iio: cdc: ad7746: Remove exceptional & on function name
>   staging: iio: cdc: ad7152: Remove exceptional & on function name
>   staging: iio: adis16240: Remove exceptional & on function name
>   staging: iio: adis16201: Remove exceptional & on function name
>   staging: iio: adis16209: Remove exceptional & on function name
>   staging: iio: adis16203: Remove exceptional & on function name
>   staging: iio: resolver: Remove exceptional & on function name
>   staging: iio: gyro: Remove exceptional & on function name
>
>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
>  drivers/staging/iio/adc/ad7780.c          |  2 +-
>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
>  11 files changed, 23 insertions(+), 23 deletions(-)
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1489203401-17518-1-git-send-email-singhalsimran0%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

[SIMRAN SINGHAL]

On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sat, 11 Mar 2017, simran singhal wrote:
>
>> This patch-series removes exceptional & on functions name.
>
> The semantic patch shown does nothing to check that the use of & is
> exception in the given file.  It just removes all the & on function names.
>
yes, I used this semantic patch only for only finding the functions with &
and then I find out this drivers and use semantic patch for removing &.

> julia
>
>>
>> simran singhal (10):
>>   staging: iio: ad7192: Remove exceptional & on function name
>>   staging: iio: ad7780: Remove exceptional & on function name
>>   staging: iio: cdc: ad7746: Remove exceptional & on function name
>>   staging: iio: cdc: ad7152: Remove exceptional & on function name
>>   staging: iio: adis16240: Remove exceptional & on function name
>>   staging: iio: adis16201: Remove exceptional & on function name
>>   staging: iio: adis16209: Remove exceptional & on function name
>>   staging: iio: adis16203: Remove exceptional & on function name
>>   staging: iio: resolver: Remove exceptional & on function name
>>   staging: iio: gyro: Remove exceptional & on function name
>>
>>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
>>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
>>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
>>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
>>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
>>  drivers/staging/iio/adc/ad7780.c          |  2 +-
>>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
>>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
>>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
>>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
>>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
>>  11 files changed, 23 insertions(+), 23 deletions(-)
>>
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1489203401-17518-1-git-send-email-singhalsimran0%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

[Julia Lawall]

On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:

> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sat, 11 Mar 2017, simran singhal wrote:
> >
> >> This patch-series removes exceptional & on functions name.
> >
> > The semantic patch shown does nothing to check that the use of & is
> > exception in the given file.  It just removes all the & on function names.
> >
> yes, I used this semantic patch only for only finding the functions with &
> and then I find out this drivers and use semantic patch for removing &.

The commit message should be written with respect to what was actually
done, and not copied from a patch that actually did something else.  The
original semantic patch, that was probably only put in the cover letter,
actually checked if the file mostly used function pointers in a particular
way.

julia

>
> > julia
> >
> >>
> >> simran singhal (10):
> >>   staging: iio: ad7192: Remove exceptional & on function name
> >>   staging: iio: ad7780: Remove exceptional & on function name
> >>   staging: iio: cdc: ad7746: Remove exceptional & on function name
> >>   staging: iio: cdc: ad7152: Remove exceptional & on function name
> >>   staging: iio: adis16240: Remove exceptional & on function name
> >>   staging: iio: adis16201: Remove exceptional & on function name
> >>   staging: iio: adis16209: Remove exceptional & on function name
> >>   staging: iio: adis16203: Remove exceptional & on function name
> >>   staging: iio: resolver: Remove exceptional & on function name
> >>   staging: iio: gyro: Remove exceptional & on function name
> >>
> >>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
> >>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
> >>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
> >>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
> >>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
> >>  drivers/staging/iio/adc/ad7780.c          |  2 +-
> >>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
> >>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
> >>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
> >>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
> >>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
> >>  11 files changed, 23 insertions(+), 23 deletions(-)
> >>
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1489203401-17518-1-git-send-email-singhalsimran0%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyODTiF%2BgdwwYnmL1W1oi-R0u2rM4c40jb5iWXFxJpfdJw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

[SIMRAN SINGHAL]

On Sat, Mar 11, 2017 at 2:57 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
>
>> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 11 Mar 2017, simran singhal wrote:
>> >
>> >> This patch-series removes exceptional & on functions name.
>> >
>> > The semantic patch shown does nothing to check that the use of & is
>> > exception in the given file.  It just removes all the & on function names.
>> >
>> yes, I used this semantic patch only for only finding the functions with &
>> and then I find out this drivers and use semantic patch for removing &.
>
> The commit message should be written with respect to what was actually
> done, and not copied from a patch that actually did something else.  The
> original semantic patch, that was probably only put in the cover letter,
> actually checked if the file mostly used function pointers in a particular
> way.
>
Julia, so what should I do?
I should not include this semantic patch as it does not check that that the use
of & is exception in the given file.
OR
As I did it manually so I should mention this.

> julia
>
>>
>> > julia
>> >
>> >>
>> >> simran singhal (10):
>> >>   staging: iio: ad7192: Remove exceptional & on function name
>> >>   staging: iio: ad7780: Remove exceptional & on function name
>> >>   staging: iio: cdc: ad7746: Remove exceptional & on function name
>> >>   staging: iio: cdc: ad7152: Remove exceptional & on function name
>> >>   staging: iio: adis16240: Remove exceptional & on function name
>> >>   staging: iio: adis16201: Remove exceptional & on function name
>> >>   staging: iio: adis16209: Remove exceptional & on function name
>> >>   staging: iio: adis16203: Remove exceptional & on function name
>> >>   staging: iio: resolver: Remove exceptional & on function name
>> >>   staging: iio: gyro: Remove exceptional & on function name
>> >>
>> >>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
>> >>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
>> >>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
>> >>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
>> >>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
>> >>  drivers/staging/iio/adc/ad7780.c          |  2 +-
>> >>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
>> >>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
>> >>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
>> >>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
>> >>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
>> >>  11 files changed, 23 insertions(+), 23 deletions(-)
>> >>
>> >> --
>> >> 2.7.4
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1489203401-17518-1-git-send-email-singhalsimran0%40gmail.com.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyODTiF%2BgdwwYnmL1W1oi-R0u2rM4c40jb5iWXFxJpfdJw%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

[Julia Lawall]

On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:

> On Sat, Mar 11, 2017 at 2:57 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
> >
> >> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> >
> >> >
> >> > On Sat, 11 Mar 2017, simran singhal wrote:
> >> >
> >> >> This patch-series removes exceptional & on functions name.
> >> >
> >> > The semantic patch shown does nothing to check that the use of & is
> >> > exception in the given file.  It just removes all the & on function names.
> >> >
> >> yes, I used this semantic patch only for only finding the functions with &
> >> and then I find out this drivers and use semantic patch for removing &.
> >
> > The commit message should be written with respect to what was actually
> > done, and not copied from a patch that actually did something else.  The
> > original semantic patch, that was probably only put in the cover letter,
> > actually checked if the file mostly used function pointers in a particular
> > way.
> >
> Julia, so what should I do?
> I should not include this semantic patch as it does not check that that the use
> of & is exception in the given file.
> OR
> As I did it manually so I should mention this.

If you checked it manually, just mention that.  I don't have the actual
patches handy any more, but you could also say something like:

Remove & from function pointers to conform to the style found elsewhere in
the file.  Done using the following semantic patch.

This would be ok if the included semantic patch makes the change.  It
doesn't suggest that the semantic patch checkked for the excpeptionality.

julia

>
> > julia
> >
> >>
> >> > julia
> >> >
> >> >>
> >> >> simran singhal (10):
> >> >>   staging: iio: ad7192: Remove exceptional & on function name
> >> >>   staging: iio: ad7780: Remove exceptional & on function name
> >> >>   staging: iio: cdc: ad7746: Remove exceptional & on function name
> >> >>   staging: iio: cdc: ad7152: Remove exceptional & on function name
> >> >>   staging: iio: adis16240: Remove exceptional & on function name
> >> >>   staging: iio: adis16201: Remove exceptional & on function name
> >> >>   staging: iio: adis16209: Remove exceptional & on function name
> >> >>   staging: iio: adis16203: Remove exceptional & on function name
> >> >>   staging: iio: resolver: Remove exceptional & on function name
> >> >>   staging: iio: gyro: Remove exceptional & on function name
> >> >>
> >> >>  drivers/staging/iio/accel/adis16201.c     |  4 ++--
> >> >>  drivers/staging/iio/accel/adis16203.c     |  4 ++--
> >> >>  drivers/staging/iio/accel/adis16209.c     |  4 ++--
> >> >>  drivers/staging/iio/accel/adis16240.c     |  4 ++--
> >> >>  drivers/staging/iio/adc/ad7192.c          | 12 ++++++------
> >> >>  drivers/staging/iio/adc/ad7780.c          |  2 +-
> >> >>  drivers/staging/iio/cdc/ad7152.c          |  6 +++---
> >> >>  drivers/staging/iio/cdc/ad7746.c          |  4 ++--
> >> >>  drivers/staging/iio/gyro/adis16060_core.c |  2 +-
> >> >>  drivers/staging/iio/resolver/ad2s1200.c   |  2 +-
> >> >>  drivers/staging/iio/resolver/ad2s90.c     |  2 +-
> >> >>  11 files changed, 23 insertions(+), 23 deletions(-)
> >> >>
> >> >> --
> >> >> 2.7.4
> >> >>
> >> >> --
> >> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1489203401-17518-1-git-send-email-singhalsimran0%40gmail.com.
> >> >> For more options, visit https://groups.google.com/d/optout.
> >> >>
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyODTiF%2BgdwwYnmL1W1oi-R0u2rM4c40jb5iWXFxJpfdJw%40mail.gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>