From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org, andreyknvl@google.com
Cc: dvyukov@google.com, marc.zyngier@arm.com,
christoffer.dall@linaro.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kcc@google.com, syzkaller@googlegroups.com, will.deacon@arm.com,
catalin.marinas@arm.com, pbonzini@redhat.com,
mark.rutland@arm.com, suzuki.poulose@arm.com,
ard.biesheuvel@linaro.org, stable@vger.kernel.org
Subject: [PATCH 1/3] kvm: arm/arm64: Take mmap_sem in stage2_unmap_vm
Date: Tue, 14 Mar 2017 14:52:32 +0000 [thread overview]
Message-ID: <1489503154-20705-2-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1489503154-20705-1-git-send-email-suzuki.poulose@arm.com>
From: Marc Zyngier <marc.zyngier@arm.com>
We don't hold the mmap_sem while searching for the VMAs when
we try to unmap each memslot for a VM. Fix this properly to
avoid unexpected results.
Fixes: commit 957db105c997 ("arm/arm64: KVM: Introduce stage2_unmap_vm")
Cc: stable@vger.kernel.org # v3.19+
Cc: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
arch/arm/kvm/mmu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
index 962616f..f2e2e0c 100644
--- a/arch/arm/kvm/mmu.c
+++ b/arch/arm/kvm/mmu.c
@@ -803,6 +803,7 @@ void stage2_unmap_vm(struct kvm *kvm)
int idx;
idx = srcu_read_lock(&kvm->srcu);
+ down_read(¤t->mm->mmap_sem);
spin_lock(&kvm->mmu_lock);
slots = kvm_memslots(kvm);
@@ -810,6 +811,7 @@ void stage2_unmap_vm(struct kvm *kvm)
stage2_unmap_memslot(kvm, memslot);
spin_unlock(&kvm->mmu_lock);
+ up_read(¤t->mm->mmap_sem);
srcu_read_unlock(&kvm->srcu, idx);
}
--
2.7.4
next prev parent reply other threads:[~2017-03-14 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:52 [PATCH 0/3] kvm: arm/arm64: Fixes for use after free problems Suzuki K Poulose
2017-03-14 14:52 ` Suzuki K Poulose [this message]
2017-03-15 9:17 ` [PATCH 1/3] kvm: arm/arm64: Take mmap_sem in stage2_unmap_vm Christoffer Dall
2017-03-15 9:34 ` Marc Zyngier
2017-03-15 11:05 ` Christoffer Dall
2017-03-15 13:29 ` Paolo Bonzini
2017-03-14 14:52 ` [PATCH 2/3] kvm: arm/arm64: Take mmap_sem in kvm_arch_prepare_memory_region Suzuki K Poulose
2017-03-15 11:05 ` Christoffer Dall
2017-03-14 14:52 ` [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd Suzuki K Poulose
2017-03-15 9:21 ` Christoffer Dall
2017-03-15 9:39 ` Marc Zyngier
2017-03-15 10:56 ` Christoffer Dall
2017-03-15 13:28 ` Marc Zyngier
2017-03-15 13:35 ` Christoffer Dall
2017-03-15 13:43 ` Marc Zyngier
2017-03-15 13:50 ` Robin Murphy
2017-03-15 13:55 ` Marc Zyngier
2017-03-15 14:33 ` Suzuki K Poulose
2017-03-15 15:07 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489503154-20705-2-git-send-email-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dvyukov@google.com \
--cc=kcc@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®