From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org, andreyknvl@google.com
Cc: dvyukov@google.com, marc.zyngier@arm.com,
christoffer.dall@linaro.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kcc@google.com, syzkaller@googlegroups.com, will.deacon@arm.com,
catalin.marinas@arm.com, pbonzini@redhat.com,
mark.rutland@arm.com, suzuki.poulose@arm.com,
ard.biesheuvel@linaro.org, stable@vger.kernel.org
Subject: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd
Date: Tue, 14 Mar 2017 14:52:34 +0000 [thread overview]
Message-ID: <1489503154-20705-4-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1489503154-20705-1-git-send-email-suzuki.poulose@arm.com>
In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling
unmap_stage2_range() on the entire memory range for the guest. This could
cause problems with other callers (e.g, munmap on a memslot) trying to
unmap a range.
Fixes: commit d5d8184d35c9 ("KVM: ARM: Memory virtualization setup")
Cc: stable@vger.kernel.org # v3.10+
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
arch/arm/kvm/mmu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
index 13b9c1f..b361f71 100644
--- a/arch/arm/kvm/mmu.c
+++ b/arch/arm/kvm/mmu.c
@@ -831,7 +831,10 @@ void kvm_free_stage2_pgd(struct kvm *kvm)
if (kvm->arch.pgd == NULL)
return;
+ spin_lock(&kvm->mmu_lock);
unmap_stage2_range(kvm, 0, KVM_PHYS_SIZE);
+ spin_unlock(&kvm->mmu_lock);
+
/* Free the HW pgd, one page at a time */
free_pages_exact(kvm->arch.pgd, S2_PGD_SIZE);
kvm->arch.pgd = NULL;
--
2.7.4
next prev parent reply other threads:[~2017-03-14 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:52 [PATCH 0/3] kvm: arm/arm64: Fixes for use after free problems Suzuki K Poulose
2017-03-14 14:52 ` [PATCH 1/3] kvm: arm/arm64: Take mmap_sem in stage2_unmap_vm Suzuki K Poulose
2017-03-15 9:17 ` Christoffer Dall
2017-03-15 9:34 ` Marc Zyngier
2017-03-15 11:05 ` Christoffer Dall
2017-03-15 13:29 ` Paolo Bonzini
2017-03-14 14:52 ` [PATCH 2/3] kvm: arm/arm64: Take mmap_sem in kvm_arch_prepare_memory_region Suzuki K Poulose
2017-03-15 11:05 ` Christoffer Dall
2017-03-14 14:52 ` Suzuki K Poulose [this message]
2017-03-15 9:21 ` [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd Christoffer Dall
2017-03-15 9:39 ` Marc Zyngier
2017-03-15 10:56 ` Christoffer Dall
2017-03-15 13:28 ` Marc Zyngier
2017-03-15 13:35 ` Christoffer Dall
2017-03-15 13:43 ` Marc Zyngier
2017-03-15 13:50 ` Robin Murphy
2017-03-15 13:55 ` Marc Zyngier
2017-03-15 14:33 ` Suzuki K Poulose
2017-03-15 15:07 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489503154-20705-4-git-send-email-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dvyukov@google.com \
--cc=kcc@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®