From: Gioh Kim <gi-oh.kim@profitbricks.com>
To: jes.sorensen@gmail.com
Cc: neilb@suse.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jack Wang <jinpu.wang@profitbricks.com>
Subject: [PATCHv2 2/2] super1: check and output faulty dev role
Date: Mon, 20 Mar 2017 10:51:57 +0100 [thread overview]
Message-ID: <1490003517-4216-3-git-send-email-gi-oh.kim@profitbricks.com> (raw)
In-Reply-To: <1490003517-4216-1-git-send-email-gi-oh.kim@profitbricks.com>
From: Jack Wang <jinpu.wang@profitbricks.com>
Output the real dev role in examine_super1, it will help to
find problem.
Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: Gioh Kim <gi-oh.kim@profitbricks.com>
---
super1.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/super1.c b/super1.c
index f3520ac..c903371 100644
--- a/super1.c
+++ b/super1.c
@@ -501,8 +501,10 @@ static void examine_super1(struct supertype *st, char *homehost)
#endif
printf(" Device Role : ");
role = role_from_sb(sb);
- if (role >= MD_DISK_ROLE_FAULTY)
- printf("spare\n");
+ if (role == MD_DISK_ROLE_SPARE)
+ printf("Spare\n");
+ else if (role == MD_DISK_ROLE_FAULTY)
+ printf("Faulty\n");
else if (role == MD_DISK_ROLE_JOURNAL)
printf("Journal\n");
else if (sb->feature_map & __cpu_to_le32(MD_FEATURE_REPLACEMENT))
--
2.5.0
next prev parent reply other threads:[~2017-03-20 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:51 [PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast Gioh Kim
2017-03-20 9:51 ` [PATCHv2 1/2] super1: ignore failfast flag for setting device role Gioh Kim
2017-03-28 18:01 ` jes.sorensen
2017-03-20 9:51 ` Gioh Kim [this message]
2017-03-21 19:55 ` [PATCHv2 2/2] super1: check and output faulty dev role NeilBrown
2017-03-22 10:23 ` Jinpu Wang
2017-03-27 10:59 ` [PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490003517-4216-3-git-send-email-gi-oh.kim@profitbricks.com \
--to=gi-oh.kim@profitbricks.com \
--cc=jes.sorensen@gmail.com \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®