mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jes.sorensen@gmail.com
To: Gioh Kim <gi-oh.kim@profitbricks.com>
Cc: neilb@suse.com, linux-raid@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jack Wang <jinpu.wang@profitbricks.com>
Subject: Re: [PATCHv2 1/2] super1: ignore failfast flag for setting device role
Date: Tue, 28 Mar 2017 14:01:58 -0400	[thread overview]
Message-ID: <wrfjd1d1gu09.fsf@gmail.com> (raw)
In-Reply-To: <1490003517-4216-2-git-send-email-gi-oh.kim@profitbricks.com> (Gioh Kim's message of "Mon, 20 Mar 2017 10:51:56 +0100")

Gioh Kim <gi-oh.kim@profitbricks.com> writes:
> There is corner case for setting device role,
> if new device has failfast flag.
> The failfast flag should be ignored.
>
> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
> Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
> ---
>  super1.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Applied!

Ideally I would like to get rid of the hardcoded values and use the bit
defines instead, but the original code did the same, so I am going to
take it.

I am leaving out the second patch for now, per Neil's comments. If you
feel strongly about it, please conveince Neil first :)

Thanks,
Jes

  reply	other threads:[~2017-03-28 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  9:51 [PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast Gioh Kim
2017-03-20  9:51 ` [PATCHv2 1/2] super1: ignore failfast flag for setting device role Gioh Kim
2017-03-28 18:01   ` jes.sorensen [this message]
2017-03-20  9:51 ` [PATCHv2 2/2] super1: check and output faulty dev role Gioh Kim
2017-03-21 19:55   ` NeilBrown
2017-03-22 10:23     ` Jinpu Wang
2017-03-27 10:59 ` [PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast Gioh Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjd1d1gu09.fsf@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=gi-oh.kim@profitbricks.com \
    --cc=jinpu.wang@profitbricks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome