Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

[Joe Perches <joe@perches.com>]

On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
> > Checkpatch emits WARNING: Avoid multiple line dereference.
> > 
> > Trivial indentation improvement helps fix the checkpatch warning.
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
[]
> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
> >                                                            &pframe[10], 6);
> >                         }
> >                         if (pqospriv->qos_option == 1)
> > -                                       priority[0] = (u8)pxmitframe->
> > -                                                     attrib.priority;
> > +                               priority[0] = (u8)pxmitframe->attrib.priority;
> >                         r8712_secmicappend(&micdata, &priority[0], 4);
> >                         payload = pframe;
> >                         for (curfragnum = 0; curfragnum < pattrib->nr_frags;
> >                              curfragnum++) {
> >                                 payload = (u8 *)RND4((addr_t)(payload));
> > -                               payload = payload + pattrib->
> > -                                         hdrlen + pattrib->iv_len;
> > +                               payload = payload + pattrib->hdrlen +
> > +                                         pattrib->iv_len;

+= would be shorter