From: Paul Kocialkowski <contact@paulk.fr>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux PWM List <linux-pwm@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output
Date: Mon, 17 Apr 2017 17:38:46 +0200 [thread overview]
Message-ID: <1492443526.12267.4.camel@paulk.fr> (raw)
In-Reply-To: <CAMuHMdV1+caNwbuk=Kw7cRUxcp1iC=YArnQXf2mcn+qnc6+OOQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
Hi,
Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit :
> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
> > The move to a dedicated pwm_backlight_initial_power_state function in
> > commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
> > to set the enable gpio as output. This breaks specific use cases using
> > that GPIO, such as tegra124-based nyan Chromebooks where backlight
> > stopped working.
> >
> > This puts the condition back to the way it was before the move.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented
> .get_direction()"
> (https://lkml.org/lkml/2017/4/4/225) fix your issue?
This definitely solves the issue!
Since this fixes broken backlight (that, in turn, makes systems unusable),
perhaps this should be included in the next rc cycle?
Cheers!
--
Paul Kocialkowski, developer of free digital technology at the lower levels
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-17 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 10:35 Paul Kocialkowski
2017-04-16 20:55 ` Geert Uytterhoeven
2017-04-17 15:38 ` Paul Kocialkowski [this message]
2017-04-17 19:36 ` Geert Uytterhoeven
2017-04-18 8:46 ` Paul Kocialkowski
2017-04-20 9:55 ` Daniel Thompson
2017-04-20 10:16 ` Geert Uytterhoeven
2017-04-22 13:00 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492443526.12267.4.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®