From: Paul Kocialkowski <contact@paulk.fr>
To: linux-kernel@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-tegra@vger.kernel.org, Paul Kocialkowski <contact@paulk.fr>
Subject: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output
Date: Sun, 16 Apr 2017 12:35:46 +0200 [thread overview]
Message-ID: <20170416103546.3021-1-contact@paulk.fr> (raw)
The move to a dedicated pwm_backlight_initial_power_state function in
commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
to set the enable gpio as output. This breaks specific use cases using
that GPIO, such as tegra124-based nyan Chromebooks where backlight
stopped working.
This puts the condition back to the way it was before the move.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
drivers/video/backlight/pwm_bl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index d7efcb632f7d..e81b2b55be2b 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -304,7 +304,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
* early. Leave the decision of the initial backlight state for later.
*/
if (pb->enable_gpio &&
- gpiod_get_direction(pb->enable_gpio) == GPIOF_DIR_IN)
+ (gpiod_get_direction(pb->enable_gpio) == GPIOF_DIR_IN ||
+ gpiod_get_value(pb->enable_gpio) != 0))
gpiod_direction_output(pb->enable_gpio, 1);
pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
2.12.2
next reply other threads:[~2017-04-16 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 10:35 Paul Kocialkowski [this message]
2017-04-16 20:55 ` Geert Uytterhoeven
2017-04-17 15:38 ` Paul Kocialkowski
2017-04-17 19:36 ` Geert Uytterhoeven
2017-04-18 8:46 ` Paul Kocialkowski
2017-04-20 9:55 ` Daniel Thompson
2017-04-20 10:16 ` Geert Uytterhoeven
2017-04-22 13:00 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170416103546.3021-1-contact@paulk.fr \
--to=contact@paulk.fr \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®