From: Lauro Ramos Venancio <lvenanci@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: lwang@redhat.com, riel@redhat.com, Mike Galbraith <efault@gmx.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Lauro Ramos Venancio <lvenanci@redhat.com>
Subject: [PATCH 2/4] sched/topology: all instances of a sched group must use the same sched_group_capacity
Date: Thu, 20 Apr 2017 16:51:41 -0300 [thread overview]
Message-ID: <1492717903-5195-3-git-send-email-lvenanci@redhat.com> (raw)
In-Reply-To: <1492717903-5195-1-git-send-email-lvenanci@redhat.com>
Use the group balance cpu to select the same sched_group_capacity
instance for all instances of a sched group.
As the group mask is stored in the struct sched_group_capacity and the
function group_balance_cpu() cannot be used when the group mask is not
available, this patch creates a function to find the group balance cpu
when the mask is not available.
Signed-off-by: Lauro Ramos Venancio <lvenanci@redhat.com>
---
kernel/sched/topology.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index f8b53b3..55bbaf7 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -529,6 +529,27 @@ int group_balance_cpu(struct sched_group *sg)
return cpumask_first_and(sched_group_cpus(sg), sched_group_mask(sg));
}
+/*
+ * Find the group balance cpu when the group mask is not available yet.
+ */
+static int find_group_balance_cpu(struct sched_domain *sd,
+ struct sched_group *sg)
+{
+ const struct cpumask *sg_span = sched_group_cpus(sg);
+ struct sd_data *sdd = sd->private;
+ struct sched_domain *sibling;
+ int i;
+
+ for_each_cpu(i, sg_span) {
+ sibling = *per_cpu_ptr(sdd->sd, i);
+ if (cpumask_test_cpu(i, sched_domain_span(sibling)))
+ return i;
+ }
+
+ WARN(1, "group balance cpu not found.");
+ return 0;
+}
+
static struct sched_group *
build_group_from_child_sched_domain(struct sched_domain *sd, int cpu)
{
@@ -551,10 +572,11 @@ int group_balance_cpu(struct sched_group *sg)
}
static void init_overlap_sched_group(struct sched_domain *sd,
- struct sched_group *sg, int cpu)
+ struct sched_group *sg)
{
struct sd_data *sdd = sd->private;
struct cpumask *sg_span;
+ int cpu = find_group_balance_cpu(sd, sg);
sg->sgc = *per_cpu_ptr(sdd->sgc, cpu);
if (atomic_inc_return(&sg->sgc->ref) == 1)
@@ -601,7 +623,7 @@ static void init_overlap_sched_group(struct sched_domain *sd,
sg_span = sched_group_cpus(sg);
cpumask_or(covered, covered, sg_span);
- init_overlap_sched_group(sd, sg, i);
+ init_overlap_sched_group(sd, sg);
if (!first)
first = sg;
--
1.8.3.1
next prev parent reply other threads:[~2017-04-20 19:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 19:51 [PATCH 0/4] sched/topology: fix overlap group capacity and balance cpu Lauro Ramos Venancio
2017-04-20 19:51 ` [PATCH 1/4] sched/topology: optimize build_group_mask() Lauro Ramos Venancio
2017-05-15 9:06 ` [tip:sched/core] sched/topology: Optimize build_group_mask() tip-bot for Lauro Ramos Venancio
2017-04-20 19:51 ` Lauro Ramos Venancio [this message]
2017-04-20 19:51 ` [PATCH 3/4] sched/topology: move comment about asymmetric node setups Lauro Ramos Venancio
2017-04-21 16:31 ` Peter Zijlstra
2017-05-15 9:06 ` [tip:sched/core] sched/topology: Move " tip-bot for Lauro Ramos Venancio
2017-04-20 19:51 ` [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Lauro Ramos Venancio
2017-04-24 13:03 ` Peter Zijlstra
2017-04-24 14:19 ` Peter Zijlstra
2017-04-24 14:27 ` Peter Zijlstra
2017-04-24 15:19 ` Lauro Venancio
2017-04-24 22:19 ` Peter Zijlstra
2017-04-24 15:11 ` Lauro Venancio
2017-04-24 22:15 ` Peter Zijlstra
2017-04-25 12:17 ` Peter Zijlstra
2017-04-25 14:33 ` Lauro Venancio
2017-04-25 15:12 ` Peter Zijlstra
2017-04-25 15:22 ` Peter Zijlstra
2017-04-25 15:27 ` Peter Zijlstra
2017-04-25 15:39 ` Peter Zijlstra
2017-04-25 15:52 ` Peter Zijlstra
2017-04-25 15:56 ` Lauro Venancio
2017-04-25 16:26 ` Peter Zijlstra
2017-04-26 16:31 ` [PATCH 0/4] sched/topology: fix overlap group capacity and balance cpu Peter Zijlstra
2017-04-26 17:59 ` Lauro Venancio
2017-04-26 22:43 ` Peter Zijlstra
2017-04-28 10:33 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492717903-5195-3-git-send-email-lvenanci@redhat.com \
--to=lvenanci@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lwang@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®