* [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed
@ 2017-04-27 2:55 Taeung Song
2019-01-16 3:39 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Taeung Song @ 2017-04-27 2:55 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-kernel
Even though PyRun_String() failed,
just 0 will be returned but we need to return -1
that means error status, so fix it.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
plugin_python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugin_python.c b/plugin_python.c
index 2997679..c283ed7 100644
--- a/plugin_python.c
+++ b/plugin_python.c
@@ -55,7 +55,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
free(load);
- return 0;
+ return res ? 0 : -1;
}
int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed
2017-04-27 2:55 [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed Taeung Song
@ 2019-01-16 3:39 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2019-01-16 3:39 UTC (permalink / raw)
To: Taeung Song; +Cc: linux-kernel, linux-trace-devel
On Thu, 27 Apr 2017 11:55:58 +0900
Taeung Song <treeze.taeung@gmail.com> wrote:
> Even though PyRun_String() failed,
> just 0 will be returned but we need to return -1
> that means error status, so fix it.
Ug, I just noticed this patch floating in the flood of my INBOX.
I just applied it, and will be pushing it out soon.
Thanks, and I'm really sorry for not seeing it.
-- Steve
>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> plugin_python.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugin_python.c b/plugin_python.c
> index 2997679..c283ed7 100644
> --- a/plugin_python.c
> +++ b/plugin_python.c
> @@ -55,7 +55,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
>
> free(load);
>
> - return 0;
> + return res ? 0 : -1;
> }
>
> int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 2:55 [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed Taeung Song
2019-01-16 3:39 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®