* [PATCH] Enabled pstore write for powerpc
@ 2017-04-27 11:33 Ankit Kumar
2017-04-27 20:21 ` Anton Blanchard
2017-04-27 21:38 ` Kees Cook
0 siblings, 2 replies; 4+ messages in thread
From: Ankit Kumar @ 2017-04-27 11:33 UTC (permalink / raw)
To: keescook, anton, ccross, tony.luck, xinhui.pan
Cc: benh, paulus, mpe, andrew.donnellan, dja, geliangtang,
linuxppc-dev, linux-kernel, mahesh, Ankit Kumar
After commit c950fd6f201a kernel registers pstore write based on flag set.
Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
powerpc architecture. On panic, kernel doesn't write message to
/fs/pstore/dmesg*(Entry doesn't gets created at all).
This patch enables pstore write for powerpc architecture by setting
PSTORE_FLAGS_DMESG flag.
Fixes:c950fd6f201a pstore: Split pstore fragile flags
Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
---
arch/powerpc/kernel/nvram_64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
index d5e2b83..021db31 100644
--- a/arch/powerpc/kernel/nvram_64.c
+++ b/arch/powerpc/kernel/nvram_64.c
@@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
static struct pstore_info nvram_pstore_info = {
.owner = THIS_MODULE,
.name = "nvram",
+ .flags = PSTORE_FLAGS_DMESG,
.open = nvram_pstore_open,
.read = nvram_pstore_read,
.write = nvram_pstore_write,
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enabled pstore write for powerpc
2017-04-27 11:33 [PATCH] Enabled pstore write for powerpc Ankit Kumar
@ 2017-04-27 20:21 ` Anton Blanchard
2017-04-27 21:38 ` Kees Cook
1 sibling, 0 replies; 4+ messages in thread
From: Anton Blanchard @ 2017-04-27 20:21 UTC (permalink / raw)
To: Ankit Kumar
Cc: keescook, anton, ccross, tony.luck, xinhui.pan, linux-kernel,
mahesh, geliangtang, paulus, andrew.donnellan, linuxppc-dev, dja
Hi Ankit,
> After commit c950fd6f201a kernel registers pstore write based on flag
> set. Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG)
> is not set for powerpc architecture. On panic, kernel doesn't write
> message to /fs/pstore/dmesg*(Entry doesn't gets created at all).
>
> This patch enables pstore write for powerpc architecture by setting
> PSTORE_FLAGS_DMESG flag.
>
> Fixes:c950fd6f201a pstore: Split pstore fragile flags
Ouch! We've used pstore to shoot customer bugs, so we should also mark
this for stable. Looks like 4.9 onwards?
Anton
> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
> ---
>
> arch/powerpc/kernel/nvram_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/nvram_64.c
> b/arch/powerpc/kernel/nvram_64.c index d5e2b83..021db31 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum
> pstore_type_id *type, static struct pstore_info nvram_pstore_info = {
> .owner = THIS_MODULE,
> .name = "nvram",
> + .flags = PSTORE_FLAGS_DMESG,
> .open = nvram_pstore_open,
> .read = nvram_pstore_read,
> .write = nvram_pstore_write,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enabled pstore write for powerpc
2017-04-27 11:33 [PATCH] Enabled pstore write for powerpc Ankit Kumar
2017-04-27 20:21 ` Anton Blanchard
@ 2017-04-27 21:38 ` Kees Cook
2017-04-28 2:57 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Kees Cook @ 2017-04-27 21:38 UTC (permalink / raw)
To: Ankit Kumar
Cc: Anton Vorontsov, Colin Cross, Tony Luck, Pan Xinhui, benh,
Paul Mackerras, Michael Ellerman, Andrew Donnellan,
Daniel Axtens, Geliang Tang, linuxppc-dev, LKML, mahesh
On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar <ankit@linux.vnet.ibm.com> wrote:
> After commit c950fd6f201a kernel registers pstore write based on flag set.
> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
> powerpc architecture. On panic, kernel doesn't write message to
> /fs/pstore/dmesg*(Entry doesn't gets created at all).
>
> This patch enables pstore write for powerpc architecture by setting
> PSTORE_FLAGS_DMESG flag.
>
> Fixes:c950fd6f201a pstore: Split pstore fragile flags
> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
Argh, thanks! I thought I'd caught all of these. I'll include this for -stable.
-Kees
> ---
>
> arch/powerpc/kernel/nvram_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
> index d5e2b83..021db31 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
> static struct pstore_info nvram_pstore_info = {
> .owner = THIS_MODULE,
> .name = "nvram",
> + .flags = PSTORE_FLAGS_DMESG,
> .open = nvram_pstore_open,
> .read = nvram_pstore_read,
> .write = nvram_pstore_write,
> --
> 2.7.4
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enabled pstore write for powerpc
2017-04-27 21:38 ` Kees Cook
@ 2017-04-28 2:57 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-04-28 2:57 UTC (permalink / raw)
To: Kees Cook, Ankit Kumar
Cc: Anton Vorontsov, Colin Cross, Tony Luck, Pan Xinhui, benh,
Paul Mackerras, Andrew Donnellan, Daniel Axtens, Geliang Tang,
linuxppc-dev, LKML, mahesh
Kees Cook <keescook@chromium.org> writes:
> On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar <ankit@linux.vnet.ibm.com> wrote:
>> After commit c950fd6f201a kernel registers pstore write based on flag set.
>> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
>> powerpc architecture. On panic, kernel doesn't write message to
>> /fs/pstore/dmesg*(Entry doesn't gets created at all).
>>
>> This patch enables pstore write for powerpc architecture by setting
>> PSTORE_FLAGS_DMESG flag.
>>
>> Fixes:c950fd6f201a pstore: Split pstore fragile flags
>> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
>
> Argh, thanks! I thought I'd caught all of these. I'll include this for -stable.
I see you've picked it up, thanks.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-28 2:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 11:33 [PATCH] Enabled pstore write for powerpc Ankit Kumar
2017-04-27 20:21 ` Anton Blanchard
2017-04-27 21:38 ` Kees Cook
2017-04-28 2:57 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome