* [V1] staging : media : fixed macro expansion error
@ 2017-05-05 12:50 Surender Polsani
2017-05-05 13:03 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Surender Polsani @ 2017-05-05 12:50 UTC (permalink / raw)
To: gregkh; +Cc: linux-media, devel, linux-kernel, Surender Polsani
enclosing complex macro expansion with parentheses is
meaningfull according kernel coding style
Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 375c617..b9cafbb 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2001,8 +2001,8 @@ static irqreturn_t bcm2048_handler(int irq, void *dev)
}
#define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \
-property_write(prop, signal size, mask, check) \
-property_read(prop, size, mask)
+(property_write(prop, signal size, mask, check) \
+property_read(prop, size, mask))
#define property_str_read(prop, size) \
static ssize_t bcm2048_##prop##_read(struct device *dev, \
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [V1] staging : media : fixed macro expansion error
2017-05-05 12:50 [V1] staging : media : fixed macro expansion error Surender Polsani
@ 2017-05-05 13:03 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-05-05 13:03 UTC (permalink / raw)
To: Surender Polsani; +Cc: gregkh, devel, linux-kernel, linux-media
> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \
> -property_write(prop, signal size, mask, check) \
> -property_read(prop, size, mask)
> +(property_write(prop, signal size, mask, check) \
> +property_read(prop, size, mask))
breaks the build.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-05 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-05 12:50 [V1] staging : media : fixed macro expansion error Surender Polsani
2017-05-05 13:03 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®