mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Matej Dujava <mdujava@kocurkovo.cz>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/cpu.c: fix many errors related to style.
Date: Sat, 06 May 2017 08:27:53 -0700	[thread overview]
Message-ID: <1494084473.31950.26.camel@perches.com> (raw)
In-Reply-To: <20170506150958.GA17249@ns1.kocurkovo.cz>

On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote:
> This patch fixes the checkpatch.pl warning:
> ERROR: spaces required around that '=' (ctx:VxW)
> WARNING: Block comments use a trailing */ on a separate line
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Blank lines aren't necessary after an open brace '{'
[]
> diff --git a/kernel/cpu.c b/kernel/cpu.c

Please don't modify core kernel files just to shut-up checkpatch
messages.  If you are doing rework, it makes some sense, otherwise
it doesn't add much value.

> -	/* Entry state on starting. Interrupts enabled from here on. Transient
> -	 * state for synchronsization */
> +	/*
> +	 * Entry state on starting. Interrupts enabled from here on. Transient
> +	 * state for synchronsization

Fixing typos would be nicer than merely reformatting comments.

  reply	other threads:[~2017-05-06 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 15:09 Matej Dujava
2017-05-06 15:27 ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-01-29 20:19 [PATCH] kernel/cpu.c: Fix " Michael Rodriguez
2011-01-29 21:32 ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494084473.31950.26.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdujava@kocurkovo.cz \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome