* [PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h
2017-05-06 22:46 [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
@ 2017-05-06 22:46 ` Matthew Giassa
2017-05-06 22:46 ` [PATCH 2/3] staging: ccree: resolve columns over 80 chars " Matthew Giassa
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Giassa @ 2017-05-06 22:46 UTC (permalink / raw)
To: gregkh; +Cc: matthew, gilad, devel, linux-kernel
Removing trailing newlines reported by checkpatch.pl. ie:
ERROR: trailing whitespace (lines 3, 7, 12).
Warnings no longer present after change.
Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_hal.h b/drivers/staging/ccree/cc_hal.h
index 75a0ce3..dd1c66d 100644
--- a/drivers/staging/ccree/cc_hal.h
+++ b/drivers/staging/ccree/cc_hal.h
@@ -1,15 +1,15 @@
/*
* Copyright (C) 2012-2017 ARM Limited or its affiliates.
- *
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
- *
+ *
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
+ *
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] staging: ccree: resolve columns over 80 chars in cc_hal.h
2017-05-06 22:46 [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
2017-05-06 22:46 ` [PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h Matthew Giassa
@ 2017-05-06 22:46 ` Matthew Giassa
2017-05-06 22:46 ` [PATCH 3/3] staging: ccree: resolve possible macro issue " Matthew Giassa
2017-05-06 22:56 ` [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Giassa @ 2017-05-06 22:46 UTC (permalink / raw)
To: gregkh; +Cc: matthew, gilad, devel, linux-kernel
Modified comment to resolve 80+ characters warning from checkpatch. ie:
WARNING: line over 80 characters
Warnings no longer present after change.
Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hal.h b/drivers/staging/ccree/cc_hal.h
index dd1c66d..9b54c80 100644
--- a/drivers/staging/ccree/cc_hal.h
+++ b/drivers/staging/ccree/cc_hal.h
@@ -14,7 +14,9 @@
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
-/* pseudo cc_hal.h for cc7x_perf_test_driver (to be able to include code from CC drivers) */
+/* pseudo cc_hal.h for cc7x_perf_test_driver (to be able to include code from
+ * CC drivers).
+ */
#ifndef __CC_HAL_H__
#define __CC_HAL_H__
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] staging: ccree: resolve possible macro issue in cc_hal.h
2017-05-06 22:46 [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
2017-05-06 22:46 ` [PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h Matthew Giassa
2017-05-06 22:46 ` [PATCH 2/3] staging: ccree: resolve columns over 80 chars " Matthew Giassa
@ 2017-05-06 22:46 ` Matthew Giassa
2017-05-06 22:56 ` [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Giassa @ 2017-05-06 22:46 UTC (permalink / raw)
To: gregkh; +Cc: matthew, gilad, devel, linux-kernel
Wrapping "offset" in macro definition to resolve checkpatch issue, ie:
CHECK: Macro argument 'offset' may be better as '(offset)' to avoid
precedence issues
Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/cc_hal.h b/drivers/staging/ccree/cc_hal.h
index 9b54c80..eecc866 100644
--- a/drivers/staging/ccree/cc_hal.h
+++ b/drivers/staging/ccree/cc_hal.h
@@ -26,7 +26,8 @@
#define READ_REGISTER(_addr) ioread32((_addr))
#define WRITE_REGISTER(_addr, _data) iowrite32((_data), (_addr))
-#define CC_HAL_WRITE_REGISTER(offset, val) WRITE_REGISTER(cc_base + offset, val)
-#define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + offset)
+#define CC_HAL_WRITE_REGISTER(offset, val) \
+ WRITE_REGISTER(cc_base + (offset), val)
+#define CC_HAL_READ_REGISTER(offset) READ_REGISTER(cc_base + (offset))
#endif
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.
2017-05-06 22:46 [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
` (2 preceding siblings ...)
2017-05-06 22:46 ` [PATCH 3/3] staging: ccree: resolve possible macro issue " Matthew Giassa
@ 2017-05-06 22:56 ` Matthew Giassa
2017-05-10 7:17 ` Gilad Ben-Yossef
3 siblings, 1 reply; 6+ messages in thread
From: Matthew Giassa @ 2017-05-06 22:56 UTC (permalink / raw)
To: gregkh; +Cc: gilad, devel, linux-kernel
* Matthew Giassa <matthew@giassa.net> [2017-05-06 15:46:53 -0700]:
>Included is a set of small fixes to resolve all outstanding checkpatch
>warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic
>(training whitespace and 80+ character comment), and the other is
>functional (macro argument previously not wrapped in parentheses).
>
Forgot to mention, applies cleanly against staging-next
(3ef2bc099d1cce09e2844467e2ced98e1a44609d).
--
-Matthew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.
2017-05-06 22:56 ` [PATCH 0/3] staging: ccree: resolve checkpatch issues Matthew Giassa
@ 2017-05-10 7:17 ` Gilad Ben-Yossef
0 siblings, 0 replies; 6+ messages in thread
From: Gilad Ben-Yossef @ 2017-05-10 7:17 UTC (permalink / raw)
To: Matthew Giassa; +Cc: Greg Kroah-Hartman, devel, Linux kernel mailing list
On Sun, May 7, 2017 at 1:56 AM, Matthew Giassa <matthew@giassa.net> wrote:
> * Matthew Giassa <matthew@giassa.net> [2017-05-06 15:46:53 -0700]:
>
>
>> Included is a set of small fixes to resolve all outstanding checkpatch
>> warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic
>> (training whitespace and 80+ character comment), and the other is
>> functional (macro argument previously not wrapped in parentheses).
>>
>
> Forgot to mention, applies cleanly against staging-next
> (3ef2bc099d1cce09e2844467e2ced98e1a44609d).
>
For 2-3:
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
I saw GregKH already carries them in the staging-testing
About 1 - I never saw it and there isn't one in staging-testing either
so I'm assuming
I'm not the only only one that missed it. Can you please resend?
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
^ permalink raw reply [flat|nested] 6+ messages in thread