* [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API
@ 2017-05-12 0:51 Byungchul Park
0 siblings, 0 replies; 3+ messages in thread
From: Byungchul Park @ 2017-05-12 0:51 UTC (permalink / raw)
To: viro; +Cc: linux-kernel, kernel-team
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
fs/namespace.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index b5b1259..5cb2229 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1082,12 +1082,10 @@ static void __cleanup_mnt(struct rcu_head *head)
static void delayed_mntput(struct work_struct *unused)
{
struct llist_node *node = llist_del_all(&delayed_mntput_list);
- struct llist_node *next;
+ struct mount *m, *t;
- for (; node; node = next) {
- next = llist_next(node);
- cleanup_mnt(llist_entry(node, struct mount, mnt_llist));
- }
+ llist_for_each_entry_safe(m, t, node, mnt_llist)
+ cleanup_mnt(m);
}
static DECLARE_DELAYED_WORK(delayed_mntput_work, delayed_mntput);
@@ -1615,7 +1613,7 @@ void __detach_mounts(struct dentry *dentry)
namespace_unlock();
}
-/*
+/*
* Is the caller allowed to modify his namespace?
*/
static inline bool may_mount(void)
@@ -2159,7 +2157,7 @@ static int do_loopback(struct path *path, const char *old_name,
err = -EINVAL;
if (mnt_ns_loop(old_path.dentry))
- goto out;
+ goto out;
mp = lock_mount(path);
err = PTR_ERR(mp);
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [RESEND PATCH] Don't reinvent the wheel but use existing llilst API
@ 2017-07-10 2:37 Byungchul Park
2017-07-10 2:37 ` [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API Byungchul Park
0 siblings, 1 reply; 3+ messages in thread
From: Byungchul Park @ 2017-07-10 2:37 UTC (permalink / raw)
To: torvalds; +Cc: axboe, viro, linux-kernel, kernel-team
Hello Linus,
Even though llist APIs exist, serveral code in kernel reinvent the
implementation again and again. Since I think it's *worth* making it use
existing APIs, I submit patches doing it.
Actually I've submitted them to maintainers and commiters about 10 times
for 4 months, but they seem to be too busy to review or take them. Of
course you might be even busier, but it would be appriciated if you do
that instead. It might not take your time much since they are simple.
Patches worked on scheduler, irq_work, vhost/scsi and raid are already
taken by proper maintainers. For now, only ones for bcache, mm, fput and
namespace remain.
Thank you,
Byungchul
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API
2017-07-10 2:37 [RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park
@ 2017-07-10 2:37 ` Byungchul Park
0 siblings, 0 replies; 3+ messages in thread
From: Byungchul Park @ 2017-07-10 2:37 UTC (permalink / raw)
To: torvalds; +Cc: axboe, viro, linux-kernel, kernel-team
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
fs/namespace.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index b5b1259..5cb2229 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1082,12 +1082,10 @@ static void __cleanup_mnt(struct rcu_head *head)
static void delayed_mntput(struct work_struct *unused)
{
struct llist_node *node = llist_del_all(&delayed_mntput_list);
- struct llist_node *next;
+ struct mount *m, *t;
- for (; node; node = next) {
- next = llist_next(node);
- cleanup_mnt(llist_entry(node, struct mount, mnt_llist));
- }
+ llist_for_each_entry_safe(m, t, node, mnt_llist)
+ cleanup_mnt(m);
}
static DECLARE_DELAYED_WORK(delayed_mntput_work, delayed_mntput);
@@ -1615,7 +1613,7 @@ void __detach_mounts(struct dentry *dentry)
namespace_unlock();
}
-/*
+/*
* Is the caller allowed to modify his namespace?
*/
static inline bool may_mount(void)
@@ -2159,7 +2157,7 @@ static int do_loopback(struct path *path, const char *old_name,
err = -EINVAL;
if (mnt_ns_loop(old_path.dentry))
- goto out;
+ goto out;
mp = lock_mount(path);
err = PTR_ERR(mp);
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API
@ 2017-08-07 8:44 Byungchul Park
0 siblings, 0 replies; 3+ messages in thread
From: Byungchul Park @ 2017-08-07 8:44 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, kernel-team
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
fs/namespace.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index b5b1259..5cb2229 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1082,12 +1082,10 @@ static void __cleanup_mnt(struct rcu_head *head)
static void delayed_mntput(struct work_struct *unused)
{
struct llist_node *node = llist_del_all(&delayed_mntput_list);
- struct llist_node *next;
+ struct mount *m, *t;
- for (; node; node = next) {
- next = llist_next(node);
- cleanup_mnt(llist_entry(node, struct mount, mnt_llist));
- }
+ llist_for_each_entry_safe(m, t, node, mnt_llist)
+ cleanup_mnt(m);
}
static DECLARE_DELAYED_WORK(delayed_mntput_work, delayed_mntput);
@@ -1615,7 +1613,7 @@ void __detach_mounts(struct dentry *dentry)
namespace_unlock();
}
-/*
+/*
* Is the caller allowed to modify his namespace?
*/
static inline bool may_mount(void)
@@ -2159,7 +2157,7 @@ static int do_loopback(struct path *path, const char *old_name,
err = -EINVAL;
if (mnt_ns_loop(old_path.dentry))
- goto out;
+ goto out;
mp = lock_mount(path);
err = PTR_ERR(mp);
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-07 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 0:51 [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-07-10 2:37 [RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park
2017-07-10 2:37 ` [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-08-07 8:44 Byungchul Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®