mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
@ 2017-05-17 20:41 Thomas Meyer
  2017-05-21 21:30 ` [uml-devel] " Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2017-05-17 20:41 UTC (permalink / raw)
  To: Linux Kernel Mailing List, user-mode-linux-devel

For some reasons I don't know users-offsets.s get's build before the
gcc-plugins itself.
This patch fixes the problem by not using the gcc-plugins for building
user-offsets.s

make order example:
$ make ARCH=um
  CHK     include/generated/uapi/linux/version.h
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/bin2c
  HOSTCC  scripts/unifdef
  CC      arch/x86/um/user-offsets.s
  CHK     include/generated/user_constants.h
  CHK     include/config/kernel.release
  CHK     include/generated/utsrelease.h
  HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
  HOSTLLD -shared scripts/gcc-plugins/latent_entropy_plugin.so
  HOSTCXX -fPIC scripts/gcc-plugins/structleak_plugin.o
  HOSTLLD -shared scripts/gcc-plugins/structleak_plugin.so

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
 arch/x86/um/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
index 46cbbfe..d67c78a 100644
--- a/arch/x86/um/Makefile
+++ b/arch/x86/um/Makefile
@@ -36,7 +36,7 @@ subarch-$(CONFIG_MODULES) += ../kernel/module.o
 USER_OBJS := bugs_$(BITS).o ptrace_user.o fault.o
 
 extra-y += user-offsets.s
-$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) \
+$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(filter-out $(GCC_PLUGINS_CFLAGS), $(USER_CFLAGS) ) \
 	-Iarch/x86/include/generated
 
 UNPROFILE_OBJS := stub_segv.o

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
  2017-05-17 20:41 [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins Thomas Meyer
@ 2017-05-21 21:30 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2017-05-21 21:30 UTC (permalink / raw)
  To: Thomas Meyer; +Cc: Linux Kernel Mailing List, user-mode-linux-devel

Thomas,

On Wed, May 17, 2017 at 10:41 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> For some reasons I don't know users-offsets.s get's build before the
> gcc-plugins itself.

Can you please figure? I want to make sure that we really fix the root cause
and not just papering over a symptom.

-- 
Thanks,
//richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-21 21:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 20:41 [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins Thomas Meyer
2017-05-21 21:30 ` [uml-devel] " Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®