mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dong Aisheng <aisheng.dong@nxp.com>
To: <linux-clk@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <aisheng.dong@nxp.com>,
	<kernel@pengutronix.de>, <broonie@kernel.org>,
	<yibin.gong@nxp.com>, <rjw@rjwysocki.net>,
	<viresh.kumar@linaro.org>, <mturquette@baylibre.com>,
	<sboyd@codeaurora.org>, <shawnguo@kernel.org>,
	<fabio.estevam@nxp.com>, <anson.huang@nxp.com>,
	<ping.bai@nxp.com>, <leonard.crestez@nxp.com>,
	<octavian.purdila@nxp.com>, <linux@armlinux.org.uk>,
	<geert@linux-m68k.org>, <f.fainelli@gmail.com>,
	<dongas86@gmail.com>
Subject: [PATCH V3 0/3] clk: introduce clk_bulk_get accessories
Date: Fri, 19 May 2017 21:49:03 +0800	[thread overview]
Message-ID: <1495201746-31841-1-git-send-email-aisheng.dong@nxp.com> (raw)

These helper function allows drivers to get several clk consumers in
one operation.  If any of the clk cannot be acquired then any clks
that were got will be put before returning to the caller.

The idea firstly came out when i wanted to clean up and optimize
imx6q-cpufreq driver which needs to handle a lot of clocks as it
becomes a bit mess.

e.g. drivers/cpufreq/imx6q-cpufreq.c

You will see we need get 7 clocks during driver probe.
(Add there will be more, e.g. pll1, pll1_bypass, pll1_bypass_src,
in the future when adding busfreq support).

static int imx6q_cpufreq_probe(struct platform_device *pdev)
{
....
	arm_clk = clk_get(cpu_dev, "arm");
	pll1_sys_clk = clk_get(cpu_dev, "pll1_sys");
	pll1_sw_clk = clk_get(cpu_dev, "pll1_sw");
	step_clk = clk_get(cpu_dev, "step");
	pll2_pfd2_396m_clk = clk_get(cpu_dev, "pll2_pfd2_396m");
	if (IS_ERR(arm_clk) || IS_ERR(pll1_sys_clk) || IS_ERR(pll1_sw_clk) ||
	    IS_ERR(step_clk) || IS_ERR(pll2_pfd2_396m_clk)) {
		dev_err(cpu_dev, "failed to get clocks\n");
		ret = -ENOENT;
		goto put_clk;
	}

	if (of_machine_is_compatible("fsl,imx6ul")) {
		pll2_bus_clk = clk_get(cpu_dev, "pll2_bus");
		secondary_sel_clk = clk_get(cpu_dev, "secondary_sel");
		if (IS_ERR(pll2_bus_clk) || IS_ERR(secondary_sel_clk)) {
			dev_err(cpu_dev, "failed to get clocks specific to imx6ul\n");
			ret = -ENOENT;
			goto put_clk;
		}
	}
....
put_clk: 
        if (!IS_ERR(arm_clk))
                clk_put(arm_clk);
        if (!IS_ERR(pll1_sys_clk))
                clk_put(pll1_sys_clk);
	...........
}

Together with the err path handling for each clocks, it does make
things a bit ugly.

Since we already have regulator_bulk_get accessories, i thought we
probably could introduce clk_bulk_get as well to handle such case to
ease the driver owners' life. 

Besides IMX cpufreq driver, there is also some similar cases
in kernel which could befinit from this api as well.
e.g.
drivers/cpufreq/tegra124-cpufreq.c
drivers/cpufreq/s3c2412-cpufreq.c
sound/soc/samsung/smdk_spdif.c
arch/arm/mach-omap1/serial.c
...

And actually, if we handle clocks more than 3, then it might be
worthy to try, which there is quite many manay in kernel and
that probably could save a lot codes.

Comments are welcome and appreciated!

Tested on MX6Q SabreSD board with CPUfreq stress.
Also ran IA64 and m68k compiling test:
make.cross ARCH=m68k 
make.cross ARCH=ia64

ChangeLog:
v2->v3:
 Only Patch 1 changed.
 * release resource in reversed order in case an error according to
   Geert Uytterhoeven's suggestion

v1->v2:
 * Most significant change is introducing clk-bulk.c to centrally
   handle bulk_clks and fix !CONFIG_CLKDEV_LOOKUP platforms build break.
   Other are comments fix, adding const annotation and etc.
   Refer to individual patches for details.

[v1] https://lkml.org/lkml/2017/4/11/335
[v2] https://lkml.org/lkml/2017/5/8/276

Dong Aisheng (3):
  clk: add clk_bulk_get accessories
  clk: add managed version of clk_bulk_get
  cpufreq: imx6q: refine clk operations

 drivers/clk/Makefile            |   2 +-
 drivers/clk/clk-bulk.c          | 157 ++++++++++++++++++++++++++++++++++++++++
 drivers/clk/clk-devres.c        |  36 +++++++++
 drivers/cpufreq/imx6q-cpufreq.c | 119 ++++++++++++++----------------
 include/linux/clk.h             | 132 +++++++++++++++++++++++++++++++++
 5 files changed, 379 insertions(+), 67 deletions(-)
 create mode 100644 drivers/clk/clk-bulk.c

-- 
2.7.4

             reply	other threads:[~2017-05-19 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 13:49 Dong Aisheng [this message]
2017-05-19 13:49 ` [PATCH V3 1/3] clk: add " Dong Aisheng
2017-06-02 22:39   ` Stephen Boyd
2017-05-19 13:49 ` [PATCH V3 2/3] clk: add managed version of clk_bulk_get Dong Aisheng
2017-06-02 22:39   ` Stephen Boyd
2017-05-19 13:49 ` [PATCH V3 3/3] cpufreq: imx6q: refine clk operations Dong Aisheng
2017-06-02 22:40 ` [PATCH V3 0/3] clk: introduce clk_bulk_get accessories Stephen Boyd
2017-06-13  9:18   ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495201746-31841-1-git-send-email-aisheng.dong@nxp.com \
    --to=aisheng.dong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=broonie@kernel.org \
    --cc=dongas86@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=geert@linux-m68k.org \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=octavian.purdila@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=shawnguo@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®