From: Michael Turquette <mturquette@baylibre.com>
To: Anup Patel <anup.patel@broadcom.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Boyd" <sboyd@codeaurora.org>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Jon Mason" <jonmason@broadcom.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Oza Pawandeep" <oza.oza@broadcom.com>,
"Srinath Mannam" <srinath.mannam@broadcom.com>,
"Pramod Kumar" <pramod.kumar@broadcom.com>,
"Sandeep Tripathy" <sandeep.tripathy@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v4 03/11] clk: bcm: Add clocks for Stingray SOC
Date: Thu, 25 May 2017 14:33:08 -0700 [thread overview]
Message-ID: <149574798866.52617.17864487502272102012@resonance> (raw)
In-Reply-To: <1495454307-23464-4-git-send-email-anup.patel@broadcom.com>
Hello Anup,
Quoting Anup Patel (2017-05-22 04:58:19)
> +#include <linux/kernel.h>
> +#include <linux/err.h>
> +#include <linux/clk-provider.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
Are all of those headers really needed?
> +CLK_OF_DECLARE(sr_genpll3_clk, "brcm,sr-genpll3",
> + sr_genpll3_clk_init);
Why use CLK_OF_DECLARE here? You've got a proper platform driver here.
Regards,
Mike
next prev parent reply other threads:[~2017-05-25 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:58 [PATCH v4 00/11] Broadcom Stingray SOC Initial Support Anup Patel
2017-05-22 11:58 ` [PATCH v4 01/11] dt-bindings: bcm: Add Broadcom Stingray bindings document Anup Patel
2017-05-22 11:58 ` [PATCH v4 02/11] dt-bindings: clk: Extend binding doc for Stingray SOC Anup Patel
2017-05-22 11:58 ` [PATCH v4 03/11] clk: bcm: Add clocks " Anup Patel
2017-05-25 21:33 ` Michael Turquette [this message]
2017-05-26 9:08 ` Anup Patel
2017-05-22 11:58 ` [PATCH v4 04/11] arm64: dts: Initial DTS files for Broadcom " Anup Patel
2017-05-22 11:58 ` [PATCH v4 05/11] arm64: dts: Add clock DT nodes for " Anup Patel
2017-05-22 11:58 ` [PATCH v4 06/11] arm64: dts: Add NAND " Anup Patel
2017-05-22 11:58 ` [PATCH v4 07/11] arm64: dts: Add pinctrl " Anup Patel
2017-05-22 11:58 ` [PATCH v4 08/11] arm64: dts: Add GPIO " Anup Patel
2017-05-22 11:58 ` [PATCH v4 09/11] arm64: dts: Add I2C DT nodes for Stingray SoC Anup Patel
2017-05-22 11:58 ` [PATCH v4 10/11] arm64: dts: Add PL022, PL330 and SP805 DT nodes for Stingray Anup Patel
2017-05-22 11:58 ` [PATCH v4 11/11] arm64: dts: Add PWM and SDHCI DT nodes for Stingray SOC Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149574798866.52617.17864487502272102012@resonance \
--to=mturquette@baylibre.com \
--cc=anup.patel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oza.oza@broadcom.com \
--cc=pramod.kumar@broadcom.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sandeep.tripathy@broadcom.com \
--cc=sboyd@codeaurora.org \
--cc=sbranden@broadcom.com \
--cc=srinath.mannam@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®