mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Aleksey Makarov <aleksey.makarov@linaro.org>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Petr Mladek <pmladek@suse.com>
Subject: [PATCH 0/3] printk/console: Simplify the logic and always have a preferred console
Date: Tue, 13 Jun 2017 14:54:01 +0200	[thread overview]
Message-ID: <1497358444-30736-1-git-send-email-pmladek@suse.com> (raw)

The regression caused by the commit cf39bf58afdaabc0b ("printk: fix
double printing with earlycon") made me to investigate the console
registration code from many angles. And it was not an easy reading.

Especially the logic around the preferred console was somehow
twisted. The first two patches try to make it more straightforward.
The good thing is that they should not change the behavior.

Another problem was inconsistency in handling a fallback for
the preferred console. This is solved by the 3rd patch.
Also it solves a bug report related to "showconsole" that
I got 2 weeks ago. This fix slightly changes the order
of non-preferred consoles. But I believe that it is behind
the border when we need to take care of backward compatibility.

Sadly, we had to revert the fix of the duplicated output. It is
not solved by this patch set. I consider this a cosmetic issue.
A proper solution would be quite complicated. It might involve
rework of the console->match() functions and allow to match
aliases without side effects. Alternative solution would be
an additional command line option that would force handling
of CON_PRINTBUFFER flag and "never", "auto", or "always"
reply the buffer for newly registered consoles. But I am
not sure if it is worth it.


Petr Mladek (3):
  printk/console: Remove superfluous setting of has_preferred state
    value
  printk/console: Clean up logic around fallback console
  printk/console: Always have a preferred console

 kernel/printk/printk.c | 48 ++++++++++++++++++++----------------------------
 1 file changed, 20 insertions(+), 28 deletions(-)

-- 
1.8.5.6

             reply	other threads:[~2017-06-13 12:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 12:54 Petr Mladek [this message]
2017-06-13 12:54 ` [PATCH 1/3] printk/console: Remove superfluous setting of has_preferred state value Petr Mladek
2017-06-14  7:41   ` Sergey Senozhatsky
2017-06-13 12:54 ` [PATCH 2/3] printk/console: Clean up logic around fallback console Petr Mladek
2017-06-14  8:38   ` Sergey Senozhatsky
2017-06-15 15:31     ` Petr Mladek
2017-06-16  2:02       ` Sergey Senozhatsky
2017-06-13 12:54 ` [PATCH 3/3] printk/console: Always have a preferred console Petr Mladek
2017-06-14  9:11   ` Sergey Senozhatsky
2017-06-15 14:54     ` Petr Mladek
2017-06-16  2:00       ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497358444-30736-1-git-send-email-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=aleksey.makarov@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sd@queasysnail.net \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®