mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Aleksey Makarov <aleksey.makarov@linaro.org>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] printk/console: Clean up logic around fallback console
Date: Fri, 16 Jun 2017 11:02:18 +0900	[thread overview]
Message-ID: <20170616020218.GC465@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170615153136.GD23337@pathway.suse.cz>

On (06/15/17 17:31), Petr Mladek wrote:
[..]
> > diff --git a/include/linux/console.h b/include/linux/console.h
> > index b8920a031a3e..a2525e0d7605 100644
> > --- a/include/linux/console.h
> > +++ b/include/linux/console.h
> > @@ -127,7 +127,7 @@ static inline int con_debug_leave(void)
> >   */
> >  
> >  #define CON_PRINTBUFFER        (1)
> > -#define CON_CONSDEV    (2) /* Last on the command line */
> > +#define CON_CONSDEV    (2)
> 
> The description is wrong. The name and the use suggest that
> it should be something like:
> 
> #define CON_CONSDEV    (2) /* Driver used by /dev/console */

that's better, indeed.

> There are some situations (bugs) where this is not true.

true.

	-ss

  reply	other threads:[~2017-06-16  2:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 12:54 [PATCH 0/3] printk/console: Simplify the logic and always have a preferred console Petr Mladek
2017-06-13 12:54 ` [PATCH 1/3] printk/console: Remove superfluous setting of has_preferred state value Petr Mladek
2017-06-14  7:41   ` Sergey Senozhatsky
2017-06-13 12:54 ` [PATCH 2/3] printk/console: Clean up logic around fallback console Petr Mladek
2017-06-14  8:38   ` Sergey Senozhatsky
2017-06-15 15:31     ` Petr Mladek
2017-06-16  2:02       ` Sergey Senozhatsky [this message]
2017-06-13 12:54 ` [PATCH 3/3] printk/console: Always have a preferred console Petr Mladek
2017-06-14  9:11   ` Sergey Senozhatsky
2017-06-15 14:54     ` Petr Mladek
2017-06-16  2:00       ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616020218.GC465@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aleksey.makarov@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sd@queasysnail.net \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®