* [PATCH] of: be consistent in form of file mode
@ 2017-06-21 19:20 frowand.list
2017-06-22 16:17 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: frowand.list @ 2017-06-21 19:20 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, linux-kernel
From: Frank Rowand <frank.rowand@sony.com>
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that pending patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 28d5f53bc631..974d51269a02 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -155,7 +155,7 @@ int __of_add_property_sysfs(struct device_node *np, struct property *pp)
sysfs_bin_attr_init(&pp->attr);
pp->attr.attr.name = safe_name(&np->kobj, pp->name);
- pp->attr.attr.mode = secure ? S_IRUSR : S_IRUGO;
+ pp->attr.attr.mode = secure ? 0400 : 0444;
pp->attr.size = secure ? 0 : pp->length;
pp->attr.read = of_node_property_read;
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] of: be consistent in form of file mode
2017-06-21 19:20 [PATCH] of: be consistent in form of file mode frowand.list
@ 2017-06-22 16:17 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2017-06-22 16:17 UTC (permalink / raw)
To: frowand.list; +Cc: devicetree, linux-kernel
On Wed, Jun 21, 2017 at 12:20:03PM -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> checkpatch whined about using S_IRUGO instead of octal equivalent
> when adding phandle sysfs code, so used octal in that pending patch.
> Change other instances of the S_* constants in the same file to
> the octal form.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-22 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 19:20 [PATCH] of: be consistent in form of file mode frowand.list
2017-06-22 16:17 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®