From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Colin King <colin.king@canonical.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const
Date: Sun, 25 Jun 2017 13:55:49 -0700 [thread overview]
Message-ID: <1498424149.26123.36.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20170613132909.28674-1-colin.king@canonical.com>
On Tue, 2017-06-13 at 14:29 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array tcmu_attrib_attrs does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'tcmu_attrib_attrs' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index afc1fd6bacaf..04fb3f720895 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1672,7 +1672,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
> }
> CONFIGFS_ATTR(tcmu_, emulate_write_cache);
>
> -struct configfs_attribute *tcmu_attrib_attrs[] = {
> +static struct configfs_attribute *tcmu_attrib_attrs[] = {
> &tcmu_attr_cmd_time_out,
> &tcmu_attr_dev_path,
> &tcmu_attr_dev_size,
Applied.
Thanks Colin.
prev parent reply other threads:[~2017-06-25 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 13:29 Colin King
2017-06-25 20:55 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498424149.26123.36.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®