* [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const
@ 2017-06-13 13:29 Colin King
2017-06-25 20:55 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-13 13:29 UTC (permalink / raw)
To: Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The array tcmu_attrib_attrs does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'tcmu_attrib_attrs' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/target/target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index afc1fd6bacaf..04fb3f720895 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1672,7 +1672,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
}
CONFIGFS_ATTR(tcmu_, emulate_write_cache);
-struct configfs_attribute *tcmu_attrib_attrs[] = {
+static struct configfs_attribute *tcmu_attrib_attrs[] = {
&tcmu_attr_cmd_time_out,
&tcmu_attr_dev_path,
&tcmu_attr_dev_size,
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const
2017-06-13 13:29 [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const Colin King
@ 2017-06-25 20:55 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2017-06-25 20:55 UTC (permalink / raw)
To: Colin King; +Cc: linux-scsi, target-devel, kernel-janitors, linux-kernel
On Tue, 2017-06-13 at 14:29 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array tcmu_attrib_attrs does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'tcmu_attrib_attrs' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index afc1fd6bacaf..04fb3f720895 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1672,7 +1672,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
> }
> CONFIGFS_ATTR(tcmu_, emulate_write_cache);
>
> -struct configfs_attribute *tcmu_attrib_attrs[] = {
> +static struct configfs_attribute *tcmu_attrib_attrs[] = {
> &tcmu_attr_cmd_time_out,
> &tcmu_attr_dev_path,
> &tcmu_attr_dev_size,
Applied.
Thanks Colin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-25 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 13:29 [PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const Colin King
2017-06-25 20:55 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®