From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
Yinghai Lu <yinghai@kernel.org>, Jiang Liu <liuj97@gmail.com>,
Toshi Kani <toshi.kani@hp.com>,
LKML <linux-kernel@vger.kernel.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Subject: [PATCH 1/2] ACPI / scan: Remove useless #ifndef from acpi_eject_store()
Date: Fri, 08 Feb 2013 01:25:08 +0100 [thread overview]
Message-ID: <1498466.XkrmNzKycX@vostro.rjw.lan> (raw)
In-Reply-To: <1468930.acVuhKfKYv@vostro.rjw.lan>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Since the FORCE_EJECT symbol is never defined, the
#ifndef FORCE_EJECT in acpi_eject_store() is always true, so drop it.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/scan.c | 2 --
1 file changed, 2 deletions(-)
Index: test/drivers/acpi/scan.c
===================================================================
--- test.orig/drivers/acpi/scan.c
+++ test/drivers/acpi/scan.c
@@ -202,12 +202,10 @@ acpi_eject_store(struct device *d, struc
if ((!count) || (buf[0] != '1')) {
return -EINVAL;
}
-#ifndef FORCE_EJECT
if (!acpi_device->driver && !acpi_device->handler) {
ret = -ENODEV;
goto err;
}
-#endif
status = acpi_get_type(acpi_device->handle, &type);
if (ACPI_FAILURE(status) || (!acpi_device->flags.ejectable)) {
ret = -ENODEV;
next prev parent reply other threads:[~2013-02-08 0:21 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 0:26 [RFC] ACPI scan handlers Rafael J. Wysocki
2013-01-25 16:52 ` Toshi Kani
2013-01-25 22:11 ` Rafael J. Wysocki
2013-01-25 23:07 ` Toshi Kani
2013-01-26 1:49 ` Rafael J. Wysocki
2013-01-26 14:03 ` Rafael J. Wysocki
2013-01-26 18:42 ` Jiang Liu
2013-01-26 21:46 ` Rafael J. Wysocki
2013-01-28 12:58 ` [PATCH 0/4] " Rafael J. Wysocki
2013-01-28 12:59 ` [PATCH 1/4] ACPI / scan: Introduce struct acpi_scan_handler Rafael J. Wysocki
2013-01-29 2:04 ` Yasuaki Ishimatsu
2013-01-29 2:29 ` Yasuaki Ishimatsu
2013-01-29 2:35 ` Toshi Kani
2013-01-29 11:28 ` Rafael J. Wysocki
2013-01-29 14:50 ` Toshi Kani
2013-01-29 21:32 ` Rafael J. Wysocki
2013-01-29 22:57 ` Toshi Kani
2013-01-29 23:19 ` Rafael J. Wysocki
2013-01-29 23:27 ` Toshi Kani
2013-01-30 13:18 ` Rafael J. Wysocki
2013-02-03 0:52 ` [PATCH] ACPI / scan: Follow priorities of IDs when matching scan handlers Rafael J. Wysocki
2013-02-03 4:54 ` Yinghai Lu
2013-02-03 13:05 ` Rafael J. Wysocki
2013-02-05 23:44 ` Toshi Kani
2013-01-28 13:00 ` [PATCH 2/4] ACPI / PCI: Make PCI root driver use struct acpi_scan_handler Rafael J. Wysocki
2013-01-28 13:00 ` [PATCH 3/4] ACPI / PCI: Make PCI IRQ link " Rafael J. Wysocki
2013-01-28 13:01 ` [PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices Rafael J. Wysocki
2013-01-29 2:20 ` Yasuaki Ishimatsu
2013-01-29 11:36 ` Rafael J. Wysocki
2013-01-29 12:30 ` [Update][PATCH " Rafael J. Wysocki
2013-01-29 23:51 ` Yasuaki Ishimatsu
2013-01-29 7:35 ` [PATCH " Mika Westerberg
2013-01-29 12:01 ` Rafael J. Wysocki
2013-01-29 8:05 ` Mika Westerberg
2013-01-29 12:02 ` Rafael J. Wysocki
2013-01-28 21:54 ` [PATCH 0/4] ACPI scan handlers Yinghai Lu
2013-01-29 0:38 ` Rafael J. Wysocki
2013-01-29 2:33 ` Toshi Kani
2013-01-30 1:58 ` Toshi Kani
2013-01-30 13:36 ` Rafael J. Wysocki
2013-02-03 23:45 ` [PATCH 0/2] ACPI scan handler for memory hotplug and container simplification Rafael J. Wysocki
2013-02-03 23:46 ` [PATCH 1/2] ACPI / scan: Make memory hotplug driver use struct acpi_scan_handler Rafael J. Wysocki
2013-02-03 23:47 ` [PATCH 2/2] ACPI / scan: Simplify container driver Rafael J. Wysocki
2013-02-06 22:32 ` Toshi Kani
2013-02-07 0:55 ` Rafael J. Wysocki
2013-02-07 0:51 ` Toshi Kani
2013-02-07 1:32 ` Rafael J. Wysocki
2013-02-07 14:32 ` Toshi Kani
2013-02-07 22:42 ` Rafael J. Wysocki
2013-02-08 1:05 ` Toshi Kani
2013-02-08 12:52 ` Rafael J. Wysocki
2013-02-08 16:24 ` Toshi Kani
2013-02-07 8:32 ` Yasuaki Ishimatsu
2013-02-07 11:43 ` Rafael J. Wysocki
2013-02-07 14:38 ` Toshi Kani
2013-02-08 0:24 ` [PATCH 0/2] ACPI / scan: Remove useless #ifndef and simplify " Rafael J. Wysocki
2013-02-08 0:25 ` Rafael J. Wysocki [this message]
2013-02-08 0:27 ` [PATCH 2/2] ACPI / scan: Make container driver use struct acpi_scan_handler Rafael J. Wysocki
2013-02-08 3:32 ` Yinghai Lu
2013-02-08 12:45 ` Rafael J. Wysocki
2013-02-08 3:19 ` [PATCH 0/2] ACPI / scan: Remove useless #ifndef and simplify container driver Yasuaki Ishimatsu
2013-02-08 12:46 ` Rafael J. Wysocki
2013-02-08 16:57 ` Toshi Kani
2013-02-08 19:59 ` Rafael J. Wysocki
2013-02-08 22:41 ` Rafael J. Wysocki
2013-02-08 23:18 ` [PATCH] ACPI: Drop the container.h header file Rafael J. Wysocki
2013-02-08 23:27 ` Toshi Kani
2013-02-09 14:26 ` [PATCH 0/2] ACPI / scan: Two fixes for device hot-removal Rafael J. Wysocki
2013-02-09 14:29 ` [PATCH 1/2] ACPI / scan: Make acpi_bus_hot_remove_device() acquire the scan lock Rafael J. Wysocki
2013-02-11 23:42 ` Toshi Kani
2013-02-09 14:31 ` [PATCH 2/2] ACPI / scan: Full transition to D3cold in acpi_device_unregister() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498466.XkrmNzKycX@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=matthew.garrett@nebula.com \
--cc=mika.westerberg@linux.intel.com \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®