From: Mark Rogers <mail@mark-rogers.org>
To: gregkh@linuxfoundation.org
Cc: mail@mark-rogers.org, "Tobin C. Harding" <me@tobin.cc>,
sayli karnik <karniksayli1995@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: ks7010: fix styling WARNINGs
Date: Thu, 29 Jun 2017 21:52:38 -0700 [thread overview]
Message-ID: <1498798361-9965-1-git-send-email-mail@mark-rogers.org> (raw)
Trivial style changes. There are still 3 "line over 80 characters"
checkpatch.pl warnings, but I think they are best left alone as
breaking the first two warning lines could hurt readability. The third
warning is a message that should not be broken for the sake of grep.
All but one of the changes fix lines that exceed 80 characters. An
embedded function name was replaced by __func__ as well.
Signed-off-by: Mark Rogers <mail@mark-rogers.org>
---
drivers/staging/ks7010/ks7010_sdio.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index c325f48..6c0c6b2 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -548,7 +548,8 @@ static void ks_sdio_interrupt(struct sdio_func *func)
if (atomic_read(&priv->psstatus.status) == PS_SNOOZE) {
if (cnt_txqbody(priv)) {
ks_wlan_hw_wakeup_request(priv);
- queue_delayed_work(priv->wq, &priv->rw_dwork, 1);
+ queue_delayed_work(priv->wq,
+ &priv->rw_dwork, 1);
return;
}
} else {
@@ -693,15 +694,18 @@ static int ks7010_upload_firmware(struct ks_sdio_card *card)
memcpy(rom_buf, fw_entry->data + n, size);
offset = n;
- ret = ks7010_sdio_update_index(priv, KS7010_IRAM_ADDRESS + offset);
+ ret = ks7010_sdio_update_index(priv,
+ KS7010_IRAM_ADDRESS + offset);
if (ret)
goto release_firmware;
- ret = ks7010_sdio_write(priv, DATA_WINDOW, rom_buf, size);
+ ret = ks7010_sdio_write(priv,
+ DATA_WINDOW, rom_buf, size);
if (ret)
goto release_firmware;
- ret = ks7010_sdio_data_compare(priv, DATA_WINDOW, rom_buf, size);
+ ret = ks7010_sdio_data_compare(priv,
+ DATA_WINDOW, rom_buf, size);
if (ret)
goto release_firmware;
@@ -889,7 +893,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
priv = netdev_priv(netdev);
card->priv = priv;
- SET_NETDEV_DEV(netdev, &card->func->dev); /* for create sysfs symlinks */
+ SET_NETDEV_DEV(netdev, &card->func->dev);/* for create sysfs symlinks */
/* private memory initialize */
priv->ks_sdio_card = card;
@@ -923,7 +927,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
}
/* interrupt setting */
- /* clear Interrupt status write (ARMtoSD_InterruptPending FN1:00_0024) */
+ /* clear Interrupt status write (ARMtoSD_InterruptPending FN1:00_0024)*/
sdio_claim_host(func);
ret = ks7010_sdio_writeb(priv, INT_PENDING, 0xff);
sdio_release_host(func);
@@ -1006,7 +1010,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
struct ks_sdio_card *card;
struct ks_wlan_private *priv;
- DPRINTK(1, "ks7010_sdio_remove()\n");
+ DPRINTK(1, "%s()\n", __func__);
card = sdio_get_drvdata(func);
--
2.7.4
next reply other threads:[~2017-06-30 4:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 4:52 Mark Rogers [this message]
2017-06-30 5:54 ` Frans Klaver
2017-06-30 18:39 ` Mark Rogers
2017-07-11 17:27 ` Greg KH
2017-07-12 8:08 ` Frans Klaver
2017-08-01 0:25 [PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call Joe Perches
2017-07-31 3:15 ` [PATCH] staging: ks7010: fix styling WARNINGs Ashish Kalra
2017-08-01 1:18 ` Greg KH
2017-08-01 4:29 ` kbuild test robot
2017-08-01 4:31 ` kbuild test robot
2017-08-01 16:11 ` Ashish Kalra
2017-08-01 16:22 ` Joe Perches
2017-08-01 20:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498798361-9965-1-git-send-email-mail@mark-rogers.org \
--to=mail@mark-rogers.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=karniksayli1995@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®