From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] net: sis: Fix a function name in comments
Date: Sat, 25 Sep 2021 15:07:22 +0200 [thread overview]
Message-ID: <1498cb33-bbd1-ccb7-0ea3-12b319e18dbe@wanadoo.fr> (raw)
In-Reply-To: <20210925125042.1629-3-caihuoqing@baidu.com>
Le 25/09/2021 à 14:50, Cai Huoqing a écrit :
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/net/ethernet/sis/sis190.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c
> index 3d1a18a01ce5..7e107407476a 100644
> --- a/drivers/net/ethernet/sis/sis190.c
> +++ b/drivers/net/ethernet/sis/sis190.c
> @@ -1070,7 +1070,7 @@ static int sis190_open(struct net_device *dev)
>
> /*
> * Rx and Tx descriptors need 256 bytes alignment.
> - * pci_alloc_consistent() guarantees a stronger alignment.
> + * dma_alloc_consistent() guarantees a stronger alignment.
> */
> tp->TxDescRing = dma_alloc_coherent(&pdev->dev, TX_RING_BYTES,
> &tp->tx_dma, GFP_KERNEL);
>
Hi,
s/consistent/coherent/
CJ
WARNING: multiple messages have this Message-ID
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Chris Snook <chris.snook@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] net: sis: Fix a function name in comments
Date: Sat, 25 Sep 2021 15:07:22 +0200 [thread overview]
Message-ID: <1498cb33-bbd1-ccb7-0ea3-12b319e18dbe@wanadoo.fr> (raw)
Message-ID: <20210925130722.q1MhrYU_Npa7Fk4nDU8IGxfC9QX1p13Qb2YWcB6tf3Y@z> (raw)
In-Reply-To: <20210925125042.1629-3-caihuoqing@baidu.com>
Le 25/09/2021 à 14:50, Cai Huoqing a écrit :
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/net/ethernet/sis/sis190.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c
> index 3d1a18a01ce5..7e107407476a 100644
> --- a/drivers/net/ethernet/sis/sis190.c
> +++ b/drivers/net/ethernet/sis/sis190.c
> @@ -1070,7 +1070,7 @@ static int sis190_open(struct net_device *dev)
>
> /*
> * Rx and Tx descriptors need 256 bytes alignment.
> - * pci_alloc_consistent() guarantees a stronger alignment.
> + * dma_alloc_consistent() guarantees a stronger alignment.
> */
> tp->TxDescRing = dma_alloc_coherent(&pdev->dev, TX_RING_BYTES,
> &tp->tx_dma, GFP_KERNEL);
>
Hi,
s/consistent/coherent/
CJ
next prev parent reply other threads:[~2021-09-25 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 12:50 [PATCH 1/4] net: atl1c: Fix a function name in print messages Cai Huoqing
2021-09-25 12:50 ` [PATCH 2/4] net: broadcom: Fix a function name in comments Cai Huoqing
2021-09-25 12:50 ` [PATCH 3/4] net: sis: " Cai Huoqing
2021-09-25 13:07 ` Christophe JAILLET [this message]
2021-09-25 13:07 ` Christophe JAILLET
2021-09-25 12:50 ` [PATCH 4/4] net: smsc: Fix function names in print messages and coments Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498cb33-bbd1-ccb7-0ea3-12b319e18dbe@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®