mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mmc: mediatek: add ops->get_cd() support
@ 2017-07-03  6:24 Chaotian Jing
  2017-07-11 14:43 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Chaotian Jing @ 2017-07-03  6:24 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Matthias Brugger, Chaotian Jing, yong mao, Linus Walleij,
	Heiner Kallweit, Javier Martinez Canillas, linux-mmc,
	linux-arm-kernel, linux-mediatek, linux-kernel, srv_heupstream

if user plug out sd card slowly, finally card is plugged out but
cat /proc/partitions can find that card is still exist in kernel.
that's because alougth get card detect interrupt but CMD13 still
can get correct response(all other pins are connected expect card
detect pin).
add ops->get_cd() can avoid this issue.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 5c1e178..975c765 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1585,6 +1585,7 @@ static void msdc_hw_reset(struct mmc_host *mmc)
 	.request = msdc_ops_request,
 	.set_ios = msdc_ops_set_ios,
 	.get_ro = mmc_gpio_get_ro,
+	.get_cd = mmc_gpio_get_cd,
 	.start_signal_voltage_switch = msdc_ops_switch_volt,
 	.card_busy = msdc_card_busy,
 	.execute_tuning = msdc_execute_tuning,
-- 
1.8.1.1.dirty

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: mediatek: add ops->get_cd() support
  2017-07-03  6:24 [PATCH] mmc: mediatek: add ops->get_cd() support Chaotian Jing
@ 2017-07-11 14:43 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2017-07-11 14:43 UTC (permalink / raw)
  To: Chaotian Jing
  Cc: Matthias Brugger, yong mao, Linus Walleij, Heiner Kallweit,
	Javier Martinez Canillas, linux-mmc, linux-arm-kernel,
	linux-mediatek, linux-kernel, srv_heupstream

On 3 July 2017 at 08:24, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> if user plug out sd card slowly, finally card is plugged out but
> cat /proc/partitions can find that card is still exist in kernel.
> that's because alougth get card detect interrupt but CMD13 still
> can get correct response(all other pins are connected expect card
> detect pin).
> add ops->get_cd() can avoid this issue.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 5c1e178..975c765 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1585,6 +1585,7 @@ static void msdc_hw_reset(struct mmc_host *mmc)
>         .request = msdc_ops_request,
>         .set_ios = msdc_ops_set_ios,
>         .get_ro = mmc_gpio_get_ro,
> +       .get_cd = mmc_gpio_get_cd,
>         .start_signal_voltage_switch = msdc_ops_switch_volt,
>         .card_busy = msdc_card_busy,
>         .execute_tuning = msdc_execute_tuning,
> --
> 1.8.1.1.dirty
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-11 14:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03  6:24 [PATCH] mmc: mediatek: add ops->get_cd() support Chaotian Jing
2017-07-11 14:43 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®