* [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
@ 2017-07-06 1:22 yash007
2017-07-06 7:10 ` Frans Klaver
0 siblings, 1 reply; 7+ messages in thread
From: yash007 @ 2017-07-06 1:22 UTC (permalink / raw)
To: lidz.louin; +Cc: markh, gregkh, driverdev-devel, devel, linux-kernel
From: Yash Omer <yash007@boss>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 1943e66..0034ebe 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 4)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 2)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
neo_pci_posting_flush(ch->ch_bd);
/* Give time for the UART to actually raise/drop the signals */
- udelay(10);
+ usleep_range(10);
}
static void neo_send_start_character(struct channel_t *ch)
@@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
ch->ch_xon_sends++;
writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
@@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
ch->ch_xoff_sends++;
writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
--
2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
2017-07-06 1:22 [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com> yash007
@ 2017-07-06 7:10 ` Frans Klaver
0 siblings, 0 replies; 7+ messages in thread
From: Frans Klaver @ 2017-07-06 7:10 UTC (permalink / raw)
To: yash007; +Cc: lidz.louin, markh, Greg KH, driverdev-devel, devel, linux-kernel
On Thu, Jul 6, 2017 at 3:22 AM, yash007 <yashomer0007@gmail.com> wrote:
> From: Yash Omer <yash007@boss>
Your commit message is completely broken. Please fix it. See
Documentation/process/submitting-patches.rst chapter 14.
>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 1943e66..0034ebe 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
> */
> tmp = readb(&ch->ch_neo_uart->isr_fcr);
> if (tmp & 4)
> - udelay(10);
> + usleep_range(10);
> else
> break;
> }
> @@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
> */
> tmp = readb(&ch->ch_neo_uart->isr_fcr);
> if (tmp & 2)
> - udelay(10);
> + usleep_range(10);
> else
> break;
> }
> @@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
> neo_pci_posting_flush(ch->ch_bd);
>
> /* Give time for the UART to actually raise/drop the signals */
> - udelay(10);
> + usleep_range(10);
> }
>
> static void neo_send_start_character(struct channel_t *ch)
> @@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
> ch->ch_xon_sends++;
> writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
> neo_pci_posting_flush(ch->ch_bd);
> - udelay(10);
> + usleep_range(10);
> }
> }
>
> @@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
> ch->ch_xoff_sends++;
> writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
> neo_pci_posting_flush(ch->ch_bd);
> - udelay(10);
> + usleep_range(10);
> }
> }
>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
2017-07-06 1:59 yash007
@ 2017-07-06 9:21 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2017-07-06 9:21 UTC (permalink / raw)
To: yash007; +Cc: lidza.louina, markh, gregkh, driverdev-devel, linux-kernel, devel
On Thu, Jul 06, 2017 at 07:29:32AM +0530, yash007 wrote:
> From: Yash Omer <yash007@boss>
>
Send your patch to yourself until you figure out the right format then
send it to the list.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
2017-07-06 1:49 yash007
@ 2017-07-06 7:31 ` Frans Klaver
0 siblings, 0 replies; 7+ messages in thread
From: Frans Klaver @ 2017-07-06 7:31 UTC (permalink / raw)
To: yash007; +Cc: lidz.louin, markh, Greg KH, driverdev-devel, devel, linux-kernel
Hi,
On Thu, Jul 6, 2017 at 3:49 AM, yash007 <yashomer0007@gmail.com> wrote:
> From: Yash Omer <yash007@boss>
Instead of resending the same thing every time, could you instead fix
your commit message and send a v2?
Also, where's patch 1 of 2?
>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 1943e66..0034ebe 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
> */
> tmp = readb(&ch->ch_neo_uart->isr_fcr);
> if (tmp & 4)
> - udelay(10);
> + usleep_range(10);
> else
> break;
> }
> @@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
> */
> tmp = readb(&ch->ch_neo_uart->isr_fcr);
> if (tmp & 2)
> - udelay(10);
> + usleep_range(10);
> else
> break;
> }
> @@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
> neo_pci_posting_flush(ch->ch_bd);
>
> /* Give time for the UART to actually raise/drop the signals */
> - udelay(10);
> + usleep_range(10);
> }
>
> static void neo_send_start_character(struct channel_t *ch)
> @@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
> ch->ch_xon_sends++;
> writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
> neo_pci_posting_flush(ch->ch_bd);
> - udelay(10);
> + usleep_range(10);
> }
> }
>
> @@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
> ch->ch_xoff_sends++;
> writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
> neo_pci_posting_flush(ch->ch_bd);
> - udelay(10);
> + usleep_range(10);
> }
> }
>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
@ 2017-07-06 1:59 yash007
2017-07-06 9:21 ` Dan Carpenter
0 siblings, 1 reply; 7+ messages in thread
From: yash007 @ 2017-07-06 1:59 UTC (permalink / raw)
To: lidza.louina; +Cc: markh, gregkh, driverdev-devel, devel, linux-kernel
From: Yash Omer <yash007@boss>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 1943e66..0034ebe 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 4)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 2)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
neo_pci_posting_flush(ch->ch_bd);
/* Give time for the UART to actually raise/drop the signals */
- udelay(10);
+ usleep_range(10);
}
static void neo_send_start_character(struct channel_t *ch)
@@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
ch->ch_xon_sends++;
writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
@@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
ch->ch_xoff_sends++;
writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
--
2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
@ 2017-07-06 1:49 yash007
2017-07-06 7:31 ` Frans Klaver
0 siblings, 1 reply; 7+ messages in thread
From: yash007 @ 2017-07-06 1:49 UTC (permalink / raw)
To: lidz.louin; +Cc: markh, gregkh, driverdev-devel, devel, linux-kernel
From: Yash Omer <yash007@boss>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 1943e66..0034ebe 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 4)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 2)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
neo_pci_posting_flush(ch->ch_bd);
/* Give time for the UART to actually raise/drop the signals */
- udelay(10);
+ usleep_range(10);
}
static void neo_send_start_character(struct channel_t *ch)
@@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
ch->ch_xon_sends++;
writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
@@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
ch->ch_xoff_sends++;
writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
--
2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>
@ 2017-07-06 1:31 yash007
0 siblings, 0 replies; 7+ messages in thread
From: yash007 @ 2017-07-06 1:31 UTC (permalink / raw)
To: lidza.louina; +Cc: markh, driverdev-devel, devel, linux-kernel
From: Yash Omer <yash007@boss>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 1943e66..0034ebe 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 4)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
*/
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 2)
- udelay(10);
+ usleep_range(10);
else
break;
}
@@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
neo_pci_posting_flush(ch->ch_bd);
/* Give time for the UART to actually raise/drop the signals */
- udelay(10);
+ usleep_range(10);
}
static void neo_send_start_character(struct channel_t *ch)
@@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
ch->ch_xon_sends++;
writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
@@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
ch->ch_xoff_sends++;
writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10);
}
}
--
2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-06 9:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 1:22 [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com> yash007
2017-07-06 7:10 ` Frans Klaver
2017-07-06 1:31 yash007
2017-07-06 1:49 yash007
2017-07-06 7:31 ` Frans Klaver
2017-07-06 1:59 yash007
2017-07-06 9:21 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®