* [PATCH] Add support of all Foxconn (105b) Broadcom devices
@ 2017-07-06 11:29 Dmitry Tunin
2017-07-06 11:42 ` Dmitry Tunin
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Dmitry Tunin @ 2017-07-06 11:29 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg
Cc: linux-bluetooth, linux-kernel, Dmitry Tunin, stable
There is another device
T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=105b ProdID=e066 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=342387DAE35E
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Since we have Cls=ff, we can add all of them.
Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
Cc: stable@vger.kernel.org
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fa24d69..bf95c13 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
/* Broadcom BCM43142A0 (Foxconn/Lenovo) */
- { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
+ { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
/* Broadcom BCM920703 (HTC Vive) */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-06 11:29 [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin
@ 2017-07-06 11:42 ` Dmitry Tunin
2017-07-16 0:20 ` kbuild test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Dmitry Tunin @ 2017-07-06 11:42 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg
Cc: linux-bluetooth, linux-kernel, Dmitry Tunin, stable
I lost a line here. Sending v2.
2017-07-06 14:29 GMT+03:00 Dmitry Tunin <hanipouspilot@gmail.com>:
> There is another device
>
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=105b ProdID=e066 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=342387DAE35E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Since we have Cls=ff, we can add all of them.
>
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fa24d69..bf95c13 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>
> /* Broadcom BCM920703 (HTC Vive) */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-06 11:29 [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin
2017-07-06 11:42 ` Dmitry Tunin
@ 2017-07-16 0:20 ` kbuild test robot
2017-07-16 1:11 ` kbuild test robot
2017-07-16 7:15 ` Marcel Holtmann
3 siblings, 0 replies; 8+ messages in thread
From: kbuild test robot @ 2017-07-16 0:20 UTC (permalink / raw)
To: Dmitry Tunin
Cc: kbuild-all, Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
linux-bluetooth, linux-kernel, Dmitry Tunin, stable
[-- Attachment #1: Type: text/plain, Size: 21008 bytes --]
Hi Dmitry,
[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v4.13-rc1]
[cannot apply to next-20170714]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All errors (new ones prefixed by >>):
include/linux/usb.h:1062:14: warning: excess elements in scalar initializer
.idVendor = (vend), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:14: note: (near initialization for 'btusb_table[21].driver_info')
.idVendor = (vend), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: error: field name not in record or union initializer
.bInterfaceClass = (cl), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceClass = (cl), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: warning: excess elements in scalar initializer
.bInterfaceClass = (cl), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceClass = (cl), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: error: field name not in record or union initializer
.bInterfaceSubClass = (sc), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceSubClass = (sc), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: warning: excess elements in scalar initializer
.bInterfaceSubClass = (sc), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceSubClass = (sc), \
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: error: field name not in record or union initializer
.bInterfaceProtocol = (pr)
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceProtocol = (pr)
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: warning: excess elements in scalar initializer
.bInterfaceProtocol = (pr)
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceProtocol = (pr)
^
drivers//bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers//bluetooth/btusb.c:142:4: error: field name not in record or union initializer
.driver_info = BTUSB_BCM_PATCHRAM },
^
drivers//bluetooth/btusb.c:142:4: note: (near initialization for 'btusb_table[21].driver_info')
drivers//bluetooth/btusb.c:58:28: warning: excess elements in scalar initializer
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers//bluetooth/btusb.c:142:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
drivers//bluetooth/btusb.c:58:28: note: (near initialization for 'btusb_table[21].driver_info')
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers//bluetooth/btusb.c:142:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
>> drivers//bluetooth/btusb.c:145:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x04ca, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:145:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:145:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:145:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:149:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:149:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:149:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:149:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:153:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0b05, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:153:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:153:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:153:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:157:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:157:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:157:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:157:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:161:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:161:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:161:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:161:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:165:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x413c, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:165:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:165:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:165:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:169:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0930, 0xff, 0x01, 0x01),
^
drivers//bluetooth/btusb.c:169:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:169:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:169:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:173:2: error: extra brace group at end of initializer
{ USB_DEVICE(0x8087, 0x0a5a),
^
drivers//bluetooth/btusb.c:173:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:173:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:173:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:176:2: error: extra brace group at end of initializer
{ } /* Terminating entry */
^
drivers//bluetooth/btusb.c:176:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:176:2: warning: excess elements in struct initializer
drivers//bluetooth/btusb.c:176:2: note: (near initialization for 'btusb_table[21]')
drivers//bluetooth/btusb.c:177:2: error: expected '}' before ';' token
};
^
drivers//bluetooth/btusb.c:46:26: warning: 'btusb_driver' defined but not used [-Wunused-variable]
static struct usb_driver btusb_driver;
^~~~~~~~~~~~
drivers//bluetooth/btusb.c:44:13: warning: 'reset' defined but not used [-Wunused-variable]
static bool reset = true;
^~~~~
drivers//bluetooth/btusb.c:42:13: warning: 'force_scofix' defined but not used [-Wunused-variable]
static bool force_scofix;
^~~~~~~~~~~~
drivers//bluetooth/btusb.c:41:13: warning: 'disable_scofix' defined but not used [-Wunused-variable]
static bool disable_scofix;
^~~~~~~~~~~~~~
vim +145 drivers//bluetooth/btusb.c
5e23b923da Marcel Holtmann 2007-10-20 69
54265202f1 Marcel Holtmann 2013-10-11 70 static const struct usb_device_id btusb_table[] = {
5e23b923da Marcel Holtmann 2007-10-20 71 /* Generic Bluetooth USB device */
5e23b923da Marcel Holtmann 2007-10-20 72 { USB_DEVICE_INFO(0xe0, 0x01, 0x01) },
5e23b923da Marcel Holtmann 2007-10-20 73
893ba5440a Marcel Holtmann 2015-01-28 74 /* Generic Bluetooth AMP device */
893ba5440a Marcel Holtmann 2015-01-28 75 { USB_DEVICE_INFO(0xe0, 0x01, 0x04), .driver_info = BTUSB_AMP },
893ba5440a Marcel Holtmann 2015-01-28 76
d63b282645 Daniel Drake 2015-07-17 77 /* Generic Bluetooth USB interface */
d63b282645 Daniel Drake 2015-07-17 78 { USB_INTERFACE_INFO(0xe0, 0x01, 0x01) },
d63b282645 Daniel Drake 2015-07-17 79
1fa6535faf Henrik Rydberg 2012-08-25 80 /* Apple-specific (Broadcom) devices */
17b2772b8f Marcel Holtmann 2015-03-22 81 { USB_VENDOR_AND_INTERFACE_INFO(0x05ac, 0xff, 0x01, 0x01),
22f8e9dbf6 Marcel Holtmann 2015-10-20 82 .driver_info = BTUSB_BCM_APPLE | BTUSB_IFNUM_2 },
1fa6535faf Henrik Rydberg 2012-08-25 83
178c059e76 Cho, Yu-Chen 2013-06-04 84 /* MediaTek MT76x0E */
178c059e76 Cho, Yu-Chen 2013-06-04 85 { USB_DEVICE(0x0e8d, 0x763f) },
178c059e76 Cho, Yu-Chen 2013-06-04 86
c510eae377 Oliver Neukum 2011-09-21 87 /* Broadcom SoftSailing reporting vendor specific */
2e8b506310 Don Zickus 2012-03-28 88 { USB_DEVICE(0x0a5c, 0x21e1) },
c510eae377 Oliver Neukum 2011-09-21 89
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 90 /* Apple MacBookPro 7,1 */
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 91 { USB_DEVICE(0x05ac, 0x8213) },
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 92
0a79f67445 Cyril Lacoux 2010-07-14 93 /* Apple iMac11,1 */
0a79f67445 Cyril Lacoux 2010-07-14 94 { USB_DEVICE(0x05ac, 0x8215) },
0a79f67445 Cyril Lacoux 2010-07-14 95
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 96 /* Apple MacBookPro6,2 */
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 97 { USB_DEVICE(0x05ac, 0x8218) },
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 98
3e3ede7dda Edgar (gimli Hucek 2010-11-04 99) /* Apple MacBookAir3,1, MacBookAir3,2 */
3e3ede7dda Edgar (gimli Hucek 2010-11-04 100) { USB_DEVICE(0x05ac, 0x821b) },
3e3ede7dda Edgar (gimli Hucek 2010-11-04 101)
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 102 /* Apple MacBookAir4,1 */
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 103 { USB_DEVICE(0x05ac, 0x821f) },
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 104
88d377b6c3 Marc-Antoine Perennou 2011-03-24 105 /* Apple MacBookPro8,2 */
88d377b6c3 Marc-Antoine Perennou 2011-03-24 106 { USB_DEVICE(0x05ac, 0x821a) },
88d377b6c3 Marc-Antoine Perennou 2011-03-24 107
f78b68261e Jurgen Kramer 2011-09-04 108 /* Apple MacMini5,1 */
f78b68261e Jurgen Kramer 2011-09-04 109 { USB_DEVICE(0x05ac, 0x8281) },
f78b68261e Jurgen Kramer 2011-09-04 110
cfeb414537 Marcel Holtmann 2008-08-07 111 /* AVM BlueFRITZ! USB v2.0 */
4fcef8ed75 Marcel Holtmann 2015-01-01 112 { USB_DEVICE(0x057c, 0x3800), .driver_info = BTUSB_SWAVE },
cfeb414537 Marcel Holtmann 2008-08-07 113
cfeb414537 Marcel Holtmann 2008-08-07 114 /* Bluetooth Ultraport Module from IBM */
cfeb414537 Marcel Holtmann 2008-08-07 115 { USB_DEVICE(0x04bf, 0x030a) },
cfeb414537 Marcel Holtmann 2008-08-07 116
cfeb414537 Marcel Holtmann 2008-08-07 117 /* ALPS Modules with non-standard id */
cfeb414537 Marcel Holtmann 2008-08-07 118 { USB_DEVICE(0x044e, 0x3001) },
cfeb414537 Marcel Holtmann 2008-08-07 119 { USB_DEVICE(0x044e, 0x3002) },
cfeb414537 Marcel Holtmann 2008-08-07 120
cfeb414537 Marcel Holtmann 2008-08-07 121 /* Ericsson with non-standard id */
cfeb414537 Marcel Holtmann 2008-08-07 122 { USB_DEVICE(0x0bdb, 0x1002) },
cfeb414537 Marcel Holtmann 2008-08-07 123
cfeb414537 Marcel Holtmann 2008-08-07 124 /* Canyon CN-BTU1 with HID interfaces */
7a9d402053 Marcel Holtmann 2008-11-30 125 { USB_DEVICE(0x0c10, 0x0000) },
cfeb414537 Marcel Holtmann 2008-08-07 126
d13431ca3e Wen-chien Jesse Sung 2011-11-08 127 /* Broadcom BCM20702A0 */
d13431ca3e Wen-chien Jesse Sung 2011-11-08 128 { USB_DEVICE(0x413c, 0x8197) },
d13431ca3e Wen-chien Jesse Sung 2011-11-08 129
d049f4e513 Marcel Holtmann 2015-01-26 130 /* Broadcom BCM20702B0 (Dynex/Insignia) */
d049f4e513 Marcel Holtmann 2015-01-26 131 { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
d049f4e513 Marcel Holtmann 2015-01-26 132
2faf71ce90 Santtu Rekilä 2015-10-05 133 /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
6b3a9e1458 Dmitry Tunin 2017-07-06 134 { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
2faf71ce90 Santtu Rekilä 2015-10-05 135
a57bac4346 Christoph Haag 2017-02-10 136 /* Broadcom BCM920703 (HTC Vive) */
a57bac4346 Christoph Haag 2017-02-10 137 { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
a57bac4346 Christoph Haag 2017-02-10 138 .driver_info = BTUSB_BCM_PATCHRAM },
a57bac4346 Christoph Haag 2017-02-10 139
985140369b Steven Harms 2012-04-13 140 /* Foxconn - Hon Hai */
6029ddc233 Heinrich Siebmanns 2014-12-03 141 { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
6029ddc233 Heinrich Siebmanns 2014-12-03 @142 .driver_info = BTUSB_BCM_PATCHRAM },
985140369b Steven Harms 2012-04-13 143
8f0c304c69 Matej Dubovy 2015-02-02 144 /* Lite-On Technology - Broadcom based */
8f0c304c69 Matej Dubovy 2015-02-02 @145 { USB_VENDOR_AND_INTERFACE_INFO(0x04ca, 0xff, 0x01, 0x01),
8f0c304c69 Matej Dubovy 2015-02-02 146 .driver_info = BTUSB_BCM_PATCHRAM },
8f0c304c69 Matej Dubovy 2015-02-02 147
92c385f46b Gustavo Padovan 2012-08-06 148 /* Broadcom devices with vendor specific id */
10d4c6736e Petri Gynther 2014-05-08 149 { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
10d4c6736e Petri Gynther 2014-05-08 150 .driver_info = BTUSB_BCM_PATCHRAM },
92c385f46b Gustavo Padovan 2012-08-06 151
c2aef6e8cb Marcel Holtmann 2014-07-21 152 /* ASUSTek Computer - Broadcom based */
9a5abdaaf9 Rick Dunn 2015-01-17 153 { USB_VENDOR_AND_INTERFACE_INFO(0x0b05, 0xff, 0x01, 0x01),
9a5abdaaf9 Rick Dunn 2015-01-17 154 .driver_info = BTUSB_BCM_PATCHRAM },
c2aef6e8cb Marcel Holtmann 2014-07-21 155
5bcecf3253 Ken O'Brien 2013-09-21 156 /* Belkin F8065bf - Broadcom based */
6331c686e6 Marcel Holtmann 2015-03-27 157 { USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01),
6331c686e6 Marcel Holtmann 2015-03-27 158 .driver_info = BTUSB_BCM_PATCHRAM },
5bcecf3253 Ken O'Brien 2013-09-21 159
9113bfd82d Jurgen Kramer 2014-02-15 160 /* IMC Networks - Broadcom based */
6331c686e6 Marcel Holtmann 2015-03-27 161 { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
6331c686e6 Marcel Holtmann 2015-03-27 162 .driver_info = BTUSB_BCM_PATCHRAM },
9113bfd82d Jurgen Kramer 2014-02-15 163
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 164 /* Dell Computer - Broadcom based */
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 165 { USB_VENDOR_AND_INTERFACE_INFO(0x413c, 0xff, 0x01, 0x01),
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 166 .driver_info = BTUSB_BCM_PATCHRAM },
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 167
1623d0bf84 Dmitry Tunin 2015-12-05 168 /* Toshiba Corp - Broadcom based */
1623d0bf84 Dmitry Tunin 2015-12-05 169 { USB_VENDOR_AND_INTERFACE_INFO(0x0930, 0xff, 0x01, 0x01),
1623d0bf84 Dmitry Tunin 2015-12-05 170 .driver_info = BTUSB_BCM_PATCHRAM },
1623d0bf84 Dmitry Tunin 2015-12-05 171
40df783d1e Marcel Holtmann 2014-07-06 172 /* Intel Bluetooth USB Bootloader (RAM module) */
d92f2df056 Marcel Holtmann 2014-07-06 173 { USB_DEVICE(0x8087, 0x0a5a),
d92f2df056 Marcel Holtmann 2014-07-06 174 .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC },
40df783d1e Marcel Holtmann 2014-07-06 175
5e23b923da Marcel Holtmann 2007-10-20 176 { } /* Terminating entry */
5e23b923da Marcel Holtmann 2007-10-20 177 };
5e23b923da Marcel Holtmann 2007-10-20 178
:::::: The code at line 145 was first introduced by commit
:::::: 8f0c304c693c5a9759ed6ae50d07d4590dad5ae7 Bluetooth: btusb: Add support for Lite-On (04ca) Broadcom based, BCM43142
:::::: TO: Matej Dubovy <matej.dubovy@gmail.com>
:::::: CC: Marcel Holtmann <marcel@holtmann.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50237 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-06 11:29 [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin
2017-07-06 11:42 ` Dmitry Tunin
2017-07-16 0:20 ` kbuild test robot
@ 2017-07-16 1:11 ` kbuild test robot
2017-07-16 7:15 ` Marcel Holtmann
3 siblings, 0 replies; 8+ messages in thread
From: kbuild test robot @ 2017-07-16 1:11 UTC (permalink / raw)
To: Dmitry Tunin
Cc: kbuild-all, Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
linux-bluetooth, linux-kernel, Dmitry Tunin, stable
[-- Attachment #1: Type: text/plain, Size: 29065 bytes --]
Hi Dmitry,
[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v4.13-rc1]
[cannot apply to next-20170714]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: powerpc-ps3_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:2: error: field name not in record or union initializer
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:2: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:14: warning: excess elements in scalar initializer
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:14: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: error: field name not in record or union initializer
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: warning: excess elements in scalar initializer
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: error: field name not in record or union initializer
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: warning: excess elements in scalar initializer
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: error: field name not in record or union initializer
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: warning: excess elements in scalar initializer
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:137:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btusb.c:138:4: error: field name not in record or union initializer
.driver_info = BTUSB_BCM_PATCHRAM },
^
drivers/bluetooth/btusb.c:138:4: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
drivers/bluetooth/btusb.c:58:28: warning: excess elements in scalar initializer
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers/bluetooth/btusb.c:138:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:58:28: note: (near initialization for 'btusb_table[21].bInterfaceNumber')
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers/bluetooth/btusb.c:138:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:141:2: warning: braces around scalar initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:141:2: note: (near initialization for 'btusb_table[21].driver_info')
In file included from drivers/bluetooth/btusb.c:25:0:
include/linux/usb.h:1060:2: error: field name not in record or union initializer
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1060:2: note: (near initialization for 'btusb_table[21].driver_info')
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:2: error: field name not in record or union initializer
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:2: note: (near initialization for 'btusb_table[21].driver_info')
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:14: warning: excess elements in scalar initializer
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1062:14: note: (near initialization for 'btusb_table[21].driver_info')
.idVendor = (vend), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: error: field name not in record or union initializer
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: warning: excess elements in scalar initializer
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1063:21: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceClass = (cl), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: error: field name not in record or union initializer
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: warning: excess elements in scalar initializer
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1064:24: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceSubClass = (sc), \
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: error: field name not in record or union initializer
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:2: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: warning: excess elements in scalar initializer
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb.h:1065:24: note: (near initialization for 'btusb_table[21].driver_info')
.bInterfaceProtocol = (pr)
^
drivers/bluetooth/btusb.c:141:4: note: in expansion of macro 'USB_VENDOR_AND_INTERFACE_INFO'
{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:142:4: error: field name not in record or union initializer
.driver_info = BTUSB_BCM_PATCHRAM },
^
drivers/bluetooth/btusb.c:142:4: note: (near initialization for 'btusb_table[21].driver_info')
drivers/bluetooth/btusb.c:58:28: warning: excess elements in scalar initializer
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers/bluetooth/btusb.c:142:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:58:28: note: (near initialization for 'btusb_table[21].driver_info')
#define BTUSB_BCM_PATCHRAM 0x400
^
drivers/bluetooth/btusb.c:142:19: note: in expansion of macro 'BTUSB_BCM_PATCHRAM'
.driver_info = BTUSB_BCM_PATCHRAM },
^~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:145:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x04ca, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:145:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:145:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:145:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:149:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:149:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:149:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:149:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:153:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0b05, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:153:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:153:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:153:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:157:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:157:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:157:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:157:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:161:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:161:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:161:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:161:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:165:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x413c, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:165:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:165:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:165:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:169:2: error: extra brace group at end of initializer
{ USB_VENDOR_AND_INTERFACE_INFO(0x0930, 0xff, 0x01, 0x01),
^
drivers/bluetooth/btusb.c:169:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:169:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:169:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:173:2: error: extra brace group at end of initializer
{ USB_DEVICE(0x8087, 0x0a5a),
^
drivers/bluetooth/btusb.c:173:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:173:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:173:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:176:2: error: extra brace group at end of initializer
{ } /* Terminating entry */
^
drivers/bluetooth/btusb.c:176:2: note: (near initialization for 'btusb_table[21]')
drivers/bluetooth/btusb.c:176:2: warning: excess elements in struct initializer
drivers/bluetooth/btusb.c:176:2: note: (near initialization for 'btusb_table[21]')
>> drivers/bluetooth/btusb.c:177:2: error: expected '}' before ';' token
};
^
drivers/bluetooth/btusb.c:46:26: warning: 'btusb_driver' defined but not used [-Wunused-variable]
static struct usb_driver btusb_driver;
^~~~~~~~~~~~
drivers/bluetooth/btusb.c:44:13: warning: 'reset' defined but not used [-Wunused-variable]
static bool reset = true;
^~~~~
drivers/bluetooth/btusb.c:42:13: warning: 'force_scofix' defined but not used [-Wunused-variable]
static bool force_scofix;
^~~~~~~~~~~~
drivers/bluetooth/btusb.c:41:13: warning: 'disable_scofix' defined but not used [-Wunused-variable]
static bool disable_scofix;
^~~~~~~~~~~~~~
vim +138 drivers/bluetooth/btusb.c
5e23b923da Marcel Holtmann 2007-10-20 69
54265202f1 Marcel Holtmann 2013-10-11 70 static const struct usb_device_id btusb_table[] = {
5e23b923da Marcel Holtmann 2007-10-20 71 /* Generic Bluetooth USB device */
5e23b923da Marcel Holtmann 2007-10-20 72 { USB_DEVICE_INFO(0xe0, 0x01, 0x01) },
5e23b923da Marcel Holtmann 2007-10-20 73
893ba5440a Marcel Holtmann 2015-01-28 74 /* Generic Bluetooth AMP device */
893ba5440a Marcel Holtmann 2015-01-28 75 { USB_DEVICE_INFO(0xe0, 0x01, 0x04), .driver_info = BTUSB_AMP },
893ba5440a Marcel Holtmann 2015-01-28 76
d63b282645 Daniel Drake 2015-07-17 77 /* Generic Bluetooth USB interface */
d63b282645 Daniel Drake 2015-07-17 78 { USB_INTERFACE_INFO(0xe0, 0x01, 0x01) },
d63b282645 Daniel Drake 2015-07-17 79
1fa6535faf Henrik Rydberg 2012-08-25 80 /* Apple-specific (Broadcom) devices */
17b2772b8f Marcel Holtmann 2015-03-22 81 { USB_VENDOR_AND_INTERFACE_INFO(0x05ac, 0xff, 0x01, 0x01),
22f8e9dbf6 Marcel Holtmann 2015-10-20 82 .driver_info = BTUSB_BCM_APPLE | BTUSB_IFNUM_2 },
1fa6535faf Henrik Rydberg 2012-08-25 83
178c059e76 Cho, Yu-Chen 2013-06-04 84 /* MediaTek MT76x0E */
178c059e76 Cho, Yu-Chen 2013-06-04 85 { USB_DEVICE(0x0e8d, 0x763f) },
178c059e76 Cho, Yu-Chen 2013-06-04 86
c510eae377 Oliver Neukum 2011-09-21 87 /* Broadcom SoftSailing reporting vendor specific */
2e8b506310 Don Zickus 2012-03-28 88 { USB_DEVICE(0x0a5c, 0x21e1) },
c510eae377 Oliver Neukum 2011-09-21 89
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 90 /* Apple MacBookPro 7,1 */
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 91 { USB_DEVICE(0x05ac, 0x8213) },
3cd01976e7 Nobuhiro Iwamatsu 2010-08-20 92
0a79f67445 Cyril Lacoux 2010-07-14 93 /* Apple iMac11,1 */
0a79f67445 Cyril Lacoux 2010-07-14 94 { USB_DEVICE(0x05ac, 0x8215) },
0a79f67445 Cyril Lacoux 2010-07-14 95
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 96 /* Apple MacBookPro6,2 */
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 97 { USB_DEVICE(0x05ac, 0x8218) },
9c047157a2 Nobuhiro Iwamatsu 2010-08-20 98
3e3ede7dda Edgar (gimli Hucek 2010-11-04 99) /* Apple MacBookAir3,1, MacBookAir3,2 */
3e3ede7dda Edgar (gimli Hucek 2010-11-04 100) { USB_DEVICE(0x05ac, 0x821b) },
3e3ede7dda Edgar (gimli Hucek 2010-11-04 101)
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 102 /* Apple MacBookAir4,1 */
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 103 { USB_DEVICE(0x05ac, 0x821f) },
a63b723d02 Pieter-Augustijn Van Malleghem 2011-09-07 104
88d377b6c3 Marc-Antoine Perennou 2011-03-24 105 /* Apple MacBookPro8,2 */
88d377b6c3 Marc-Antoine Perennou 2011-03-24 106 { USB_DEVICE(0x05ac, 0x821a) },
88d377b6c3 Marc-Antoine Perennou 2011-03-24 107
f78b68261e Jurgen Kramer 2011-09-04 108 /* Apple MacMini5,1 */
f78b68261e Jurgen Kramer 2011-09-04 109 { USB_DEVICE(0x05ac, 0x8281) },
f78b68261e Jurgen Kramer 2011-09-04 110
cfeb414537 Marcel Holtmann 2008-08-07 111 /* AVM BlueFRITZ! USB v2.0 */
4fcef8ed75 Marcel Holtmann 2015-01-01 112 { USB_DEVICE(0x057c, 0x3800), .driver_info = BTUSB_SWAVE },
cfeb414537 Marcel Holtmann 2008-08-07 113
cfeb414537 Marcel Holtmann 2008-08-07 114 /* Bluetooth Ultraport Module from IBM */
cfeb414537 Marcel Holtmann 2008-08-07 115 { USB_DEVICE(0x04bf, 0x030a) },
cfeb414537 Marcel Holtmann 2008-08-07 116
cfeb414537 Marcel Holtmann 2008-08-07 117 /* ALPS Modules with non-standard id */
cfeb414537 Marcel Holtmann 2008-08-07 118 { USB_DEVICE(0x044e, 0x3001) },
cfeb414537 Marcel Holtmann 2008-08-07 119 { USB_DEVICE(0x044e, 0x3002) },
cfeb414537 Marcel Holtmann 2008-08-07 120
cfeb414537 Marcel Holtmann 2008-08-07 121 /* Ericsson with non-standard id */
cfeb414537 Marcel Holtmann 2008-08-07 122 { USB_DEVICE(0x0bdb, 0x1002) },
cfeb414537 Marcel Holtmann 2008-08-07 123
cfeb414537 Marcel Holtmann 2008-08-07 124 /* Canyon CN-BTU1 with HID interfaces */
7a9d402053 Marcel Holtmann 2008-11-30 125 { USB_DEVICE(0x0c10, 0x0000) },
cfeb414537 Marcel Holtmann 2008-08-07 126
d13431ca3e Wen-chien Jesse Sung 2011-11-08 127 /* Broadcom BCM20702A0 */
d13431ca3e Wen-chien Jesse Sung 2011-11-08 128 { USB_DEVICE(0x413c, 0x8197) },
d13431ca3e Wen-chien Jesse Sung 2011-11-08 129
d049f4e513 Marcel Holtmann 2015-01-26 130 /* Broadcom BCM20702B0 (Dynex/Insignia) */
d049f4e513 Marcel Holtmann 2015-01-26 131 { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
d049f4e513 Marcel Holtmann 2015-01-26 132
2faf71ce90 Santtu Rekilä 2015-10-05 133 /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
6b3a9e1458 Dmitry Tunin 2017-07-06 134 { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
2faf71ce90 Santtu Rekilä 2015-10-05 135
a57bac4346 Christoph Haag 2017-02-10 136 /* Broadcom BCM920703 (HTC Vive) */
a57bac4346 Christoph Haag 2017-02-10 @137 { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
a57bac4346 Christoph Haag 2017-02-10 @138 .driver_info = BTUSB_BCM_PATCHRAM },
a57bac4346 Christoph Haag 2017-02-10 139
985140369b Steven Harms 2012-04-13 140 /* Foxconn - Hon Hai */
6029ddc233 Heinrich Siebmanns 2014-12-03 141 { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01),
6029ddc233 Heinrich Siebmanns 2014-12-03 142 .driver_info = BTUSB_BCM_PATCHRAM },
985140369b Steven Harms 2012-04-13 143
8f0c304c69 Matej Dubovy 2015-02-02 144 /* Lite-On Technology - Broadcom based */
8f0c304c69 Matej Dubovy 2015-02-02 145 { USB_VENDOR_AND_INTERFACE_INFO(0x04ca, 0xff, 0x01, 0x01),
8f0c304c69 Matej Dubovy 2015-02-02 146 .driver_info = BTUSB_BCM_PATCHRAM },
8f0c304c69 Matej Dubovy 2015-02-02 147
92c385f46b Gustavo Padovan 2012-08-06 148 /* Broadcom devices with vendor specific id */
10d4c6736e Petri Gynther 2014-05-08 149 { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01),
10d4c6736e Petri Gynther 2014-05-08 150 .driver_info = BTUSB_BCM_PATCHRAM },
92c385f46b Gustavo Padovan 2012-08-06 151
c2aef6e8cb Marcel Holtmann 2014-07-21 152 /* ASUSTek Computer - Broadcom based */
9a5abdaaf9 Rick Dunn 2015-01-17 153 { USB_VENDOR_AND_INTERFACE_INFO(0x0b05, 0xff, 0x01, 0x01),
9a5abdaaf9 Rick Dunn 2015-01-17 154 .driver_info = BTUSB_BCM_PATCHRAM },
c2aef6e8cb Marcel Holtmann 2014-07-21 155
5bcecf3253 Ken O'Brien 2013-09-21 156 /* Belkin F8065bf - Broadcom based */
6331c686e6 Marcel Holtmann 2015-03-27 157 { USB_VENDOR_AND_INTERFACE_INFO(0x050d, 0xff, 0x01, 0x01),
6331c686e6 Marcel Holtmann 2015-03-27 158 .driver_info = BTUSB_BCM_PATCHRAM },
5bcecf3253 Ken O'Brien 2013-09-21 159
9113bfd82d Jurgen Kramer 2014-02-15 160 /* IMC Networks - Broadcom based */
6331c686e6 Marcel Holtmann 2015-03-27 161 { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xff, 0x01, 0x01),
6331c686e6 Marcel Holtmann 2015-03-27 162 .driver_info = BTUSB_BCM_PATCHRAM },
9113bfd82d Jurgen Kramer 2014-02-15 163
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 164 /* Dell Computer - Broadcom based */
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 165 { USB_VENDOR_AND_INTERFACE_INFO(0x413c, 0xff, 0x01, 0x01),
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 166 .driver_info = BTUSB_BCM_PATCHRAM },
fdfddc6017 Wen-chien Jesse Sung 2017-01-10 167
1623d0bf84 Dmitry Tunin 2015-12-05 168 /* Toshiba Corp - Broadcom based */
1623d0bf84 Dmitry Tunin 2015-12-05 169 { USB_VENDOR_AND_INTERFACE_INFO(0x0930, 0xff, 0x01, 0x01),
1623d0bf84 Dmitry Tunin 2015-12-05 170 .driver_info = BTUSB_BCM_PATCHRAM },
1623d0bf84 Dmitry Tunin 2015-12-05 171
40df783d1e Marcel Holtmann 2014-07-06 172 /* Intel Bluetooth USB Bootloader (RAM module) */
d92f2df056 Marcel Holtmann 2014-07-06 @173 { USB_DEVICE(0x8087, 0x0a5a),
d92f2df056 Marcel Holtmann 2014-07-06 174 .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC },
40df783d1e Marcel Holtmann 2014-07-06 175
5e23b923da Marcel Holtmann 2007-10-20 176 { } /* Terminating entry */
5e23b923da Marcel Holtmann 2007-10-20 @177 };
5e23b923da Marcel Holtmann 2007-10-20 178
:::::: The code at line 138 was first introduced by commit
:::::: a57bac43468e005064d6560183b313b269403f0a Bluetooth: btusb: add support for 0bb4:0306
:::::: TO: Christoph Haag <haagch@frickel.club>
:::::: CC: Marcel Holtmann <marcel@holtmann.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 14809 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-06 11:29 [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin
` (2 preceding siblings ...)
2017-07-16 1:11 ` kbuild test robot
@ 2017-07-16 7:15 ` Marcel Holtmann
2017-07-16 7:53 ` Dmitry Tunin
2017-07-16 7:56 ` Dmitry Tunin
3 siblings, 2 replies; 8+ messages in thread
From: Marcel Holtmann @ 2017-07-16 7:15 UTC (permalink / raw)
To: Dmitry Tunin
Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth, linux-kernel, stable
Hi Dmitry,
> There is another device
>
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=105b ProdID=e066 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=342387DAE35E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Since we have Cls=ff, we can add all of them.
>
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fa24d69..bf95c13 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>
> /* Broadcom BCM920703 (HTC Vive) */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-16 7:15 ` Marcel Holtmann
@ 2017-07-16 7:53 ` Dmitry Tunin
2017-07-16 8:25 ` Marcel Holtmann
2017-07-16 7:56 ` Dmitry Tunin
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Tunin @ 2017-07-16 7:53 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth, linux-kernel, stable
Hi Marcel,
This one https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
is really garbled. But I wrote to you in a couple of minutes after I
sent it. And then sent the v2.
It looks like you applied a wrong one.
Regards,
Dmitry
2017-07-16 10:15 GMT+03:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Dmitry,
>
>> There is another device
>>
>> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=105b ProdID=e066 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=342387DAE35E
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Since we have Cls=ff, we can add all of them.
>>
>> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
>> Cc: stable@vger.kernel.org
>> ---
>> drivers/bluetooth/btusb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index fa24d69..bf95c13 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
>> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>>
>> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
>> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
>> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>>
>> /* Broadcom BCM920703 (HTC Vive) */
>> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
>
> this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
>
> Regards
>
> Marcel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-16 7:15 ` Marcel Holtmann
2017-07-16 7:53 ` Dmitry Tunin
@ 2017-07-16 7:56 ` Dmitry Tunin
1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Tunin @ 2017-07-16 7:56 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth, linux-kernel, stable
The one that is in your tree is correct. I see the problem. I added
the Cc: stable... to the first one and it got through there.
My apologies, I received the patch by mail and forwarded it. In a
second I found out the crap and fixed it.
2017-07-16 10:15 GMT+03:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Dmitry,
>
>> There is another device
>>
>> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=105b ProdID=e066 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=342387DAE35E
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Since we have Cls=ff, we can add all of them.
>>
>> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
>> Cc: stable@vger.kernel.org
>> ---
>> drivers/bluetooth/btusb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index fa24d69..bf95c13 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
>> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>>
>> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
>> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
>> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>>
>> /* Broadcom BCM920703 (HTC Vive) */
>> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
>
> this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
>
> Regards
>
> Marcel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices
2017-07-16 7:53 ` Dmitry Tunin
@ 2017-07-16 8:25 ` Marcel Holtmann
0 siblings, 0 replies; 8+ messages in thread
From: Marcel Holtmann @ 2017-07-16 8:25 UTC (permalink / raw)
To: Dmitry Tunin
Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth, linux-kernel, stable
Hi Dmitry,
> This one https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
> is really garbled. But I wrote to you in a couple of minutes after I
> sent it. And then sent the v2.
> It looks like you applied a wrong one.
funny. It popped up on the top of my inbox due to the 0day kbot picking it up now (10 days later) for some reason.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-16 8:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 11:29 [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin
2017-07-06 11:42 ` Dmitry Tunin
2017-07-16 0:20 ` kbuild test robot
2017-07-16 1:11 ` kbuild test robot
2017-07-16 7:15 ` Marcel Holtmann
2017-07-16 7:53 ` Dmitry Tunin
2017-07-16 8:25 ` Marcel Holtmann
2017-07-16 7:56 ` Dmitry Tunin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®