[PATCH v4 0/5] selftests: ftrace: ftracetest improvements

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH v4 0/5] selftests: ftrace: ftracetest improvements
@ 2017-07-07  0:58 Masami Hiramatsu
  2017-07-07  0:59 ` [PATCH v4 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  0:58 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Hello,

Here is v4 of ftracetest improvements, including test
return code change and immediate logging features.

This version just fixes a bug in [4/5] so that remove
unneeded backslash.

Thank you,

---

Masami Hiramatsu (5):
      selftests: ftrace: Do not failure if there is unsupported tests
      selftests: ftrace: Add --fail-unsupported option
      selftests: ftrace: Add more verbosity for immediate log
      selftests: ftrace: Output only to console with "--logdir -"
      selftests: ftrace: Check given string is not zero-length


 tools/testing/selftests/ftrace/ftracetest |   51 +++++++++++++++++++++--------
 1 file changed, 37 insertions(+), 14 deletions(-)

--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4 1/5] selftests: ftrace: Do not failure if there is unsupported tests
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
@ 2017-07-07  0:59 ` Masami Hiramatsu
  2017-07-07  1:00 ` [PATCH v4 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  0:59 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Do not return failure exit code (1) for unsupported testcases,
since it is expected for stable kernels.

Previously, ftracetest is expected to run only on current
release for avoiding regressions. However, nowadays we run
it on stable kernels. This means some test cases must return
unsupported result. In such case, we should NOT exit
ftracetest with error status for unsupported results so that
kselftest (upper tests wrapper) shows it passed correctly.

Note that we continue to treat unresolved results as failure,
if test writers would like to notice user that the test result
should be reviewed, they can use exit_unresolved.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 tools/testing/selftests/ftrace/ftracetest |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 14a03ea..290cd42 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -187,7 +187,7 @@ eval_result() { # sigval
     $UNSUPPORTED)
       prlog "	[UNSUPPORTED]"
       UNSUPPORTED_CASES="$UNSUPPORTED_CASES $CASENO"
-      return 1 # this is not a bug, but the result should be reported.
+      return 0 # this is not a bug.
     ;;
     $XFAIL)
       prlog "	[XFAIL]"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4 2/5] selftests: ftrace: Add --fail-unsupported option
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
  2017-07-07  0:59 ` [PATCH v4 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
@ 2017-07-07  1:00 ` Masami Hiramatsu
  2017-07-07  1:01 ` [PATCH v4 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  1:00 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Add --fail-unsupported option to fail the test result if
ftracetest gets UNSUPPORTED result. UNSUPPORTED usually
happens when the kernel is old (e.g. stable tree) or some
kernel feature is disabled.

However, if newer kernel has any bug or regression, it
can make test results in UNSUPPORTED too. This option
can detect such kernel regression.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 tools/testing/selftests/ftrace/ftracetest |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 290cd42..e033f54 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -15,6 +15,7 @@ echo "		-h|--help  Show help message"
 echo "		-k|--keep  Keep passed test logs"
 echo "		-v|--verbose Increase verbosity of test messages"
 echo "		-vv        Alias of -v -v (Show all results in stdout)"
+echo "		--fail-unsupported Treat UNSUPPORTED as a failure"
 echo "		-d|--debug Debug mode (trace all shell commands)"
 echo "		-l|--logdir <dir> Save logs on the <dir>"
 exit $1
@@ -65,6 +66,10 @@ parse_opts() { # opts
       DEBUG=1
       shift 1
     ;;
+    --fail-unsupported)
+      UNSUPPORTED_RESULT=1
+      shift 1
+    ;;
     --logdir|-l)
       LOG_DIR=$2
       shift 2
@@ -108,6 +113,7 @@ LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
 KEEP_LOG=0
 DEBUG=0
 VERBOSE=0
+UNSUPPORTED_RESULT=0
 # Parse command-line options
 parse_opts $*
 
@@ -187,7 +193,7 @@ eval_result() { # sigval
     $UNSUPPORTED)
       prlog "	[UNSUPPORTED]"
       UNSUPPORTED_CASES="$UNSUPPORTED_CASES $CASENO"
-      return 0 # this is not a bug.
+      return $UNSUPPORTED_RESULT # depends on use case
     ;;
     $XFAIL)
       prlog "	[XFAIL]"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4 3/5] selftests: ftrace: Add more verbosity for immediate log
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
  2017-07-07  0:59 ` [PATCH v4 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
  2017-07-07  1:00 ` [PATCH v4 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
@ 2017-07-07  1:01 ` Masami Hiramatsu
  2017-07-07  1:02 ` [PATCH v4 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  1:01 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Add 3-level verbosity for showing traced command log
on console immediately. Since some test cases can cause
kernel pacic if there is a probrem (like regression etc.),
we can not know which command caused the problem without
traced command log. This verbosity (-vvv) solves that
because it shows the log on console immediately. User
can get continuous command/error log.

Note that this is a kind of kernel debug mode, if you
don't see any kernel related issue, you don't need this
verbosity.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 tools/testing/selftests/ftrace/ftracetest |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index e033f54..892ca4e 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -15,6 +15,7 @@ echo "		-h|--help  Show help message"
 echo "		-k|--keep  Keep passed test logs"
 echo "		-v|--verbose Increase verbosity of test messages"
 echo "		-vv        Alias of -v -v (Show all results in stdout)"
+echo "		-vvv       Alias of -v -v -v (Show all commands immediately)"
 echo "		--fail-unsupported Treat UNSUPPORTED as a failure"
 echo "		-d|--debug Debug mode (trace all shell commands)"
 echo "		-l|--logdir <dir> Save logs on the <dir>"
@@ -57,9 +58,10 @@ parse_opts() { # opts
       KEEP_LOG=1
       shift 1
     ;;
-    --verbose|-v|-vv)
+    --verbose|-v|-vv|-vvv)
       VERBOSE=$((VERBOSE + 1))
       [ $1 = '-vv' ] && VERBOSE=$((VERBOSE + 1))
+      [ $1 = '-vvv' ] && VERBOSE=$((VERBOSE + 2))
       shift 1
     ;;
     --debug|-d)
@@ -258,7 +260,9 @@ run_test() { # testfile
   testcase $1
   echo "execute$INSTANCE: "$1 > $testlog
   SIG_RESULT=0
-  if [ $VERBOSE -ge 2 ]; then
+  if [ $VERBOSE -ge 3 ]; then
+    __run_test $1 | tee -a $testlog 2>&1
+  elif [ $VERBOSE -eq 2 ]; then
     __run_test $1 2>> $testlog | tee -a $testlog
   else
     __run_test $1 >> $testlog 2>&1
@@ -268,7 +272,7 @@ run_test() { # testfile
     # Remove test log if the test was done as it was expected.
     [ $KEEP_LOG -eq 0 ] && rm $testlog
   else
-    [ $VERBOSE -ge 1 ] && catlog $testlog
+    [ $VERBOSE -eq 1 -o $VERBOSE -eq 2 ] && catlog $testlog
     TOTAL_RESULT=1
   fi
   rm -rf $TMPDIR

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4 4/5] selftests: ftrace: Output only to console with "--logdir -"
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
                   ` (2 preceding siblings ...)
  2017-07-07  1:01 ` [PATCH v4 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
@ 2017-07-07  1:02 ` Masami Hiramatsu
  2017-07-07  1:03 ` [PATCH v4 5/5] selftests: ftrace: Check given string is not zero-length Masami Hiramatsu
  2017-07-24 15:39 ` [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Shuah Khan
  5 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  1:02 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Output logs only to console if "-" is given to --logdir
option. In this case, ftracetest doesn't record any log
on the disk, and all logs immediately shown (including
all command logs.) Since there is no "tee" in the middle
of command and console, it outputs the log really soon.

This option is useful only when the console is logged.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
  Changes in v4:
   - Fix to remove unneeded backslash (Thanks Stafford!)
---
 tools/testing/selftests/ftrace/ftracetest |   29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 892ca4e..cce1a0c 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -19,6 +19,7 @@ echo "		-vvv       Alias of -v -v -v (Show all commands immediately)"
 echo "		--fail-unsupported Treat UNSUPPORTED as a failure"
 echo "		-d|--debug Debug mode (trace all shell commands)"
 echo "		-l|--logdir <dir> Save logs on the <dir>"
+echo "		            If <dir> is -, all logs output in console only"
 exit $1
 }
 
@@ -127,14 +128,20 @@ if [ -z "$TRACING_DIR" -o ! -d "$TRACING_DIR" ]; then
 fi
 
 # Preparing logs
-LOG_FILE=$LOG_DIR/ftracetest.log
-mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
-date > $LOG_FILE
+if [ "x$LOG_DIR" = "x-" ]; then
+  LOG_FILE=
+  date
+else
+  LOG_FILE=$LOG_DIR/ftracetest.log
+  mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
+  date > $LOG_FILE
+fi
+
 prlog() { # messages
-  echo "$@" | tee -a $LOG_FILE
+  [ -z "$LOG_FILE" ] && echo "$@" || echo "$@" | tee -a $LOG_FILE
 }
 catlog() { #file
-  cat $1 | tee -a $LOG_FILE
+  [ -z "$LOG_FILE" ] && cat $1 || cat $1 | tee -a $LOG_FILE
 }
 prlog "=== Ftrace unit tests ==="
 
@@ -255,12 +262,18 @@ __run_test() { # testfile
 # Run one test case
 run_test() { # testfile
   local testname=`basename $1`
-  local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
+  if [ ! -z "$LOG_FILE" ] ; then
+    local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
+  else
+    local testlog=/proc/self/fd/1
+  fi
   export TMPDIR=`mktemp -d /tmp/ftracetest-dir.XXXXXX`
   testcase $1
   echo "execute$INSTANCE: "$1 > $testlog
   SIG_RESULT=0
-  if [ $VERBOSE -ge 3 ]; then
+  if [ -z "$LOG_FILE" ]; then
+    __run_test $1 2>&1
+  elif [ $VERBOSE -ge 3 ]; then
     __run_test $1 | tee -a $testlog 2>&1
   elif [ $VERBOSE -eq 2 ]; then
     __run_test $1 2>> $testlog | tee -a $testlog
@@ -270,7 +283,7 @@ run_test() { # testfile
   eval_result $SIG_RESULT
   if [ $? -eq 0 ]; then
     # Remove test log if the test was done as it was expected.
-    [ $KEEP_LOG -eq 0 ] && rm $testlog
+    [ $KEEP_LOG -eq 0 -a ! -z "$LOG_FILE" ] && rm $testlog
   else
     [ $VERBOSE -eq 1 -o $VERBOSE -eq 2 ] && catlog $testlog
     TOTAL_RESULT=1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4 5/5] selftests: ftrace: Check given string is not zero-length
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
                   ` (3 preceding siblings ...)
  2017-07-07  1:02 ` [PATCH v4 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
@ 2017-07-07  1:03 ` Masami Hiramatsu
  2017-07-24 15:39 ` [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Shuah Khan
  5 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-07  1:03 UTC (permalink / raw)
  To: linux-kselftest, shuah, Steven Rostedt
  Cc: mhiramat, Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne

Use [ ! -z "$VAR" ] instead of [ "$VAR" ] to check
whether the given string variable is not zero-length
since it obviously shows what it means.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 tools/testing/selftests/ftrace/ftracetest |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index cce1a0c..abc706c 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -8,7 +8,7 @@
 # Released under the terms of the GPL v2.
 
 usage() { # errno [message]
-[ "$2" ] && echo $2
+[ ! -z "$2" ] && echo $2
 echo "Usage: ftracetest [options] [testcase(s)] [testcase-directory(s)]"
 echo " Options:"
 echo "		-h|--help  Show help message"
@@ -50,7 +50,7 @@ parse_opts() { # opts
   local OPT_TEST_CASES=
   local OPT_TEST_DIR=
 
-  while [ "$1" ]; do
+  while [ ! -z "$1" ]; do
     case "$1" in
     --help|-h)
       usage 0
@@ -96,7 +96,7 @@ parse_opts() { # opts
     ;;
     esac
   done
-  if [ "$OPT_TEST_CASES" ]; then
+  if [ ! -z "$OPT_TEST_CASES" ]; then
     TEST_CASES=$OPT_TEST_CASES
   fi
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4 0/5] selftests: ftrace: ftracetest improvements
  2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
                   ` (4 preceding siblings ...)
  2017-07-07  1:03 ` [PATCH v4 5/5] selftests: ftrace: Check given string is not zero-length Masami Hiramatsu
@ 2017-07-24 15:39 ` Shuah Khan
  2017-07-26 21:25   ` Steven Rostedt
  5 siblings, 1 reply; 10+ messages in thread
From: Shuah Khan @ 2017-07-24 15:39 UTC (permalink / raw)
  To: Masami Hiramatsu, linux-kselftest, Steven Rostedt
  Cc: Ingo Molnar, linux-kernel, naresh.kamboju, Stafford Horne,
	Shuah Khan, Shuah Khan

On 07/06/2017 06:58 PM, Masami Hiramatsu wrote:
> Hello,
> 
> Here is v4 of ftracetest improvements, including test
> return code change and immediate logging features.
> 
> This version just fixes a bug in [4/5] so that remove
> unneeded backslash.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (5):
>       selftests: ftrace: Do not failure if there is unsupported tests
>       selftests: ftrace: Add --fail-unsupported option
>       selftests: ftrace: Add more verbosity for immediate log
>       selftests: ftrace: Output only to console with "--logdir -"
>       selftests: ftrace: Check given string is not zero-length
> 
> 
>  tools/testing/selftests/ftrace/ftracetest |   51 +++++++++++++++++++++--------
>  1 file changed, 37 insertions(+), 14 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
> 
> 

Hi Steve,

Okay to pull these in for 4.14-rc1? Sorry for the delay in responding.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4 0/5] selftests: ftrace: ftracetest improvements
  2017-07-24 15:39 ` [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Shuah Khan
@ 2017-07-26 21:25   ` Steven Rostedt
  2017-07-26 21:45     ` Shuah Khan
  0 siblings, 1 reply; 10+ messages in thread
From: Steven Rostedt @ 2017-07-26 21:25 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Masami Hiramatsu, linux-kselftest, Ingo Molnar, linux-kernel,
	naresh.kamboju, Stafford Horne, Shuah Khan

On Mon, 24 Jul 2017 09:39:25 -0600
Shuah Khan <shuah@kernel.org> wrote:


> > Masami Hiramatsu (5):
> >       selftests: ftrace: Do not failure if there is unsupported tests
> >       selftests: ftrace: Add --fail-unsupported option
> >       selftests: ftrace: Add more verbosity for immediate log
> >       selftests: ftrace: Output only to console with "--logdir -"
> >       selftests: ftrace: Check given string is not zero-length
> > 

> 
> Hi Steve,
> 
> Okay to pull these in for 4.14-rc1? Sorry for the delay in responding.
> 

I'm currently traveling, and not really able to test it. But a quick
look at the changes look fine to me.

Acked-by: Steven Rostedt (VMware) <srostedt@goodmis.org>

for the series. And yes please pull it in (if you haven't done so
already).

Thanks!

-- Steve

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4 0/5] selftests: ftrace: ftracetest improvements
  2017-07-26 21:25   ` Steven Rostedt
@ 2017-07-26 21:45     ` Shuah Khan
  2017-07-27  6:24       ` Masami Hiramatsu
  0 siblings, 1 reply; 10+ messages in thread
From: Shuah Khan @ 2017-07-26 21:45 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Masami Hiramatsu, linux-kselftest, Ingo Molnar, linux-kernel,
	naresh.kamboju, Stafford Horne, Shuah Khan, Shuah Khan

On 07/26/2017 03:25 PM, Steven Rostedt wrote:
> On Mon, 24 Jul 2017 09:39:25 -0600
> Shuah Khan <shuah@kernel.org> wrote:
> 
> 
>>> Masami Hiramatsu (5):
>>>       selftests: ftrace: Do not failure if there is unsupported tests
>>>       selftests: ftrace: Add --fail-unsupported option
>>>       selftests: ftrace: Add more verbosity for immediate log
>>>       selftests: ftrace: Output only to console with "--logdir -"
>>>       selftests: ftrace: Check given string is not zero-length
>>>
> 
>>
>> Hi Steve,
>>
>> Okay to pull these in for 4.14-rc1? Sorry for the delay in responding.
>>
> 
> I'm currently traveling, and not really able to test it. But a quick
> look at the changes look fine to me.
> 
> Acked-by: Steven Rostedt (VMware) <srostedt@goodmis.org>
> 
> for the series. And yes please pull it in (if you haven't done so
> already).
> 
> Thanks!
> 
> -- Steve
> 
> 

Hi Steve/Masami,

Applied the series to linux-kselftest next for 4.14-rc1

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4 0/5] selftests: ftrace: ftracetest improvements
  2017-07-26 21:45     ` Shuah Khan
@ 2017-07-27  6:24       ` Masami Hiramatsu
  0 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2017-07-27  6:24 UTC (permalink / raw)
  To: shuah
  Cc: Steven Rostedt, Masami Hiramatsu, linux-kselftest, Ingo Molnar,
	linux-kernel, naresh.kamboju, Stafford Horne, Shuah Khan

On Wed, 26 Jul 2017 15:45:52 -0600
Shuah Khan <shuah@kernel.org> wrote:

> On 07/26/2017 03:25 PM, Steven Rostedt wrote:
> > On Mon, 24 Jul 2017 09:39:25 -0600
> > Shuah Khan <shuah@kernel.org> wrote:
> > 
> > 
> >>> Masami Hiramatsu (5):
> >>>       selftests: ftrace: Do not failure if there is unsupported tests
> >>>       selftests: ftrace: Add --fail-unsupported option
> >>>       selftests: ftrace: Add more verbosity for immediate log
> >>>       selftests: ftrace: Output only to console with "--logdir -"
> >>>       selftests: ftrace: Check given string is not zero-length
> >>>
> > 
> >>
> >> Hi Steve,
> >>
> >> Okay to pull these in for 4.14-rc1? Sorry for the delay in responding.
> >>
> > 
> > I'm currently traveling, and not really able to test it. But a quick
> > look at the changes look fine to me.
> > 
> > Acked-by: Steven Rostedt (VMware) <srostedt@goodmis.org>
> > 
> > for the series. And yes please pull it in (if you haven't done so
> > already).
> > 
> > Thanks!
> > 
> > -- Steve
> > 
> > 
> 
> Hi Steve/Masami,
> 
> Applied the series to linux-kselftest next for 4.14-rc1

Thank you Shuah!


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-07-27  6:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07  0:58 [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-07  0:59 ` [PATCH v4 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
2017-07-07  1:00 ` [PATCH v4 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-07  1:01 ` [PATCH v4 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-07  1:02 ` [PATCH v4 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-07  1:03 ` [PATCH v4 5/5] selftests: ftrace: Check given string is not zero-length Masami Hiramatsu
2017-07-24 15:39 ` [PATCH v4 0/5] selftests: ftrace: ftracetest improvements Shuah Khan
2017-07-26 21:25   ` Steven Rostedt
2017-07-26 21:45     ` Shuah Khan
2017-07-27  6:24       ` Masami Hiramatsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome