mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/4] perf annotate: Fix --show-total-period and support --show-nr-samples
@ 2017-07-11 22:13 Taeung Song
  0 siblings, 0 replies; only message in thread
From: Taeung Song @ 2017-07-11 22:13 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: linux-kernel, Jiri Olsa, Milian Wolff, Namhyung Kim

Hello,

Currently the --show-total-period option of perf-annotate
is different from perf-report's.

It has two problem like below:

  1) Wrong column i.e. 'Percent' (even though using --show-total-period)
  2) Show number of samples, not period

So fix this option on both the annotate stdio and TUI browser.
And support --show-nr-samples into perf-anntate
so that it correpond with perf-report's.

The code is available on 'perf/ann-fix-period' branch at

  git://github.com/taeung/linux-perf.git

Thanks,
Taeung

Taeung Song (4):
  perf annotate: Fix wrong --show-total-period option showing number of
    samples
  perf anntoate browser: Fix the toggle total period view to show
    period, not number of samples
  perf annotate: Support --show-nr-samples option
  perf annotate browser: Support the toggle number of samples

 tools/perf/builtin-annotate.c     |   6 +--
 tools/perf/builtin-report.c       |  13 +++--
 tools/perf/builtin-top.c          |   6 ++-
 tools/perf/ui/browsers/annotate.c |  37 ++++++++++---
 tools/perf/ui/gtk/annotate.c      |   4 +-
 tools/perf/util/annotate.c        | 110 ++++++++++++++++++++++++++++----------
 tools/perf/util/annotate.h        |  14 +++--
 7 files changed, 139 insertions(+), 51 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-11 22:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 22:13 [PATCH 0/4] perf annotate: Fix --show-total-period and support --show-nr-samples Taeung Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®