mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: benjamin.gaignard@linaro.org
Cc: linaro-kernel@lists.linaro.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 01/22] x86: rtc: stop using rtc deprecated functions
Date: Wed, 12 Jul 2017 10:04:21 +0200	[thread overview]
Message-ID: <1499846682-14093-2-git-send-email-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>

rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
rely on 32bits variables and that will make rtc break in y2038/2016.
Stop using those two functions to safer 64bits ones.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: x86@kernel.org
CC: John Stultz <john.stultz@linaro.org>
CC: linux-kernel@vger.kernel.org
---
 arch/x86/kernel/rtc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index 5b21cb7..76b817c 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -40,11 +40,11 @@
  */
 int mach_set_rtc_mmss(const struct timespec *now)
 {
-	unsigned long nowtime = now->tv_sec;
+	unsigned long long nowtime = now->tv_sec;
 	struct rtc_time tm;
 	int retval = 0;
 
-	rtc_time_to_tm(nowtime, &tm);
+	rtc_time64_to_tm(nowtime, &tm);
 	if (!rtc_valid_tm(&tm)) {
 		retval = mc146818_set_time(&tm);
 		if (retval)
@@ -52,7 +52,7 @@ int mach_set_rtc_mmss(const struct timespec *now)
 			       __func__, retval);
 	} else {
 		printk(KERN_ERR
-		       "%s: Invalid RTC value: write of %lx to RTC failed\n",
+		       "%s: Invalid RTC value: write of %llx to RTC failed\n",
 			__func__, nowtime);
 		retval = -EINVAL;
 	}
-- 
1.9.1

       reply	other threads:[~2017-07-12  8:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
2017-07-12  8:04 ` Benjamin Gaignard [this message]
2017-07-12  8:04 ` [PATCH v2 02/22] x86: intel-mid: vrtc: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 03/22] net: broadcom: " Benjamin Gaignard
2017-07-12 20:01   ` Michael Chan
2017-07-12  8:04 ` [PATCH v2 04/22] rtc: ab-b5ze-s3: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 05/22] rtc: ab8500: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 06/22] rtc: cpcap: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 07/22] rtc: davinci: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 08/22] rtc: ds1305: " Benjamin Gaignard
2017-07-12  8:30   ` Alexandre Belloni
2017-07-12  8:04 ` [PATCH v2 09/22] rtc: ds1511: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 10/22] rtc: ds1553: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 11/22] rtc: gemini: " Benjamin Gaignard
2017-07-12 17:20   ` Hans Ulli Kroll
2017-07-12  8:04 ` [PATCH v2 12/22] rtc: mv: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 13/22] rtc: omap: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 14/22] rtc: pcap: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 15/22] rtc: rs5c348: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 16/22] rtc: sh: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 17/22] rtc: snvs: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 18/22] rtc: stk17ta8: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 19/22] rtc: sun6i: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 20/22] rtc: sysfs: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 21/22] rtc: test: " Benjamin Gaignard
2017-07-12  8:04 ` [PATCH v2 22/22] power: suspend " Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499846682-14093-2-git-send-email-benjamin.gaignard@linaro.org \
    --to=benjamin.gaignard@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®