From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: benjamin.gaignard@linaro.org
Cc: linaro-kernel@lists.linaro.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [PATCH v2 20/22] rtc: sysfs: stop using rtc deprecated functions
Date: Wed, 12 Jul 2017 10:04:40 +0200 [thread overview]
Message-ID: <1499846682-14093-21-git-send-email-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
rely on 32bits variables and that will make rtc break in y2038/2016.
Stop using those two functions to safer 64bits ones.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Alexandre Belloni <alexandre.belloni@free-electrons.com>
CC: rtc-linux@googlegroups.com
CC: linux-kernel@vger.kernel.org
---
drivers/rtc/rtc-sysfs.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c
index e364550..8b97def 100644
--- a/drivers/rtc/rtc-sysfs.c
+++ b/drivers/rtc/rtc-sysfs.c
@@ -72,9 +72,10 @@
retval = rtc_read_time(to_rtc_device(dev), &tm);
if (retval == 0) {
- unsigned long time;
- rtc_tm_to_time(&tm, &time);
- retval = sprintf(buf, "%lu\n", time);
+ unsigned long long time;
+
+ time = rtc_tm_to_time64(&tm);
+ retval = sprintf(buf, "%llu\n", time);
}
return retval;
@@ -132,7 +133,7 @@
wakealarm_show(struct device *dev, struct device_attribute *attr, char *buf)
{
ssize_t retval;
- unsigned long alarm;
+ unsigned long long alarm;
struct rtc_wkalrm alm;
/* Don't show disabled alarms. For uniformity, RTC alarms are
@@ -145,8 +146,8 @@
*/
retval = rtc_read_alarm(to_rtc_device(dev), &alm);
if (retval == 0 && alm.enabled) {
- rtc_tm_to_time(&alm.time, &alarm);
- retval = sprintf(buf, "%lu\n", alarm);
+ alarm = rtc_tm_to_time64(&alm.time);
+ retval = sprintf(buf, "%llu\n", alarm);
}
return retval;
@@ -157,8 +158,8 @@
const char *buf, size_t n)
{
ssize_t retval;
- unsigned long now, alarm;
- unsigned long push = 0;
+ unsigned long long now, alarm;
+ unsigned long long push = 0;
struct rtc_wkalrm alm;
struct rtc_device *rtc = to_rtc_device(dev);
const char *buf_ptr;
@@ -170,7 +171,7 @@
retval = rtc_read_time(rtc, &alm.time);
if (retval < 0)
return retval;
- rtc_tm_to_time(&alm.time, &now);
+ now = rtc_tm_to_time64(&alm.time);
buf_ptr = buf;
if (*buf_ptr == '+') {
@@ -181,7 +182,7 @@
} else
adjust = 1;
}
- retval = kstrtoul(buf_ptr, 0, &alarm);
+ retval = kstrtoull(buf_ptr, 0, &alarm);
if (retval)
return retval;
if (adjust) {
@@ -197,7 +198,7 @@
return retval;
if (alm.enabled) {
if (push) {
- rtc_tm_to_time(&alm.time, &push);
+ push = rtc_tm_to_time64(&alm.time);
alarm += push;
} else
return -EBUSY;
@@ -212,7 +213,7 @@
*/
alarm = now + 300;
}
- rtc_time_to_tm(alarm, &alm.time);
+ rtc_time64_to_tm(alarm, &alm.time);
retval = rtc_set_alarm(rtc, &alm);
return (retval < 0) ? retval : n;
--
1.9.1
next prev parent reply other threads:[~2017-07-12 8:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
2017-07-12 8:04 ` [PATCH v2 01/22] x86: rtc: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 02/22] x86: intel-mid: vrtc: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 03/22] net: broadcom: " Benjamin Gaignard
2017-07-12 20:01 ` Michael Chan
2017-07-12 8:04 ` [PATCH v2 04/22] rtc: ab-b5ze-s3: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 05/22] rtc: ab8500: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 06/22] rtc: cpcap: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 07/22] rtc: davinci: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 08/22] rtc: ds1305: " Benjamin Gaignard
2017-07-12 8:30 ` Alexandre Belloni
2017-07-12 8:04 ` [PATCH v2 09/22] rtc: ds1511: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 10/22] rtc: ds1553: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 11/22] rtc: gemini: " Benjamin Gaignard
2017-07-12 17:20 ` Hans Ulli Kroll
2017-07-12 8:04 ` [PATCH v2 12/22] rtc: mv: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 13/22] rtc: omap: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 14/22] rtc: pcap: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 15/22] rtc: rs5c348: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 16/22] rtc: sh: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 17/22] rtc: snvs: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 18/22] rtc: stk17ta8: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 19/22] rtc: sun6i: " Benjamin Gaignard
2017-07-12 8:04 ` Benjamin Gaignard [this message]
2017-07-12 8:04 ` [PATCH v2 21/22] rtc: test: " Benjamin Gaignard
2017-07-12 8:04 ` [PATCH v2 22/22] power: suspend " Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499846682-14093-21-git-send-email-benjamin.gaignard@linaro.org \
--to=benjamin.gaignard@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®