* [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address
@ 2026-05-28 12:03 Krzysztof Kozlowski
2026-05-28 14:10 ` Daniel Lezcano
2026-06-01 21:03 ` Frank.Li
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-28 12:03 UTC (permalink / raw)
To: Chester Lin, Matthias Brugger, Ghennadi Procopciuc,
NXP S32 Linux Team, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Lezcano, Shawn Guo,
linux-arm-kernel, imx, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, stable
Add missing hex annotation to fix the SWT8 watchdog address in 'reg'
property, as reported by dtc W=1:
s32g3.dtsi:863.27-869.5: Warning (simple_bus_reg): /soc@0/watchdog@40500000: simple-bus unit address format error, expected "269fb20"
Lack of hex '0x' meant address would be interpreted as decimal thus
completely different value used as this device MMIO. If device was
enabled this could lead to corruption of other device address space and
broken boot.
Cc: <stable@vger.kernel.org>
Fixes: 6db84f042745 ("arm64: dts: s32g3: Add the Software Timer Watchdog (SWT) nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/freescale/s32g3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
index e314f3c7d61d..7e28dff53a86 100644
--- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
+++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
@@ -862,7 +862,7 @@ gmac0mdio: mdio {
swt8: watchdog@40500000 {
compatible = "nxp,s32g3-swt", "nxp,s32g2-swt";
- reg = <40500000 0x1000>;
+ reg = <0x40500000 0x1000>;
clocks = <&clks 0x3a>, <&clks 0x3b>, <&clks 0x3b>;
clock-names = "counter", "module", "register";
status = "disabled";
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address
2026-05-28 12:03 [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address Krzysztof Kozlowski
@ 2026-05-28 14:10 ` Daniel Lezcano
2026-06-01 21:03 ` Frank.Li
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2026-05-28 14:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Chester Lin, Matthias Brugger,
Ghennadi Procopciuc, NXP S32 Linux Team, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Lezcano, Shawn Guo,
linux-arm-kernel, imx, devicetree, linux-kernel
Cc: stable
On 5/28/26 14:03, Krzysztof Kozlowski wrote:
> Add missing hex annotation to fix the SWT8 watchdog address in 'reg'
> property, as reported by dtc W=1:
>
> s32g3.dtsi:863.27-869.5: Warning (simple_bus_reg): /soc@0/watchdog@40500000: simple-bus unit address format error, expected "269fb20"
>
> Lack of hex '0x' meant address would be interpreted as decimal thus
> completely different value used as this device MMIO. If device was
> enabled this could lead to corruption of other device address space and
> broken boot.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 6db84f042745 ("arm64: dts: s32g3: Add the Software Timer Watchdog (SWT) nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Thanks for the fix
> ---
> arch/arm64/boot/dts/freescale/s32g3.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> index e314f3c7d61d..7e28dff53a86 100644
> --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> @@ -862,7 +862,7 @@ gmac0mdio: mdio {
>
> swt8: watchdog@40500000 {
> compatible = "nxp,s32g3-swt", "nxp,s32g2-swt";
> - reg = <40500000 0x1000>;
> + reg = <0x40500000 0x1000>;
> clocks = <&clks 0x3a>, <&clks 0x3b>, <&clks 0x3b>;
> clock-names = "counter", "module", "register";
> status = "disabled";
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address
2026-05-28 12:03 [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address Krzysztof Kozlowski
2026-05-28 14:10 ` Daniel Lezcano
@ 2026-06-01 21:03 ` Frank.Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank.Li @ 2026-06-01 21:03 UTC (permalink / raw)
To: Chester Lin, Matthias Brugger, Ghennadi Procopciuc,
NXP S32 Linux Team, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Daniel Lezcano, Shawn Guo, linux-arm-kernel, imx, devicetree,
linux-kernel, Krzysztof Kozlowski
Cc: Frank Li, stable
From: Frank Li <Frank.Li@nxp.com>
On Thu, 28 May 2026 14:03:24 +0200, Krzysztof Kozlowski wrote:
> Add missing hex annotation to fix the SWT8 watchdog address in 'reg'
> property, as reported by dtc W=1:
>
> s32g3.dtsi:863.27-869.5: Warning (simple_bus_reg): /soc@0/watchdog@40500000: simple-bus unit address format error, expected "269fb20"
>
> Lack of hex '0x' meant address would be interpreted as decimal thus
> completely different value used as this device MMIO. If device was
> enabled this could lead to corruption of other device address space and
> broken boot.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: s32g3: Fix SWT8 watchdog address
commit: 34faa9fbda5cc78479851fcd94f3b94f91b0cd84
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-01 21:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-28 12:03 [PATCH] arm64: dts: s32g3: Fix SWT8 watchdog address Krzysztof Kozlowski
2026-05-28 14:10 ` Daniel Lezcano
2026-06-01 21:03 ` Frank.Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®