From: "André Almeida" <andrealmeid@igalia.com>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: magalilemes00@gmail.com, christian.koenig@amd.com,
Daniel Vetter <daniel@ffwll.ch>,
Xinhui.Pan@amd.com, Alex Deucher <alexander.deucher@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Leo Li <sunpeng.li@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
tales.aparecida@gmail.com, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, mwen@igalia.com,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
Isabella Basso <isabbasso@riseup.net>,
andrealmeid@riseup.net, Harry Wentland <harry.wentland@amd.com>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH 2/4] drm/amd/display: Remove duplicated CalculateWriteBackDISPCLK
Date: Thu, 21 Jul 2022 10:34:56 -0300 [thread overview]
Message-ID: <14e11a4b-7300-a54d-6794-1eeb7ab8a079@igalia.com> (raw)
In-Reply-To: <20220720182228.259119-2-mairacanal@riseup.net>
Às 15:22 de 20/07/22, Maíra Canal escreveu:
> The functions dml30_CalculateWriteBackDISPCLK and
> dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid
> code duplication, dml31_CalculateWriteBackDISPCLK is removed and
> replaced by dml30_CalculateWriteBackDISPCLK.
>
The message should be in imperative mood:
"to avoid code duplication, dml31_CalculateWriteBackDISPCLK is removed
and replaced by dml30_CalculateWriteBackDISPCLK." -> "to avoid code
duplication, replace dml31_CalculateWriteBackDISPCLK by
dml30_CalculateWriteBackDISPCLK"
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> ---
next prev parent reply other threads:[~2022-07-21 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 18:22 [PATCH 1/4] drm/amd/display: Drop dm_sw_gfx7_2d_thin_l_vp and dm_sw_gfx7_2d_thin_gl Maíra Canal
2022-07-20 18:22 ` [PATCH 2/4] drm/amd/display: Remove duplicated CalculateWriteBackDISPCLK Maíra Canal
2022-07-21 13:34 ` André Almeida [this message]
2022-07-20 18:22 ` [PATCH 3/4] drm/amd/display: Remove parameters from rq_dlg_get_dlg_reg Maíra Canal
2022-07-20 18:22 ` [PATCH 4/4] drm/amd/display: Rewrite CalculateWriteBackDISPCLK function Maíra Canal
2022-07-21 13:31 ` [PATCH 1/4] drm/amd/display: Drop dm_sw_gfx7_2d_thin_l_vp and dm_sw_gfx7_2d_thin_gl André Almeida
2022-07-21 18:26 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14e11a4b-7300-a54d-6794-1eeb7ab8a079@igalia.com \
--to=andrealmeid@igalia.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@riseup.net \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=harry.wentland@amd.com \
--cc=isabbasso@riseup.net \
--cc=linux-kernel@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=mwen@igalia.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®