* [PATCH 09/11] net: ec_bhf: constify pci_device_id.
@ 2017-07-17 18:12 Arvind Yadav
2017-07-17 20:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-17 18:12 UTC (permalink / raw)
To: reksio, kvalo; +Cc: netdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5113 384 0 5497 1579 drivers/net/ethernet/ec_bhf.o
File size After adding 'const':
text data bss dec hex filename
5177 320 0 5497 1579 drivers/net/ethernet/ec_bhf.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/ethernet/ec_bhf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c
index 4ee042c..1b79a6d 100644
--- a/drivers/net/ethernet/ec_bhf.c
+++ b/drivers/net/ethernet/ec_bhf.c
@@ -73,7 +73,7 @@
#define ETHERCAT_MASTER_ID 0x14
-static struct pci_device_id ids[] = {
+static const struct pci_device_id ids[] = {
{ PCI_DEVICE(0x15ec, 0x5000), },
{ 0, }
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 09/11] net: ec_bhf: constify pci_device_id.
2017-07-17 18:12 [PATCH 09/11] net: ec_bhf: constify pci_device_id Arvind Yadav
@ 2017-07-17 20:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-17 20:38 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: reksio, kvalo, netdev, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Mon, 17 Jul 2017 23:42:34 +0530
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 5113 384 0 5497 1579 drivers/net/ethernet/ec_bhf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 5177 320 0 5497 1579 drivers/net/ethernet/ec_bhf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-17 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:12 [PATCH 09/11] net: ec_bhf: constify pci_device_id Arvind Yadav
2017-07-17 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®