mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, bp@alien8.de, tony.luck@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] x86: ksysfs: constify attribute_group structures.
Date: Thu, 20 Jul 2017 12:51:43 +0530	[thread overview]
Message-ID: <1500535305-9369-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com>

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   1183	    384	      0	   1567	    61f	arch/x86/kernel/ksysfs.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   1311	    256	      0	   1567	    61f	arch/x86/kernel/ksysfs.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 arch/x86/kernel/ksysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/ksysfs.c b/arch/x86/kernel/ksysfs.c
index 4afc67f..06e1ff5 100644
--- a/arch/x86/kernel/ksysfs.c
+++ b/arch/x86/kernel/ksysfs.c
@@ -55,7 +55,7 @@ static ssize_t boot_params_data_read(struct file *fp, struct kobject *kobj,
 	NULL,
 };
 
-static struct attribute_group boot_params_attr_group = {
+static const struct attribute_group boot_params_attr_group = {
 	.attrs = boot_params_version_attrs,
 	.bin_attrs = boot_params_data_attrs,
 };
@@ -202,7 +202,7 @@ static ssize_t setup_data_data_read(struct file *fp,
 	NULL,
 };
 
-static struct attribute_group setup_data_attr_group = {
+static const struct attribute_group setup_data_attr_group = {
 	.attrs = setup_data_type_attrs,
 	.bin_attrs = setup_data_data_attrs,
 };
-- 
1.9.1

  parent reply	other threads:[~2017-07-20  7:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20  7:21 [PATCH 0/7] constify x86 " Arvind Yadav
2017-07-20  7:21 ` [PATCH 1/7] perf: x86: intel: uncore: constify " Arvind Yadav
2017-07-20  7:21 ` [PATCH 2/7] perf: x86: intel: uncore_nhmex: " Arvind Yadav
2017-07-20  7:21 ` [PATCH 3/7] perf: x86: intel: uncore_snb: " Arvind Yadav
2017-07-20  7:21 ` [PATCH 4/7] perf: x86: intel: uncore_snbep: " Arvind Yadav
2017-07-20  7:21 ` Arvind Yadav [this message]
2017-07-20  7:21 ` [PATCH 6/7] x86: therm_throt: " Arvind Yadav
2017-07-20  7:21 ` [PATCH 7/7] x86: microcode: " Arvind Yadav
2017-07-20  8:12   ` Borislav Petkov
2017-07-20  8:18     ` Arvind Yadav
2017-07-20  8:28       ` Borislav Petkov
2017-07-20  9:01         ` Arvind Yadav
2017-07-20 10:31           ` Borislav Petkov
2017-07-20 11:01             ` Arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500535305-9369-6-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®