From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, tony.luck@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.
Date: Thu, 20 Jul 2017 16:31:38 +0530 [thread overview]
Message-ID: <3725e8de-7b65-165a-41cc-499771a4eaae@gmail.com> (raw)
In-Reply-To: <20170720103105.GD18424@nazgul.tnic>
Hi,
On Thursday 20 July 2017 04:01 PM, Borislav Petkov wrote:
> On Thu, Jul 20, 2017 at 02:31:09PM +0530, Arvind Yadav wrote:
>>> "Constify attribute_group structs because they don't change at runtime."
>> I can add this as subject. But we should avoid lengthy subject.
> Are you actually reading what I'm writing to you? I said this should be
> the commit message, not the subject.
>
> What I'm saying is, shorten your commit message - no need for the
> irrelevant before/after sizes. I'm not the first reviewer to ask WTF do
> those things even mean.
>
Thanks :) for your suggestion. I will remove before/after size comparison.
and send you back for review.
~arvind
prev parent reply other threads:[~2017-07-20 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:21 [PATCH 0/7] constify x86 " Arvind Yadav
2017-07-20 7:21 ` [PATCH 1/7] perf: x86: intel: uncore: constify " Arvind Yadav
2017-07-20 7:21 ` [PATCH 2/7] perf: x86: intel: uncore_nhmex: " Arvind Yadav
2017-07-20 7:21 ` [PATCH 3/7] perf: x86: intel: uncore_snb: " Arvind Yadav
2017-07-20 7:21 ` [PATCH 4/7] perf: x86: intel: uncore_snbep: " Arvind Yadav
2017-07-20 7:21 ` [PATCH 5/7] x86: ksysfs: " Arvind Yadav
2017-07-20 7:21 ` [PATCH 6/7] x86: therm_throt: " Arvind Yadav
2017-07-20 7:21 ` [PATCH 7/7] x86: microcode: " Arvind Yadav
2017-07-20 8:12 ` Borislav Petkov
2017-07-20 8:18 ` Arvind Yadav
2017-07-20 8:28 ` Borislav Petkov
2017-07-20 9:01 ` Arvind Yadav
2017-07-20 10:31 ` Borislav Petkov
2017-07-20 11:01 ` Arvind Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725e8de-7b65-165a-41cc-499771a4eaae@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®