mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	fweisbec@gmail.com, oleg@redhat.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 03/12] torture: Fix typo suppressing CPU-hotplug statistics
Date: Mon, 24 Jul 2017 14:51:47 -0700	[thread overview]
Message-ID: <1500933116-11642-3-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170724215139.GA10881@linux.vnet.ibm.com>

The torture status line contains a series of values preceded by "onoff:".
The last value in that line, the one preceding the "HZ=" string, is
always zero.  The reason that it is always zero is that torture_offline()
was incrementing the sum_offl pointer instead of the value that this
pointer referenced.  This commit therefore makes this increment operate
on the statistic rather than the pointer to the statistic.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/torture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/torture.c b/kernel/torture.c
index 55de96529287..637e172835d8 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -117,7 +117,7 @@ bool torture_offline(int cpu, long *n_offl_attempts, long *n_offl_successes,
 				 torture_type, cpu);
 		(*n_offl_successes)++;
 		delta = jiffies - starttime;
-		sum_offl += delta;
+		*sum_offl += delta;
 		if (*min_offl < 0) {
 			*min_offl = delta;
 			*max_offl = delta;
-- 
2.5.2

  parent reply	other threads:[~2017-07-24 21:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 21:51 [PATCH tip/core/rcu 0/12] CPU-hotplug updates Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 01/12] rcu: Make expedited GPs correctly handle hardware CPU insertion Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 02/12] rcu: Migrate callbacks earlier in the CPU-offline timeline Paul E. McKenney
2017-07-24 21:51 ` Paul E. McKenney [this message]
2017-07-24 21:51 ` [PATCH tip/core/rcu 04/12] rcu: Remove orphan/adopt event-tracing fields Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 05/12] rcu: Check for NOCB CPUs and empty lists earlier in CB migration Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 06/12] rcu: Make NOCB CPUs migrate CBs directly from outgoing CPU Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 07/12] rcu: Advance outgoing CPU's callbacks before migrating them Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 08/12] rcu: Eliminate rcu_state ->orphan_lock Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 09/12] rcu: Advance callbacks after migration Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 10/12] rcu: Localize rcu_state ->orphan_pend and ->orphan_done Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 11/12] rcu: Remove unused RCU list functions Paul E. McKenney
2017-07-24 21:51 ` [PATCH tip/core/rcu 12/12] rcu: Move callback-list warning to irq-disable region Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500933116-11642-3-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®