mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency
Date: Tue, 25 Jul 2017 13:52:57 +0200	[thread overview]
Message-ID: <1500983577.4101.16.camel@pengutronix.de> (raw)
In-Reply-To: <CAK8P3a3k3wRzcGSaSdEJ-YZshrREygZ+i9HKn56QYN+mHDBgTg@mail.gmail.com>

On Tue, 2017-07-25 at 13:35 +0200, Arnd Bergmann wrote:
> On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote:
> >> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >> > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote:
> 
> >> If you only need build-testing, you could have a simple wrapper like
> >>
> >> const struct drm_format_info *ipu_format_info(u32 format)
> >> {
> >>          static const struct drm_format_info invalid = {};
> >>
> >>          if (!IS_REACHABLE(CONFIG_DRM))
> >>                   return &invalid;
> >>
> >>          return drm_format_info(format);
> >> }
> >
> > That should work fine. Both ipu_prg_format_supported and
> > ipu_prg_channel_configure are only ever called by DRM code.
> 
> Ok, in that case, I think we should just make the compilation
> of PRE and PRG conditional and leave them out when DRM
> is not built-in (be aware of the case of DRM=m, IPU=y).

Maybe we should just:

config IMX_IPUV3_CORE
	depends on DRM || !DRM # if DRM=m, this can't be 'y'

regards
Philipp

  reply	other threads:[~2017-07-25 11:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 20:56 Arnd Bergmann
2017-07-24  8:05 ` Philipp Zabel
2017-07-25  7:33   ` Arnd Bergmann
2017-07-25  8:03     ` Philipp Zabel
2017-07-25 11:35       ` Arnd Bergmann
2017-07-25 11:52         ` Philipp Zabel [this message]
2017-07-25 11:58           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500983577.4101.16.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=arnd@arndb.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®